From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BB15C4332F for ; Thu, 17 Nov 2022 13:16:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9WLfYwoRiDHK92W7LUoud6Z8fxXHL3fbMQqEaw3z67s=; b=ZbogZPGaOPXqJO 7f5DrJ+09+lENNrzFj2wkJPgOQ5vTcFW2jqrgKl1rIqVz6T9PlIkekpimbeeJnoKsHvW+rOhmDsF5 djikqy75IlGPIVEZhtK2573HZ4L3m0BWbOdSJT4B6TlVOmXGgQHoVxF61pUenPHH0CjPkeDR7AWlr S2/szCKr0PWsAvYiSe6syvLGWfV+PEaWKhQ2Tj7r5DmGLLVcddEyWGRWKZRaZ9jFrZIWPCzopobak KHuVu4bbXnrFB+xKPrYmR51oB+4euGwq4eVHB73LPV3sStHMQPjwmDu8kIz/My4V6Dct1I7y1Vvkh wsxdDajvl0OWp9zUJ77g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovejK-00E7nw-Ve; Thu, 17 Nov 2022 13:14:59 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oveiL-00E7GZ-NA; Thu, 17 Nov 2022 13:14:01 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 090B8CE1D6A; Thu, 17 Nov 2022 13:13:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2314FC433C1; Thu, 17 Nov 2022 13:13:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1668690832; bh=8/wv6QDY2hSZTUr8xypWmCWEqdTGGHFAJ/VXIdpEZSc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B1VKBD4uF4pb0NzSYTn7Q16gq7Hm7S+f5YcWkipELr0PetzS/U0eGOntQ1FX9fnC2 b4mHTcqdMlHLPiDMaauEYQ5EnBlORdt4R4QHnJ7JiReoYqJrutOWKktUKZo7UVmS6g lxSbuiWx0L8/4uPZ7h1JBfMDGfgxQEuFXV+Hh1ns= Date: Thu, 17 Nov 2022 14:13:46 +0100 From: Greg Kroah-Hartman To: Umang Jain Cc: Florian Fainelli , Broadcom internal kernel review list , Stefan Wahren , Hans Verkuil , Dave Stevenson , Mauro Carvalho Chehab , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kieran.bingham@ideasonboard.com Subject: Re: [PATCH 1/2] staging: vc04_services: mmal-vchiq: Do not assign bool to u32 Message-ID: References: <20221117125953.88441-1-umang.jain@ideasonboard.com> <20221117125953.88441-2-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221117125953.88441-2-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221117_051357_991936_D741FB0C X-CRM114-Status: GOOD ( 16.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 17, 2022 at 06:29:52PM +0530, Umang Jain wrote: > From: Dave Stevenson > > struct vchiq_mmal_component.enabled is a u32 type. Do not assign > it a bool. > > Fixes: 640e77466e69 ("staging: mmal-vchiq: Avoid use of bool in structures") > Signed-off-by: Dave Stevenson > Signed-off-by: Umang Jain > --- > drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > index cb921c94996a..17f8ceda87ca 100644 > --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > @@ -1773,7 +1773,7 @@ int vchiq_mmal_component_enable(struct vchiq_mmal_instance *instance, > > ret = enable_component(instance, component); > if (ret == 0) > - component->enabled = true; > + component->enabled = 1; Why not make enabled a bool instead? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel