From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73788C4332F for ; Fri, 18 Nov 2022 08:37:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jmHpntju8SZXKBGLdzg/A/Fc3pKSyEGEdfxvKLiSktA=; b=O/Q4FK1/J9lf5t 0+LGDSRUrWZWsP3aIU4CQLYctbo8q8jFKiQWxSleOzrbQVW/3YWY/+v1mIrmnqEw0/XFPIg1COptM 1r9llyRzZXyOh3390nz70QXPboKK8iWTBTUs6nSjS0dHS0bo8e+tBDXmHgS35RtiMxEjI2HiiNYWm UXYYArGhGjV9fuYM0jrAdC8oD2UWaenyvodZmEB5mdcXunqfgWkEl6qunqfeI/pgJHTdSvHuWseZE 0PaHRA2gqQxH9f8WalNSk85bs8ctIjQ8kFqTOmF7icFA4uC40AlpVEgxMYk/SElR/zvPn76pyLxhu R/ATDYn2UNEkTFEsK5zA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovwqw-002oDG-24; Fri, 18 Nov 2022 08:36:02 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovwqt-002oC6-DT; Fri, 18 Nov 2022 08:36:00 +0000 Received: by mail-wm1-x334.google.com with SMTP id p13-20020a05600c468d00b003cf8859ed1bso3528803wmo.1; Fri, 18 Nov 2022 00:35:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sZBJWsvuPM4N2XNgGuD0Fakzbbh9G5ci/DsGRyhIEdY=; b=bHGQfWHm3z3WfK33pmq9dlJOKNe03OeJp8opslres0KGRyyM4Da5kMG28KGUnBQdZC l9FVIn02fotJTFGEW2mp0UPJY0Dv22nW97wBkpIpwq/YTlrcrE4pTMWxw5Mn9XEsl//H tVot2J6vWtg2iBpIfPhruW8kaSBPK8jbKxDD0anU1IRwyhAoUpvO2s4jQIMRMjRVlutx g7qfLtgVN/iTTZCLePMtmadGA9ELPDI52fAfZWoKncymcDepeYnqU+3oM5p66eqMCvXy mxfQA4WVE9x0zlv8M619hy96MSUGohRBf9xHo5uUWp9nrXmObbgv8a2RpP97HybC/Awx bXKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sZBJWsvuPM4N2XNgGuD0Fakzbbh9G5ci/DsGRyhIEdY=; b=mGN0xGTGY8SqrH+eSJ/ILHc7Cbe0Vho+AaCtcbEZKffM5Igrrb3lRHdlQwU69gLwi6 S/vNA1SY1jxnZd2U+Jc12ed6SqCkJqw+l4vBnioobqNj4jkmqccElwp5hEgKFdJl0hon y5eIO2N9Bf7vRpLJyk3dAC8G0A4HF98KiPctccCgBIBUYn/+RF52ELnHw+oNyHf/2zD/ opUGBMzxfvrb9Vs3FUynK69vrOA7zVCwKOWn9609WVepLPfWCtHFEgnK1L52TV0YqcWk X3b/pb3ktCjtq6BTEMVpC6RclVwcy9lOgTdWuXBySjjE/shJDW7hHpVmhcCQO3spPUhT 3rEQ== X-Gm-Message-State: ANoB5pmARhY4hedE7bnJNgOW5BfrgM6yy4NwhaGCgz3nJzBnROptYqlF TVl9+bQIRGdljhuSFmFPiak= X-Google-Smtp-Source: AA0mqf60YsmnRdTamyBcHrdL4qYmUzr0MzwnwfkljypGszjucXInCUwcNUvqDYFv+EfSlNtYYPr1rg== X-Received: by 2002:a05:600c:4f12:b0:3cf:e7bd:303a with SMTP id l18-20020a05600c4f1200b003cfe7bd303amr7953544wmq.151.1668760556423; Fri, 18 Nov 2022 00:35:56 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id v3-20020a1cf703000000b003cf774c31a0sm7538328wmh.16.2022.11.18.00.35.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 00:35:55 -0800 (PST) Date: Fri, 18 Nov 2022 11:35:52 +0300 From: Dan Carpenter To: Andrew Lunn Cc: Umang Jain , Greg Kroah-Hartman , Kieran Bingham , Broadcom internal kernel review list , Dave Stevenson , Florian Fainelli , Hans Verkuil , Mauro Carvalho Chehab , Ray Jui , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 1/3] Revert "staging: mmal-vchiq: Avoid use of bool in structures" Message-ID: References: <20221117160015.344528-1-umang.jain@ideasonboard.com> <20221117160015.344528-2-umang.jain@ideasonboard.com> <166870135963.50677.14827688186331561108@Monstersaurus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221118_003559_511673_51499712 X-CRM114-Status: GOOD ( 11.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 18, 2022 at 01:12:32AM +0100, Andrew Lunn wrote: > > Does :1 really initialise the variable? Obviously not. > In "u32 enabled:1" it means > this is a 1 bit wide bit field. It seems odd that bool is somehow > special and :1 means something else. If you have a bunch of consecutive bool a:1; bool b:1; then GCC will squeeze them into the same byte. But if you have bool a; bool b; then they each take a byte with GCC. I have specified GCC because the size of bool types are a bit vague in the C standard. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel