From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0C58C433FE for ; Fri, 18 Nov 2022 08:48:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fWxwjzVmZQpHYh1CXANGfrZFBwozQK0O2bj3ZwgS59o=; b=sKcYqE/wOGfoIY 5FL3R/RzFXhalpEH4IcV7q1J0p+PZthbs8YKdrMQUnaHhcwGf7m7gw9arAORXYKM9ZqrKFQ6vHXw0 v/yLzHvE/Ey8zGVmOz+ux8KP74uZOvW4N8+unP/f4lFvLBijZgmP6OHKFpP6e0wd0XS+2rj3634cH QR1hfPPyneLvfMqdVsmYLzFX8JJzWyHfEqqQlaXgazS4d+hEGsaMFI0zmdiVni0LZLlD+AiNLMWqK 49vEPDR19RIUQN7YoampBfQU9X+A0Y60OUs8v4MMpKSdJ6HsHJ3IIXZw3+NhJ+6UO4VRcbRi9IEk+ 9cdMdvJ9ybtbnnmU3Niw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovx2E-002rd4-Fv; Fri, 18 Nov 2022 08:47:42 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovx2B-002rbn-8v; Fri, 18 Nov 2022 08:47:40 +0000 Received: by mail-wr1-x42c.google.com with SMTP id g12so8155621wrs.10; Fri, 18 Nov 2022 00:47:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=W8yesRaMT9U9EPQtxhglkNQFwFn6THQr7croFXK/hL0=; b=BQCPMqEU+tav4fAKLNTDSFamkeKMJ7PyFG/eqNkTaVocPgGaeu/o81Az+aFS4rY3vQ FSBHdHxuoVzNV8GkFNUgw/AR27/L+I4vy3cWFcFJOWSAStt4QKCZYPyZXAJPi1CykqiD U59wQtAxRyrvoK5ogzqb6KRiW8Tg9Qn8RocmZa8+qB7rvfsJ1eO8wNjiiPNlJgUcvTt4 F6sI5myF3P0JhBD/CCq51HPwdfp3T4vqc4s9zl0fs6QFjgeeLQWhwXwyyq6eGU5mMlFM 89lg8x7T+j2fx2JVpyoXh2jWLvMQk+eEzX6QhIunNZhiM1i24r+U2KLW+T6/RZL31P7g a74A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=W8yesRaMT9U9EPQtxhglkNQFwFn6THQr7croFXK/hL0=; b=AmgsxHVJoRRQ44w1Ef5XbmwZaUzCSHlx7xI7A48+rpbjWPlq5X1LcrtodNjOxK42yK XerfP1y5Lcd8o+951E/IrFQHiHnY+iRZ/8Y+yayajstFtnia4Er/WoDlgHMer9wQa3y6 tHksr+cWqyiOhGGvzb0YjXtrHQHieRKHWVD+gv5KlDmxnn0CtzgXbjpP86LNHNFP7riK w5PpYn/x/VcPPFvbvWVTWpvoBYQWs2eprKkUPHu4yJNUoM9hdxKe5qvH+5TFOK1/WXSI Ka//NkvIzXjrqOMcAwL1h4dR+il7cMBIrWp49O/wEc68QY54MXT+P0QQTFN6JQCgI16e bi/A== X-Gm-Message-State: ANoB5pkFaOebKYK5tfVXsKJ6lA4VDoNcmhVFbdx2m3UQoEdU0Cl/+hPH JPxjA/aA0FXqJrG0/QpFBXQ= X-Google-Smtp-Source: AA0mqf52m/asu+x56hmdWbfjzZRDrKndKiYuCi/TRdN/w1uQoxQ6QJzkkUQKyRh1mtaHb/YpPt64AA== X-Received: by 2002:a5d:4d09:0:b0:235:e330:71ba with SMTP id z9-20020a5d4d09000000b00235e33071bamr3673651wrt.213.1668761255990; Fri, 18 Nov 2022 00:47:35 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id fn25-20020a05600c689900b003cf78aafdd7sm3687144wmb.39.2022.11.18.00.47.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 00:47:35 -0800 (PST) Date: Fri, 18 Nov 2022 11:47:32 +0300 From: Dan Carpenter To: Stefan Wahren Cc: Dave Stevenson , kieran.bingham@ideasonboard.com, Mauro Carvalho Chehab , Hans Verkuil , linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Umang Jain , Ray Jui , Broadcom internal kernel review list , Florian Fainelli , Greg Kroah-Hartman , linux-staging@lists.linux.dev Subject: Re: [PATCH 0/3] vc04_services: Promote bool usage Message-ID: References: <20221117160015.344528-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221118_004739_331039_44EE89AE X-CRM114-Status: GOOD ( 14.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 17, 2022 at 07:11:41PM +0100, Stefan Wahren wrote: > Hi Dave, > > Am 17.11.22 um 17:00 schrieb Umang Jain: > > In commit 7967656ffbfa ("coding-style: Clarify the expectations around > > bool") the check to dis-allow bool structure members was removed from > > checkpatch.pl. It promotes bool structure members to store boolean > > values. This enhances code readability. > > > > Umang Jain (3): > > Revert "staging: mmal-vchiq: Avoid use of bool in structures" > > vc04_services: mmal-vchiq: Use bool for vchiq_mmal_component.in_use > > vc04_services: bcm2835-camera: Use bool values for > > mmal_fmt.remove_padding > > > > .../bcm2835-camera/bcm2835-camera.c | 30 +++++++++---------- > > .../vc04_services/vchiq-mmal/mmal-vchiq.c | 18 +++++------ > > .../vc04_services/vchiq-mmal/mmal-vchiq.h | 6 ++-- > could you please check these changes to be safe? I'm not sure that the > affected declarations are really internal. I'm afraid this might affect > firmware or userspace. The structs have a bunch of kernel pointers in them so hopefully they are internal. Otherwise we have a different sort of problem. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel