From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41278C433FE for ; Sat, 19 Nov 2022 06:57:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PUylEIh+t6TWLhHbw0QFtzd9sHGI5sJVAxXIvHnzrKw=; b=btT/HOhGiRkhvu fe3RAYjzhnz3tz28/RF3MM+Zlen3vyizKjyHMDeC9JTxJAyARRqwzTr2z10Qm3Ot+Rq+SknV4dBR9 HfNCELHUxxkP5o2oTiSNB/V+q5WYmLJl3fnG+HXB+VVJgMrtIr0q8z1Ka/DY2mNnjcjEATO9bSy3H 4qhlRBoldgb7TCPLMhQz5Qlx4Eao7mFUv4jKgmOjUrQ+Vs2RR+XYOi2VVNIlaC3PvFiArpjSEE56E xroerYTd0ShH+Ul3heFXXkxnBebbgwMki+XhaNNC8GeW53ZAb/R9ovDx+dbyoBjz66HknASVTkW61 AlP+zSNlLROxlet1Pwuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1owHlt-00BzsG-MJ; Sat, 19 Nov 2022 06:56:13 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1owHlq-00BzrZ-J6; Sat, 19 Nov 2022 06:56:11 +0000 Received: from pyrite.rasen.tech (KD106154145051.au-net.ne.jp [106.154.145.51]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A8A0C749; Sat, 19 Nov 2022 07:56:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668840968; bh=sDNUAGAkIzCDcXCi7GBDq63kkMWjkvQ6ooJCMrOl114=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S9OL/S1mgZQoTuD7xGMnC5I2CIxg412BXR+zhxh2kPzfQIOmvNG/oK8heedYw248i L3NKGcvJymVv4OxtsP5pkNWd9iB2z+bdpk+aHfgUqp10lJ2A/D/edtc/R2wquYvdvT GM6lgGCXU/Z3ZeIDJyk8rLUSKri62SeTXkQP08ck= Date: Sat, 19 Nov 2022 15:55:25 +0900 From: Paul Elder To: Krzysztof Kozlowski Cc: linux-media@vger.kernel.org, Laurent Pinchart , Dafna Hirschfeld , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Helen Koike , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 02/14] dt-bindings: media: rkisp1: Add i.MX8MP ISP example Message-ID: References: <20221118093931.1284465-1-paul.elder@ideasonboard.com> <20221118093931.1284465-3-paul.elder@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221118_225610_790643_4FA7A912 X-CRM114-Status: GOOD ( 19.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 18, 2022 at 02:06:14PM +0100, Krzysztof Kozlowski wrote: > On 18/11/2022 10:39, Paul Elder wrote: > > From: Laurent Pinchart > > > > Add an example to the rockchip-isp1 DT binding that showcases usage of > > the parallel input of the ISP, connected to the CSI-2 receiver internal > > to the i.MX8MP. > > > > Signed-off-by: Laurent Pinchart > > Missing SoB. I don't quite understand. I see an SoB right there. > > > --- > > .../bindings/media/rockchip-isp1.yaml | 72 +++++++++++++++++++ > > 1 file changed, 72 insertions(+) > > > > I don't know what do you demonstrate there... usage of endpoints? That's > the only difference. Such usage is the same everywhere, nothing specific I guess...? Doesn't the same argument apply against the px30 example too then? > to this example. You already have two examples, so I don't think this > brings anything more. We do have usage of this in imx8mp.dtsi and overlays for the ISP, but those patches haven't been sent/merged yet, so in the meantime I think there is value in providing an example here for the imx8mp. Thanks, Paul _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel