From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91207C433FE for ; Sat, 19 Nov 2022 04:25:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7QDFzsw6jKwa1oSVoK1Cv/zGXYJT2Tvx4xRuNoJKilA=; b=TK3FMZpOKohOLF M2aK3uLkysZcY0Ka8WGu8eA3tbyiHXhqKWpVkAMYRctz8dRy43Du72kDeuNPrrT7c6efMG+3llGwy kmkfvvQ6cYtlw5sf7588LcbqL0k1uuh8WeLpEBGoqHHNpZmJKfXA9IqoEkCYwE5ejHpm36y9pIdTg Cuah1NgNEVZmckl24X3Idg9BAmtiCjN06rgLhpszYteZE/ps/MlXFfcOHjUl3My1qSi9JJj8691a0 RMDbX/aj5YPvsOZk73l4lt83X0fBunj0KMZAhvR3oJCxep1IIkavc/N/rjSX75kArVMZMWjJx1z0B nIibjDROUOVNFl2JAr6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1owFOj-00B4Jf-65; Sat, 19 Nov 2022 04:24:09 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1owFOe-00B4Eo-7j for linux-arm-kernel@lists.infradead.org; Sat, 19 Nov 2022 04:24:07 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2AJ4Nxgg049070; Fri, 18 Nov 2022 22:23:59 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1668831839; bh=PWHx06q4M3lbufn74MPeUF0tFn9oTY8oqoN3t252zGc=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=foUYIoT4Q8DNIkgeEyaFRA5+1g6SZEp0R9iM7I9Vulo6EzYbFj5PZWDOPHIW/m6w+ a9RoP6WMuXYW62rUjI9AnIqo3M646NzxkZBNzC5me848DXVOWN9UTLw+DHD6sPcUWT Npd4uz1wQ9lE8YdXzRSv+OTu32yOh3LiKDKCW+3Y= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2AJ4Nxde009194 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 18 Nov 2022 22:23:59 -0600 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Fri, 18 Nov 2022 22:23:58 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Fri, 18 Nov 2022 22:23:58 -0600 Received: from ubuntu (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with SMTP id 2AJ4NnQN095304; Fri, 18 Nov 2022 22:23:50 -0600 Date: Fri, 18 Nov 2022 20:23:47 -0800 From: Matt Ranostay To: Krzysztof Kozlowski CC: , , , , , , , , , Subject: Re: [PATCH v4 1/4] Documentation: ti,tps6594: Add DT bindings for the TPS6594x PMIC Message-ID: References: <20221118092218.480147-1-mranostay@ti.com> <20221118092218.480147-2-mranostay@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221118_202404_961013_D57E636B X-CRM114-Status: GOOD ( 27.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 18, 2022 at 11:21:57AM +0100, Krzysztof Kozlowski wrote: > On 18/11/2022 10:22, Matt Ranostay wrote: > > Add documentation for the TPS6594x PMIC including its RTC and GPIO > > functionalities. > > > > This is a friendly reminder during the review process. > > It seems my previous comments were not fully addressed. Maybe my > feedback got lost between the quotes, maybe you just forgot to apply it. > Please go back to the previous discussion and either implement all > requested changes or keep discussing them. > I missed serveral feedback suggestions in the last revision. Will try to be a little more careful in the future. > Thank you. > > The comment was about proper subject prefix. Drop also redundant, second > "DT bindings" from the subject. > > > > Signed-off-by: Matt Ranostay > > --- > > .../devicetree/bindings/mfd/ti,tps6594.yaml | 65 +++++++++++++++++++ > > 1 file changed, 65 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/ti,tps6594.yaml > > > > diff --git a/Documentation/devicetree/bindings/mfd/ti,tps6594.yaml b/Documentation/devicetree/bindings/mfd/ti,tps6594.yaml > > new file mode 100644 > > index 000000000000..81613bcef39d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/ti,tps6594.yaml > > @@ -0,0 +1,65 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/mfd/ti,tps6594x.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: TPS6594x Power Management Integrated Circuit (PMIC) > > + > > +maintainers: > > + - Keerthy > > + > > +properties: > > + compatible: > > + enum: > > + - ti,tps6594 > > tps6594 is the model name? So what was previous tps6594x used also in > title? This does not look correct. > So the actual part number is TPS6594-Q1. Would tps6594q1 be more concise for naming across the device tree, and drivers? - Matt > > + > > + reg: > > + const: 0x48 > > + > > + ti,system-power-controller: > > + type: boolean > > + description: PMIC is controlling the system power. > > + > > + rtc: > > + type: object > > + $ref: /schemas/rtc/rtc.yaml# > > + unevaluatedProperties: false > > + properties: > > + compatible: > > + const: ti,tps6594-rtc > > Same problem. > > > + > > + gpio: > > + type: object > > + unevaluatedProperties: false > > + properties: > > + compatible: > > + const: ti,tps6594x-gpio > > > Not fixed. > > > > > + > > +additionalProperties: false > > + > > +required: > > + - compatible > > + - reg > > + > > +examples: > > + - | > > + i2c0 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + pmic: pmic@48 { > > + compatible = "ti,tps6594"; > > + reg = <0x48>; > > + > > + rtc { > > + compatible = "ti,tps6594-rtc"; > > + }; > > + > > + gpio { > > + compatible = "ti,tps6594-gpio"; > > Does not look like you tested the bindings. Please run `make > dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel