From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53D16C4332F for ; Mon, 21 Nov 2022 15:33:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IVi7dA4p74tpEbK5nCK1haR7OPl2ChHjRtyVh3iY+C8=; b=TQUe+uWjll18kL LyFCgDc+ZugYTlaGuIW2jHUcRYaorgY8UTk5vecgECfRHRh3P9g9cJvbKmjscb3yc9QRE4n3UGVM5 bSlY70MpnxptG1wfx9OcmrBRZabCSs62Z7/jiEH0Q7JLqJ8qXwq4GZFvsOegF15qUs1EcqlKRTR4d PlOUvfUHOjpsnj67MPUtYDl2eZkudVbsYRwA5klqEnWJNHhwFLz5+NdxUWS2koYtwXXomvxnvfBse zQh+tVsuwr7VsLeAoFDN86GlF/PZS8U/yZjMVbMdpN6fUgi+G8gNSB5g2jKG9yLpNzGfdWwUpabxq zEWuVtSY5Qcpj3hbdEag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ox8mH-00FDua-1G; Mon, 21 Nov 2022 15:32:10 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ox8fM-00F9Sf-E6 for linux-arm-kernel@lists.infradead.org; Mon, 21 Nov 2022 15:25:02 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 07B44B810A8; Mon, 21 Nov 2022 15:24:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 248D0C433C1; Mon, 21 Nov 2022 15:24:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1669044297; bh=plmemg8ck/2JJiYk6N9WCm94qIUIDl5laChJjW2g7Cw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZD6NmPJsSKDjUcrRAnF9Oet4XPiBretpsjQgkgD6mqMH3wdi5doXmLHgKS/0N/itH LSsIClTFQx7/80hwc10c8A9IP6RDa1UckhdZKYdBJincU1vvaQMOSfejT9GGgaBnp8 gY1Arvm3qsWYdLaTuHgTDHXiBkj+Q5nc6Z9xY53Y= Date: Mon, 21 Nov 2022 16:24:54 +0100 From: Greg Kroah-Hartman To: Elliot Berman Cc: Bjorn Andersson , Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Prakruthi Deepak Heragu , Arnd Bergmann , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Catalin Marinas , Will Deacon , Jassi Brar , Sudeep Holla , Mark Rutland , Lorenzo Pieralisi , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v7 10/20] gunyah: rsc_mgr: Add resource manager RPC core Message-ID: References: <20221121140009.2353512-1-quic_eberman@quicinc.com> <20221121140009.2353512-11-quic_eberman@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221121140009.2353512-11-quic_eberman@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221121_072500_667760_6EE0EF98 X-CRM114-Status: GOOD ( 11.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 21, 2022 at 05:59:59AM -0800, Elliot Berman wrote: > +struct gh_rm_rpc { > + struct device *dev; > + struct gunyah_resource tx_ghrsc, rx_ghrsc; > + struct gh_msgq msgq; > + struct mbox_client msgq_client; > + struct gh_rm_connection *active_rx_connection; > + int last_tx_ret; > + > + struct idr call_idr; > + struct mutex call_idr_lock; > + > + struct mutex send_lock; > + > + struct work_struct recv_work; > +}; What handles the reference counting for this object? Shouldn't this be a real 'struct device' and just have a pointer to the parent? Otherwise how do you know when to free this? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel