From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB9A0C4332F for ; Mon, 21 Nov 2022 19:20:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fOJTIppgzNtp24tgrow5qyFwOmyj0fHwYD+bb430r2c=; b=zbXLKHs2HQYekR P6SEyMEG/t+BM2f3nMf80m2vOqKOo8i34pu/M1wKvwr1I9IMua3UnuGPTAwtucdbT0HyxqIIgDIk2 3aAnoJEJDdcm5D+PvayliPaTu1LtMt1rw2IN+wAw+ZX3vuX6XwOMzli5I5DhC/w1kDPfhqriiZP5S 9xHYFvqoYe8McxeWOFVHp+yfrwH9khs2G/9HUrEoCwAFeSrScpIyQDv/iOFQjjPBBD3XZBYUJoiaz r5ByMYg4PrOke+DlnQ9t7/VNgBcWxOj/435IuqS5vaKWwf4WrsxfhVQ+a1gpvNrSvdG/tGXsis5KA UT6UXM+HdW+iTkOFb/bg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxCKR-00HDdS-KN; Mon, 21 Nov 2022 19:19:39 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxCKN-00HDcr-Nk for linux-arm-kernel@lists.infradead.org; Mon, 21 Nov 2022 19:19:37 +0000 Received: by mail-wr1-x42b.google.com with SMTP id d1so9210485wrs.12 for ; Mon, 21 Nov 2022 11:19:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xAi8a3PnIsw1PomXHZEK5DhJnyCWSuGYAtIKDL2Vdxg=; b=S1d4PAXe/bvFwIlocpNBPJozaI16f1FDVcrsqavt/2ou6oQToHBj54jr2wiS/bRz8s J0iZEMBfyhp2aBIbWG2drSKdresl2LFBG3WIBtI38bE4pIGTwwWHC5W4sjqoIKujlYGH hcdZVsdPIAXZ8f9gKvPRaSC8yADvpEN4UC/f6NVedUv58qSDkSS54CBCQwHv5fIvhrad eoZeQ/fZTxJBvSjPdYrXpXLHfoI2WcZbw4lMB8N/RNrPAj2MNHNeXukFv57W3bwdVd9l mV3KbgG+p3PECdLs7RG6C9hItipSH0WBbwYtx/225+Uv7Mrvp60sswV3HcKYzmFqAk4A YiXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xAi8a3PnIsw1PomXHZEK5DhJnyCWSuGYAtIKDL2Vdxg=; b=ZBLqBxp2i+vLKfVu7srA7//LlT4OfutycQG1ISWaUGeGkkfXtSE2trjyW7BWlw/5zp FnTW5tE22ClJbaDn5FoyLo1RWHPdpi63YHBliBfW69MLlqZ3U5rVRwq3u7Ld8QVPJt3h 43x4ZoUhr3LNpzhHXYXsC1/JE5mxPtrJaWY7TXE3WPHDsVIqOGxhDwUUaURC4OPnhXNC Wies5dsDnnQ7R5yQ6PYfvNBE5RSBZV5uI+1Y076OVa1+V6Wji9ga+Nd58VYDFYAqLP2H 3Gp8N40wwJgq7SqZHH+8Gqyzmp47+jvNYzigD3Lqb5SkAIzv2lfYJcv2viuQi8/iFKhu xbGQ== X-Gm-Message-State: ANoB5pmMU+jri9TdLxFnHPMWfhA2I8SNa5WPTqaGYxIvr/mqbvhWKCjI RiN1BJPt358HbQ1cQFiDTue+uxJNpJp5NA== X-Google-Smtp-Source: AA0mqf5p5mVVBPcNPVfslo0MoCa5w1wzbaHVw1TsDG4VhvmXy1UpOVDOMuRzZzAHIUMnIJCBorH+sQ== X-Received: by 2002:a05:6000:1d97:b0:241:b99a:949f with SMTP id bk23-20020a0560001d9700b00241b99a949fmr11857563wrb.599.1669058373899; Mon, 21 Nov 2022 11:19:33 -0800 (PST) Received: from linaro.org ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id m7-20020a05600c4f4700b003b4fe03c881sm21052903wmq.48.2022.11.21.11.19.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 11:19:33 -0800 (PST) Date: Mon, 21 Nov 2022 21:19:31 +0200 From: Abel Vesa To: Dario Binacchi Cc: linux-kernel@vger.kernel.org, michael@amarulasolutions.com, Amarula patchwork , Abel Vesa , Fabio Estevam , Michael Turquette , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH] clk: imx: DRY cleanup of imx_obtain_fixed_clock_hw() Message-ID: References: <20221113180945.1626061-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221113180945.1626061-1-dario.binacchi@amarulasolutions.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221121_111935_800239_A06450C7 X-CRM114-Status: GOOD ( 17.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22-11-13 19:09:44, Dario Binacchi wrote: > The imx_obtain_fixed_clock() and imx_obtain_fixed_clock_hw() functions > behave pretty similarly, DRY and call one from another. > > No functional changes intended. > > Signed-off-by: Dario Binacchi > > --- > > drivers/clk/imx/clk.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/clk/imx/clk.c b/drivers/clk/imx/clk.c > index 5582f18dd632..573b1a6ca1dc 100644 > --- a/drivers/clk/imx/clk.c > +++ b/drivers/clk/imx/clk.c > @@ -104,9 +104,7 @@ struct clk_hw *imx_obtain_fixed_clock_hw( > { > struct clk *clk; > > - clk = imx_obtain_fixed_clock_from_dt(name); > - if (IS_ERR(clk)) > - clk = imx_clk_fixed(name, rate); > + clk = imx_obtain_fixed_clock(name, rate); NACK here. You're switching to a non "clk_hw" based variant that should/would be removed in the near future. In the future, we want the clock providers to not used "clk" based APIs. Rule is, AFAIR, to use "clk" based APIs in clock consumer drivers only, while using "clk_hw" based APIs in clock provider drivers only. Right now, only the imx5 and vf610 clock provider drivers still use the 'clk' based API. Once those are switched to 'clk_hw' based, all the 'clk' i.MX specific APIs will be removed for good. > return __clk_get_hw(clk); > } > > -- > 2.32.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel