From: Abel Vesa <abel.vesa@linaro.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: linux-kernel@vger.kernel.org, linux-amarula@amarulasolutions.com,
michael@amarulasolutions.com, Abel Vesa <abelvesa@kernel.org>,
Anson Huang <Anson.Huang@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 4/5] clk: imx8mn: fix imx8mn_sai2_sels clocks list
Date: Mon, 21 Nov 2022 22:19:07 +0200 [thread overview]
Message-ID: <Y3vdO6Kh47dH+C/u@linaro.org> (raw)
In-Reply-To: <20221117113637.1978703-5-dario.binacchi@amarulasolutions.com>
On 22-11-17 12:36:36, Dario Binacchi wrote:
> According to the "Clock Root" table of the reference manual (document
> IMX8MNRM Rev 2, 07/2022):
>
> Clock Root offset Source Select (CCM_TARGET_ROOTn[MUX])
> ... ... ...
> SAI2_CLK_ROOT 0xA600 000 - 24M_REF_CLK
> 001 - AUDIO_PLL1_CLK
> 010 - AUDIO_PLL2_CLK
> 011 - VIDEO_PLL_CLK
> 100 - SYSTEM_PLL1_DIV6
> 110 - EXT_CLK_2
> 111 - EXT_CLK_3
> ... ... ...
>
> while the imx8mn_sai2_sels list contained clk_ext3 and clk_ext4 for
> source select bits 110b and 111b.
>
> Fixes: 96d6392b54dbb ("clk: imx: Add support for i.MX8MN clock driver")
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>
> (no changes since v1)
>
> drivers/clk/imx/clk-imx8mn.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> index b80af5d1ef46..37128c35198d 100644
> --- a/drivers/clk/imx/clk-imx8mn.c
> +++ b/drivers/clk/imx/clk-imx8mn.c
> @@ -109,7 +109,7 @@ static const char * const imx8mn_disp_pixel_sels[] = {"osc_24m", "video_pll_out"
>
> static const char * const imx8mn_sai2_sels[] = {"osc_24m", "audio_pll1_out", "audio_pll2_out",
> "video_pll_out", "sys_pll1_133m", "dummy",
> - "clk_ext3", "clk_ext4", };
> + "clk_ext2", "clk_ext3", };
>
> static const char * const imx8mn_sai3_sels[] = {"osc_24m", "audio_pll1_out", "audio_pll2_out",
> "video_pll_out", "sys_pll1_133m", "dummy",
> --
> 2.32.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-21 20:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 11:36 [PATCH v2 0/5] clk: imx8mn: miscellaneous cleanups and bug fixes Dario Binacchi
2022-11-17 11:36 ` [PATCH v2 1/5] clk: imx8mn: rename vpu_pll to m7_alt_pll Dario Binacchi
2022-11-21 20:09 ` Abel Vesa
2022-11-17 11:36 ` [PATCH v2 2/5] clk: imx: replace osc_hdmi with dummy Dario Binacchi
2022-11-21 20:13 ` Abel Vesa
2022-11-22 2:48 ` Peng Fan
2022-11-17 11:36 ` [PATCH v2 3/5] clk: imx: rename video_pll1 to video_pll Dario Binacchi
2022-11-21 20:18 ` Abel Vesa
2022-11-17 11:36 ` [PATCH v2 4/5] clk: imx8mn: fix imx8mn_sai2_sels clocks list Dario Binacchi
2022-11-21 20:19 ` Abel Vesa [this message]
2022-11-17 11:36 ` [PATCH v2 5/5] clk: imx8mn: fix imx8mn_enet_phy_sels " Dario Binacchi
2022-11-21 20:25 ` Abel Vesa
2022-11-17 11:42 ` [PATCH v2 0/5] clk: imx8mn: miscellaneous cleanups and bug fixes Marco Felsch
2022-11-18 7:48 ` Dario Binacchi
2022-11-25 9:20 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3vdO6Kh47dH+C/u@linaro.org \
--to=abel.vesa@linaro.org \
--cc=Anson.Huang@nxp.com \
--cc=abelvesa@kernel.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@amarulasolutions.com \
--cc=mturquette@baylibre.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).