From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0D6DC47089 for ; Mon, 5 Dec 2022 10:54:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=docRhhglGUQ9Le32QLDKYTqSJFm9GvRovPhl6HxZl+U=; b=PR97lbBQWqWehZ QQiTiwOQ3JWReyH3ibgZ7p0t/S27N9wSgawwBctN8lPcedvfbITgQSWEygOGr/f9uuU7FNX2VL6kE bM8wPSRhiq24WMMG8Fak3KgjM13Ap3W6DKobpJU+8E2FNSrWJXz+ZEONg2IoKDtIsd3ysEZyp6pbP SeWp1Mlj+4j5DKEtqzOztebBBf7t41LJysFUTAbphstgZmfBnHa+KC9ov3LrXdYm11FDizgauq3Gt 0UMjFTS3A/PyJnMw2A9HSZxgs2nrp7lz2Lsdvu8/Lzj3mEZEdqYhNfltG4vDJ8Oz00dxjGWTJZBRX m5sEFv0uFovpTgZXN5Gw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p296A-001GnG-38; Mon, 05 Dec 2022 10:53:22 +0000 Received: from mail.8bytes.org ([2a01:238:42d9:3f00:e505:6202:4f0c:f051]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2967-001Glm-7c for linux-arm-kernel@lists.infradead.org; Mon, 05 Dec 2022 10:53:20 +0000 Received: from 8bytes.org (p200300c27724780086ad4f9d2505dd0d.dip0.t-ipconnect.de [IPv6:2003:c2:7724:7800:86ad:4f9d:2505:dd0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.8bytes.org (Postfix) with ESMTPSA id E2AC52202AB; Mon, 5 Dec 2022 11:53:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=8bytes.org; s=default; t=1670237598; bh=6FHDaNEUvC+Otfa6SO4ujCIHCtJA8iZiWNcWrFniOc4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ePZmoXfI68UsYR+OLH7xxXKuTmuGm0CRbPQKXxhpC5MDtgrj++kkXGm7E42G/vGKd OOwUZ1dymkzxf7O6CX7MQSJ12iuy6ENMQ6KWJywvZOaHTyZqNe8q0uuOY+I5VDak02 7ipP2sKGnvVSOxi40K5vP+CukP/wuwXQ3cvP+glETZ7oJzCx8cNd7MGXVHeKqvT1m2 2NtnfKqj9a5d5QBvNfps+TskFAqxMi6Gor8BmtqXnGc8CksImogPdsl97Enwl9p+D2 TQPs609ogM79efiuaBxwsp5ZcCrA/7AQAmCKe0NtNrpo12P/G+tRKlXoyoI//HHA2b Y4ReGn3ZiU05A== Date: Mon, 5 Dec 2022 11:53:16 +0100 From: Joerg Roedel To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Maxime Ripard , Jernej Skrabec , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Robin Murphy , Samuel Holland , Chen-Yu Tsai , Will Deacon , Joerg Roedel Subject: Re: [PATCH] iommu/sun50i: Remove IOMMU_DOMAIN_IDENTITY Message-ID: References: <0-v1-97f0adf27b5e+1f0-s50_identity_jgg@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0-v1-97f0adf27b5e+1f0-s50_identity_jgg@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221205_025319_528910_CC29FBCE X-CRM114-Status: GOOD ( 11.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 28, 2022 at 10:06:28AM -0400, Jason Gunthorpe wrote: > This driver treats IOMMU_DOMAIN_IDENTITY the same as UNMANAGED, which > cannot possibly be correct. > > UNMANAGED domains are required to start out blocking all DMAs. This seems > to be what this driver does as it allocates a first level 'dt' for the IO > page table that is 0 filled. > > Thus UNMANAGED looks like a working IO page table, and so IDENTITY must be > a mistake. Remove it. > > Fixes: 4100b8c229b3 ("iommu: Add Allwinner H6 IOMMU driver") > Signed-off-by: Jason Gunthorpe Applied, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel