From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D27BC4332F for ; Mon, 28 Nov 2022 18:31:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C1tdT/ASJEVqapOKEQ/4e7S3ysFMAoTwhTI6b7+QM80=; b=jysMTY6gGDP3hy sx4xLL7bOzd17gBpht/kPqbvkMXBZg+v73FCS6+Xhitu7sBcoIMnWfg32lsTCHz1/8UIfURZQ6zts BXEmh2rTVcX5kkxVFniRlnCHNAVRiebkag3KwgwJlDKuP6sxNmTHNeX0uSKKi22sXVVCH/TQcpy7b kKhUrcAvpYFY2nt+spcLg0vYFogw9kC7g5OBx+yrOZ/49KISvu7u7tCqrlXPgZ+ajF4svcdOn3HrV atg4JaKRD/MFlapkUXsEZLBH8yVE81e70O6CC2tdqlKhRl6Wi9agYvNLvcT3iWTTH+J7owhoiugcf t/zaGcZmt7Eib9ittQEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozite-003bxV-Hh; Mon, 28 Nov 2022 18:30:26 +0000 Received: from mail-il1-f180.google.com ([209.85.166.180]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oziS6-003LhV-9M for linux-arm-kernel@lists.infradead.org; Mon, 28 Nov 2022 18:01:59 +0000 Received: by mail-il1-f180.google.com with SMTP id q13so5411456ild.3 for ; Mon, 28 Nov 2022 10:01:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xmy4KXaQFNlqj17WY1ADV6bqsA77u7z6qE1PaxwlJXo=; b=TqI4yeNGLVJjUr0ZFxkqYpf3XsamRX0BF9yElZSm2BNJSKRaztCef5WMtLyHSual0D Up1uRiOu/t7tBwUwY9EN+NOUYDpnU91e5vPBvrxHTjLwBxtwg1Aob49iLmxDWMxwQHkw 2hUbg0ZLB3C/uX9FkhbDsNjI7R4YYFISplxgszJTDzM9cnd4mJQulOf/mIemOnlFdNBc 46y7Ec6HbrIxTOboWUyNvJARa57/0AjcRjEC6+W8roKWHz+liL/8j/LODfN0DEdneeVk FOrOn4CNB9jS3Wk7uSDQH4A7pDOXNLAdrAZ5qmAj+AeD41FFPlGnRCzBcNW8B05Vomrz vYfQ== X-Gm-Message-State: ANoB5pnwcOoDKw2ctooKz1lj/uKu7yYaUzWjQYfleNxNJ58I6tWx8Gze A4KRRnML9APr49aLtW6qCFJhVQ== X-Google-Smtp-Source: AA0mqf70pG2zhhWmQ9tBm9b/zMsiZnG4JD+s+a0G/ChoykXinRgJm8GCPsBwkj7EV/Ro3wduiUVaCA== X-Received: by 2002:a05:6e02:c65:b0:302:f4f5:8691 with SMTP id f5-20020a056e020c6500b00302f4f58691mr9364754ilj.206.1669658513537; Mon, 28 Nov 2022 10:01:53 -0800 (PST) Received: from google.com (30.23.70.34.bc.googleusercontent.com. [34.70.23.30]) by smtp.gmail.com with ESMTPSA id o3-20020a02a1c3000000b0037477c3d04asm4326772jah.130.2022.11.28.10.01.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 10:01:52 -0800 (PST) Date: Mon, 28 Nov 2022 18:01:50 +0000 From: Matthias Kaehlcke To: Icenowy Zheng Cc: Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Greg Kroah-Hartman , Andre Przywara , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 3/6] usb: misc: onboard_usb_hub: add Genesys Logic GL850G hub support Message-ID: References: <20221127073140.2093897-1-uwu@icenowy.me> <20221127073140.2093897-4-uwu@icenowy.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221127073140.2093897-4-uwu@icenowy.me> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221128_100158_368968_B6709A2B X-CRM114-Status: GOOD ( 22.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Nov 27, 2022 at 03:31:37PM +0800, Icenowy Zheng wrote: > This is a 4-port USB 2.0 STT hub. The commit message is supposed the describe the change, which is almost certainly not a 4-port USB 2.0 STT hub :) It could be something like "Add support for the Genesys Logic GL850G, which is a 4-port USB 2.0 STT hub." > > Signed-off-by: Icenowy Zheng > --- > drivers/usb/misc/onboard_usb_hub.c | 2 ++ > drivers/usb/misc/onboard_usb_hub.h | 5 +++++ > 2 files changed, 7 insertions(+) > > diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c > index d63c63942af1..f5c71d724be6 100644 > --- a/drivers/usb/misc/onboard_usb_hub.c > +++ b/drivers/usb/misc/onboard_usb_hub.c > @@ -334,6 +334,7 @@ static struct platform_driver onboard_hub_driver = { > #define VENDOR_ID_MICROCHIP 0x0424 > #define VENDOR_ID_REALTEK 0x0bda > #define VENDOR_ID_TI 0x0451 > +#define VENDOR_ID_GENESYS 0x05e3 Please insert the new entry in alphabetical order, i.e. before VENDOR_ID_MICROCHIP. > > /* > * Returns the onboard_hub platform device that is associated with the USB > @@ -414,6 +415,7 @@ static const struct usb_device_id onboard_hub_id_table[] = { > { USB_DEVICE(VENDOR_ID_REALTEK, 0x5414) }, /* RTS5414 USB 2.1 */ > { USB_DEVICE(VENDOR_ID_TI, 0x8140) }, /* TI USB8041 3.0 */ > { USB_DEVICE(VENDOR_ID_TI, 0x8142) }, /* TI USB8041 2.0 */ > + { USB_DEVICE(VENDOR_ID_GENESYS, 0x0608) }, /* Genesys Logic GL850G USB 2.0 */ Same here, the table is ordered alphabetically > {} > }; > MODULE_DEVICE_TABLE(usb, onboard_hub_id_table); > diff --git a/drivers/usb/misc/onboard_usb_hub.h b/drivers/usb/misc/onboard_usb_hub.h > index 34beab8bce3d..1ca188713b1f 100644 > --- a/drivers/usb/misc/onboard_usb_hub.h > +++ b/drivers/usb/misc/onboard_usb_hub.h > @@ -22,6 +22,10 @@ static const struct onboard_hub_pdata ti_tusb8041_data = { > .reset_us = 3000, > }; > > +static const struct onboard_hub_pdata genesys_gl850g_data = { > + .reset_us = 3, > +}; > + > static const struct of_device_id onboard_hub_match[] = { > { .compatible = "usb424,2514", .data = µchip_usb424_data, }, > { .compatible = "usb451,8140", .data = &ti_tusb8041_data, }, > @@ -30,6 +34,7 @@ static const struct of_device_id onboard_hub_match[] = { > { .compatible = "usbbda,5411", .data = &realtek_rts5411_data, }, > { .compatible = "usbbda,414", .data = &realtek_rts5411_data, }, > { .compatible = "usbbda,5414", .data = &realtek_rts5411_data, }, > + { .compatible = "usb5e3,608", .data = &genesys_gl850g_data, }, These table is ordered by compatible string, the new entry should be inserted after "usb451,8142". Thanks m. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel