From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2DBEC43217 for ; Thu, 1 Dec 2022 08:27:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Va8D9xDcH/q6+8LYb26Ol50jcfh9QFq9wbQpvVceiDM=; b=t0BpaVWdgVSILP v2ZmXbkgmrjLaTMPSBQ/NVEUOY295gxzqayBfFixiztaxbmM/bIVNTETgv2Fs55EhkngHN/Hzj5h3 W/a/dlrZ+gLTbyubi5jYbD5f4ns52/Qc1OX7wq43u/IP3AOqkHDNqvBBAti0H+1YFSHhiDmn5gWnj oyol8kOEwILE4aQm9l69Lq1qvmU6k0cyQtzwwNBEXyv6K76yR5Mo3DBuiOR12Uy4IdD94vKXbv8FP 5o2x9yoL7nzDEKThMitFBgMGlhtGLfXp5lizE0OrsjE5PRz9kfnhxQaHQqIVgG2+F5cniRCd7P5JO qmkCt8rN6gGWKD0fR6XQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0euH-005pzQ-Sp; Thu, 01 Dec 2022 08:26:57 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0euE-005pvv-1q for linux-arm-kernel@lists.infradead.org; Thu, 01 Dec 2022 08:26:55 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8C82861ECE; Thu, 1 Dec 2022 08:26:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7AF10C433C1; Thu, 1 Dec 2022 08:26:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1669883213; bh=9b2/8eE9yzlYofYNhF+OGMGr1M4s1PGOfebwoAlphxU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yqk59b/SkAVAtAcqGgpSCFRdSfpJMkFYN+ZHNKX3FGmCSFe1KGxvOwnUlJYYENx+N 16G8Tc28Xv5BntgYYsWaDD0UvxWF3yVG8OSOMW3hh1Sc64DyEHWGm8u41YCM3Aora+ kf/CxTpj7H74WEKYIPKU7RTSPe+5FJ5va3wcLU8k= Date: Thu, 1 Dec 2022 09:06:55 +0100 From: Greg Kroah-Hartman To: Daehwan Jung Cc: Rob Herring , Krzysztof Kozlowski , Alim Akhtar , Mathias Nyman , Arnd Bergmann , Linus Walleij , Colin Ian King , Artur Bujdoso , Juergen Gross , Tomer Maimon , "open list:USB SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "open list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , open list , sc.suh@samsung.com, taehyun.cho@samsung.com, jh0801.jung@samsung.com, eomji.oh@samsung.com Subject: Re: [RFC PATCH v1 2/2] usb: host: add xhci-exynos to support Exynos SOCs Message-ID: References: <1669860811-171746-1-git-send-email-dh10.jung@samsung.com> <1669860811-171746-3-git-send-email-dh10.jung@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1669860811-171746-3-git-send-email-dh10.jung@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221201_002654_207844_8497BF50 X-CRM114-Status: GOOD ( 13.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 01, 2022 at 11:13:31AM +0900, Daehwan Jung wrote: > This driver works with xhci platform driver. It needs to override > functions of xhci_plat_hc_driver. Wakelocks are used for sleep/wakeup > scenario of system. So this means that no other platform xhci driver can be supported in the same system at the same time. Which kind of makes sense as that's not anything a normal system would have, BUT it feels very odd. This whole idea of "override the platform driver" feels fragile, why not make these just real platform drivers and have the xhci platform code be a library that the other ones can use? That way you have more control overall, right? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel