From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15300C43217 for ; Thu, 1 Dec 2022 14:57:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sqIKidkLibiLg3JrlQTdla06lqPMkf9H4/c29LU7g+w=; b=i458mulqVY+/ys I3LCOn8V1C1Xbsg9TtDblwnLfzkbQs9gtS0JFlKq6czns8Zkc0/6rvGeQfiLlst6VGRXvFYiRWcGq WjMcDy/q358EVfgERH7CGF5i7uU+MmDQBX8FBG6e2YpXBbP95KcBu2N1k2Hs4WVN33rJ1+6JhaYIY eaZvGpH73ILP/cBe5wZYYF6XUX2CeVmfBEz+EhafQUvBILwMX2Wnr6TdB1U6fu4YQGmXuiMPhNDJD NXJwor80KVNlcOXEGUyxo8GRLlg8G6+Y+SM15GiuQpac+RDr40aYuoYKU2XWp0ALVnFS6wj7ByYzE c/9oguhKbpNJQMZks9pw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0kzm-0084hQ-Jd; Thu, 01 Dec 2022 14:57:02 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0kzj-0084gG-3e for linux-arm-kernel@lists.infradead.org; Thu, 01 Dec 2022 14:57:00 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2C43CD6E; Thu, 1 Dec 2022 06:57:01 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.38.177]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D75C93F67D; Thu, 1 Dec 2022 06:56:52 -0800 (PST) Date: Thu, 1 Dec 2022 14:56:49 +0000 From: Mark Rutland To: "Masami Hiramatsu (Google)" Cc: Catalin Marinas , Will Deacon , Mark Brown , Kalesh Singh , Marc Zyngier , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sandeepa Prabhu Subject: Re: [PATCH 2/3] arm64: kprobes: Let arch do_page_fault() fix up page fault in user handler Message-ID: References: <166990553243.253128.13594802750635478633.stgit@devnote3> <166990555186.253128.6694458405311467597.stgit@devnote3> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <166990555186.253128.6694458405311467597.stgit@devnote3> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221201_065659_220850_48A00439 X-CRM114-Status: GOOD ( 15.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 01, 2022 at 11:39:11PM +0900, Masami Hiramatsu (Google) wrote: > From: Masami Hiramatsu (Google) > > Since arm64's do_page_fault() can handle the page fault correctly > than kprobe_fault_handler() according to the context, let it handle > the page fault instead of simply call fixup_exception() in the > kprobe_fault_handler(). > > Signed-off-by: Masami Hiramatsu (Google) Acked-by: Mark Rutland Mark. > --- > arch/arm64/kernel/probes/kprobes.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/arch/arm64/kernel/probes/kprobes.c b/arch/arm64/kernel/probes/kprobes.c > index c9e4d0720285..d2ae37f89774 100644 > --- a/arch/arm64/kernel/probes/kprobes.c > +++ b/arch/arm64/kernel/probes/kprobes.c > @@ -294,14 +294,6 @@ int __kprobes kprobe_fault_handler(struct pt_regs *regs, unsigned int fsr) > } > > break; > - case KPROBE_HIT_ACTIVE: > - case KPROBE_HIT_SSDONE: > - /* > - * In case the user-specified fault handler returned > - * zero, try to fix up. > - */ > - if (fixup_exception(regs)) > - return 1; > } > return 0; > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel