From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1605CC43217 for ; Thu, 1 Dec 2022 17:56:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q14oorqbRerlINkDMUqYw3BJ6EBqZvOEJb6zbldhL3Y=; b=C6Rdmviqdn8LyP z28p+tOlw9aP73NnU/s7k3syo8p+acF4V/tpWqhsK+/3AsTJCGighZtczUfakAkPtucbnBQodtV58 SN21qbxu4Vo3Vo8ToqeF6I+vuIS4kgzBqoeTaKgtD+8b5DkF9KYUIenwLcEUx9dXqKXvB683LxDHJ /uves06ufAvCJ0yDspBJXU3EYMi0w2LByrQSitE4ldLXTE6iLDXUI/nF5U9H54h063XAKbKELxHG9 jdCZc4D6c369kNJqzHnFr9DM+SUQ7CN5FTh7tnv7gO8LekgCmGgF+Ra0SRyGL3q30KL62DqfBWwI5 7668Vu4o2yivTz4MOv3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0nmh-009KZx-5T; Thu, 01 Dec 2022 17:55:43 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0nd9-009AIK-Ex for linux-arm-kernel@lists.infradead.org; Thu, 01 Dec 2022 17:45:53 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5E6FAB81FC7; Thu, 1 Dec 2022 17:45:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38626C433D6; Thu, 1 Dec 2022 17:45:46 +0000 (UTC) Date: Thu, 1 Dec 2022 17:45:43 +0000 From: Catalin Marinas To: Thorsten Leemhuis Cc: Sibi Sankar , Manivannan Sadhasivam , Will Deacon , Robin Murphy , amit.pundir@linaro.org, andersson@kernel.org, sumit.semwal@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "arm64: dma: Drop cache invalidation from arch_dma_prep_coherent()" Message-ID: References: <20221114110329.68413-1-manivannan.sadhasivam@linaro.org> <20221114141109.GG30263@willie-the-truck> <1659929b-1372-cea6-5840-c58369a4252d@arm.com> <20221118105402.GA184726@thinkpad> <20221118123349.GC3697@willie-the-truck> <20221121064224.GB11945@thinkpad> <018517b8-0ae0-54f5-f342-dcf1b3330a13@quicinc.com> <6d637906-e1d5-c481-a73d-2b2b845e223b@leemhuis.info> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6d637906-e1d5-c481-a73d-2b2b845e223b@leemhuis.info> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221201_094551_670811_5FD57A7D X-CRM114-Status: GOOD ( 14.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 01, 2022 at 10:29:39AM +0100, Thorsten Leemhuis wrote: > Has any progress been made to fix this regression? It afaics is not a > release critical issue, but well, it still would be nice to get this > fixed before 6.1 is released. The only (nearly) risk-free "fix" for 6.1 would be to revert the commit that exposed the driver bug. It doesn't fix the actual bug, it only makes it less likely to happen. I like the original commit removing the cache invalidation as it shows drivers not behaving properly but, as a workaround, we could add a command line option to force back the old behaviour (defaulting to the new one) until the driver is fixed. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel