From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F978C4321E for ; Fri, 2 Dec 2022 16:23:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wHEkMXxL+9PvccMyJR+zcBHP+pLUKLvOwB019+sB7/I=; b=teoTYLSz5sdVYO W3Yh/e4rMiF1edo6UAk/ZugsYX7ttoHCjAZx6KBI3pvE4tNOzTMA9bGLLxV90TEcHviv6KMoiDgj9 b4oi6JSXklwGEGj7VxU0sVvkSW9dfR/HhJZObk0dWjwZR1KZoPW53RjxlGCRLunKhX4xB1wtlDKvk WfND6grxPoxAP2lfWTwaXi/uX9Csl4EbrCgMEaPRf7ubnOHEPqomm3oKSA7FEukIvAu1io9Y1up7v NKqSTp6y0YjxfpUxA+0nnFmvrJWmdJSpk+cLeGz2xvGwELGMh3fwlaMumwLxCTZLMnWJJIX8JnaqH Dl6Qs4vWn4EJx0MZPPng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p18o8-00HTSv-By; Fri, 02 Dec 2022 16:22:36 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p18o4-00HTR5-QW for linux-arm-kernel@lists.infradead.org; Fri, 02 Dec 2022 16:22:34 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4FE40B82149; Fri, 2 Dec 2022 16:22:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5FDAC433C1; Fri, 2 Dec 2022 16:22:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669998150; bh=CPvo4jI/m4oROZkBB+oScqPDYhzMXCF1weYnGfXoYeY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rwhWjVFISQerud3CTPlubHgVr8SIKexweyIxDdHiSkTMPYfhj/ZvkEv3ms2h6A9eg /YZfxp1ySRuQNBQQOQs6KTUQ9lFbnbsQtlkMzo4+yF7yRrpMNdHnteY/oYXy6a8tT2 2V4IYgUbyV8XXC7APFFhFmVWIQi3wAaX+QWlAtTwd0TVa8FkMBGGRqOD3wO5TDQij1 sBhwjrEbcZAsKFoChwxHXOQ91ipXZlsqrIfwHnSkLZSk9wkKRH7rCqT5+RUYkMRSxF Htrcc1lFG0Kn3iXIuBPsgXR2ghvlnBjry7s5UlOUQrFVV5qHhkOukdbAERbAquxP0k 2nrESvlXLi+PA== Date: Sat, 3 Dec 2022 00:12:35 +0800 From: Jisheng Zhang To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, joey.gouly@arm.com, will@kernel.org Subject: Re: [PATCH] arm64: alternatives: make apply_alternatives_vdso() static Message-ID: References: <20221117131650.4056636-1-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221117131650.4056636-1-mark.rutland@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221202_082233_034500_F9F278F5 X-CRM114-Status: GOOD ( 20.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 17, 2022 at 01:16:50PM +0000, Mark Rutland wrote: > We define and use apply_alternatives_vdso() within alternative.c, and > don't provide a prototype in a header. There's no need for it to be > visible outside of alternative.c, so mark it as static. > > There should be no functional change as a result of this patch. > > Signed-off-by: Mark Rutland > Cc: Catalin Marinas > Cc: Joey Gouly > Cc: Will Deacon > --- > arch/arm64/kernel/alternative.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/alternative.c b/arch/arm64/kernel/alternative.c > index 91263d09ea65..0f5eaa4c3a39 100644 > --- a/arch/arm64/kernel/alternative.c > +++ b/arch/arm64/kernel/alternative.c > @@ -196,7 +196,7 @@ static void __apply_alternatives(const struct alt_region *region, > } > } > > -void apply_alternatives_vdso(void) > +static void apply_alternatives_vdso(void) I found this function can be marked as __init as well. Thanks > { > struct alt_region region; > const struct elf64_hdr *hdr; > -- > 2.30.2 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel