From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B10C4C4332F for ; Sun, 18 Dec 2022 15:01:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ntqF/uLksCC2hR7aAh1RFnKb/McTucUH+9UXHzRrfhQ=; b=nAtweTRgiBbPoT Nd+ZSgFswnG0QdMhhTZNqbe44M3adG9KaV/3PxNAdxusXlqhOeI1uxsZ5/fSQjZNGU0HSs6RyBHWO AxD7KrYGjbuf2iO4tsJ0ocZmebjzHGLFJV1S7DIFpLUZaAHqD5IeIarRaCOGKAXTnEfzrc4bfh/VC hlvpiA8grYH247IO4d6wTxFSOudAecD+QuzbPqUk4E+Q9pE3yC++hx7wCKqB66npk1m6JGtF6W21Q a4xrddpOAThPySROoD0moO7Vw3lBMieI6GqODfkhHjkl5gFd9lgfyDlqA554sy70FyMc3QSgM/Sqy msWM1IVqEimT8jmc6SkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p6v9b-002RrF-ML; Sun, 18 Dec 2022 15:00:39 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p6v9Y-002Rq5-Gt for linux-arm-kernel@lists.infradead.org; Sun, 18 Dec 2022 15:00:37 +0000 Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B3A0A825; Sun, 18 Dec 2022 16:00:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1671375634; bh=kKRrKB/nJyp0eDTeiuSFhpxZVfNJx1NwPZwHj85dT18=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AllE6tS/wunTMQ4N29E0QV/VcJcZqGZy1A2ZGb+XOLYaSdYbXNuxqIhBNuOqeVnDo 3Y/rVf1JbQKJKIHmws4Z39JMkD/B6GcNK0XsvSfRfePQIZBi0O9bFTzycrUyjl7vHd gU9B0xCZ43Wyyuov0i5arXqq3wU9Om/Kiiq2dL5g= Date: Sun, 18 Dec 2022 17:00:30 +0200 From: Laurent Pinchart To: Adam Ford Cc: linux-arm-kernel@lists.infradead.org, aford@beaconembedded.com, Rob Herring , Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Lucas Stach , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] arm64: dts: imx8mp: Fix missing GPC Interrupt Message-ID: References: <20221217180849.775718-1-aford173@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221217180849.775718-1-aford173@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221218_070036_730068_85493431 X-CRM114-Status: GOOD ( 15.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Adam, Thank you for the patch. On Sat, Dec 17, 2022 at 12:08:48PM -0600, Adam Ford wrote: > The GPC node references an interrupt parent, but it doesn't > state the interrupt itself. According to the TRM, this IRQ > is 87. This also eliminate an error detected from dt_binding_check The interrupt isn't used by the driver as far as I can see, so I can't test this, but the patch matches the reference manual, so Reviewed-by: Laurent Pinchart > Fixes: fc0f05124621 ("arm64: dts: imx8mp: add GPC node with GPU power domains") > Signed-off-by: Adam Ford > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 7a6e6221f421..7a8ca56e48b6 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -524,6 +524,7 @@ gpc: gpc@303a0000 { > compatible = "fsl,imx8mp-gpc"; > reg = <0x303a0000 0x1000>; > interrupt-parent = <&gic>; > + interrupts = ; > interrupt-controller; > #interrupt-cells = <3>; > -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel