From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 569ECC4332F for ; Sun, 18 Dec 2022 15:12:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4R6PVaKxm/nMfGGAgo7/SxXTBfE9VEa5UYQ2NRZaJlg=; b=eWo9FrvrDDaXu6 vl+FtevZhBXQie86/pV2lhY1feV2tdOgdH1boqG2V1vFIyeyE3gC8FuXSC5qUh8PbE3rQ6mPieJqr ru1hzeyqbq2Xe5Nm3UepLI7jXvfNbugdpQyoFHjeYw3FEgkF3rnCYxceiWa89cII1ytPX9OvYT9EZ xfITga+g/WrxwRfea7yqbzAR6gLl8bsLyUiZ9Z0N2P7GF41MHjstS0kUWdHe3fhrcMTuhIE7h8FSy Ac+k+x1fkuunfQoHf57Opnf0/wWSPkSjLD6KQoPzXeOq4lpZ2caNExXf/yL08wwW22sli2mmYS2ha 5b3OG9brTnFCuCYkTUAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p6vK4-002YCf-Gk; Sun, 18 Dec 2022 15:11:28 +0000 Received: from mailrelay5-1.pub.mailoutpod2-cph3.one.com ([2a02:2350:5:404::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p6vJz-002Y8G-7n for linux-arm-kernel@lists.infradead.org; Sun, 18 Dec 2022 15:11:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa2; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=HeoWzm4aDtjnCxaocC8ieA7IHLh7Yx1oE7a1dwOjhvY=; b=i/3GCRgkH+GCZ33bEkvjcyCaM0YCuJYPhL8bV8r15unBwWsfxIoHqccWpDgNW3yA/27Ov4TvlV8K9 R+f9SmXzzb3wLdnyBf+BPPyUiug/+gbSKhlGiA56loCPhzgFuMqHaSjpsWGyHHdbbna11a8RqB5CVF KQBL4a7gaABPsGcVpz02eatjemaGhye9wF8ZIV7jRu2X9wgVspytU1AhR2bLAu7tKBmhwIpn0/t9/n jH1UuXHvF/oprcQm7nRPvmTJULgkAqDlLFzTMJMa5vHALSo//1TQuZWmX8m9wqweBHATETo6wkkbOp 3qYJxh88QwZBIAgblcwg55+hF8DeETQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed2; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=HeoWzm4aDtjnCxaocC8ieA7IHLh7Yx1oE7a1dwOjhvY=; b=VXNu2p4FC6678WvzsO3GEKowhF6zZ/8yNORF5Xj6+wEtjgYetVEPae8zrvPSkCTBkBBYWsKw/feqM sLt1NI4DA== X-HalOne-ID: 342388af-7ee6-11ed-873b-7703b0afff57 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay5 (Halon) with ESMTPSA id 342388af-7ee6-11ed-873b-7703b0afff57; Sun, 18 Dec 2022 15:11:12 +0000 (UTC) Date: Sun, 18 Dec 2022 16:11:10 +0100 From: Sam Ravnborg To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Philipp Zabel , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, NXP Linux Team , Pengutronix Kernel Team Subject: Re: [PATCH v3 2/2] drm/imx/lcdc: Implement DRM driver for imx21 Message-ID: References: <20221216175006.456831-1-u.kleine-koenig@pengutronix.de> <20221216175006.456831-3-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221216175006.456831-3-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221218_071124_660621_78878920 X-CRM114-Status: GOOD ( 17.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Uwe. Two things I noticed while browsing the driver. I did not try to do a full review - maybe for the next round. Sam > +static unsigned int imx_lcdc_get_format(unsigned int drm_format) > +{ > + unsigned int bpp; > + > + switch (drm_format) { > + default: > + DRM_WARN("Format not supported - fallback to RGB565\n"); > + fallthrough; > + case DRM_FORMAT_RGB565: > + bpp = BPP_RGB565; > + break; > + } > + > + return bpp; > +} It would be great if the driver had fallback to the generic XRGB8888 variant. So is was either the native or a fallback generic. The latter just because most userspace assumes we have the XRGB8888 variant. > +static int imx_lcdc_probe(struct platform_device *pdev) > +{ > + struct imx_lcdc *lcdc; > + struct drm_device *drm; > + int irq; > + int ret; > + struct device *dev = &pdev->dev; > + > + lcdc = devm_drm_dev_alloc(dev, &imx_lcdc_drm_driver, > + struct imx_lcdc, drm); > + if (!lcdc) > + return -ENOMEM; > + > + drm = &lcdc->drm; > + > + lcdc->base = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(lcdc->base)) > + return dev_err_probe(dev, PTR_ERR(lcdc->base), "Cannot get IO memory\n"); > + > + /* Panel */ > + ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, &lcdc->panel, &lcdc->bridge); >From the documentation of drm_of_find_panel_or_bridge(): * This function is deprecated and should not be used in new drivers. Use * devm_drm_of_get_bridge() instead. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel