From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1B8BC4708E for ; Wed, 7 Dec 2022 15:44:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=igqruCiFYk4v7IZn0azG4rd7+C6W1OwfyggfI8eOawY=; b=sfHqYX9JUDbS53 vv8j+MhlF1WEuyXc11j52jT7id0Q5m34P9mY+iEshmt2c8bsXactUmfa0SVCI0cm9aPSJaaN7Vf/Z qA6/Iu6NmxxPCoWbEelO1sb6r6UPZZSPZW9MYFAuGY77FdprfAtjzKOhia3PuM5umdMtEwMiUqsLW OkFJKGtbyzBz95Kl5nG9Boht/Ud5abYE80fCGqGC24kQ5kchiD7DU3zsY3AGRSSFrcav05suZ55bN aXb4hbV3QehaEm8/5b+ljJZ0kyAYQ+ytx+g3l5ajISevoOQ6q4sTdkapLwBjsXN2ntDFoC74x7QvM 6dXFFi8GqreZrLunpLvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2wa0-0062oM-D7; Wed, 07 Dec 2022 15:43:28 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2wZw-0060EO-8h for linux-arm-kernel@lists.infradead.org; Wed, 07 Dec 2022 15:43:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ai9AyaYCOP+1mwEvT2GphqrR/8UUpCv7twpnp2ghV2Y=; b=XFnLUGerdTFheh129qR9NxuuEE wE6qV8cHZ/Xe8fWU6RCnXrx2owtf4Pv3lQ3g3b6gwVp1mdGe0Vo2a4BwKigQg1O3Xy9rT4S8YxWhj TBwt2OJFMefQ5Y3q9dlJojxrbircOIWKn7yD897QcPH0k6PMbqb1rjmAXKttaQtJTUgs71jJ6yDG4 PyGxnWT0kOonCAzoFe5yX6gNnBFUMb+KXLz8T7oCcqPnTKAfwbGyRbm8402RZ9vE8P/09PvIFw7DN 79gB74o+AD0ZZIVOVwbLBGQ44x8hd9QblrDJBSoiLyMefOHiqf5kh7G4gN6t+qIhPd0xyPWiAmD/2 5X48Z14g==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35618) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1p2wXp-0000m5-1X; Wed, 07 Dec 2022 15:41:13 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1p2wXn-0000qu-B2; Wed, 07 Dec 2022 15:41:11 +0000 Date: Wed, 7 Dec 2022 15:41:11 +0000 From: "Russell King (Oracle)" To: Andrew Lunn Cc: Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , linux-arm-kernel@lists.infradead.org, Robert Jarzmik , Haojian Zhuang , Daniel Mack , linux-kernel@vger.kernel.org Subject: Re: PXA25x: GPIO driver fails probe due to resource conflict with pinctrl driver Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221207_074324_341641_CE932201 X-CRM114-Status: GOOD ( 21.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 07, 2022 at 04:28:07PM +0100, Andrew Lunn wrote: > On Wed, Dec 07, 2022 at 12:25:53PM +0100, Jonathan Neusch=E4fer wrote: > > Hello, > > = > > I am currently trying to bring up Linux 6.1-rcX on a PXA255 board, usin= g a > > devicetree. One problem I encountered is that the PXA GPIO driver fails= to > > probe because it uses the same MMIO register range as the pinctrl drive= r: > > = > > [ 0.666169] pxa25x-pinctrl 40e00054.pinctrl: initialized pxa2xx pinc= trl driver > > [ 0.694407] pxa-gpio 40e00000.gpio: can't request region for resourc= e [mem 0x40e00000-0x40e0ffff] > > [ 0.695050] pxa-gpio: probe of 40e00000.gpio failed with error -16 > > = > > Before I try to fix this myself: Is GPIO on PXA25x currently expected to > > work and when has it last been seen working? > > = > > What would be a good way to fix this? > = > How are the registers arranged? As documented in drivers/gpio/gpio-pxa.c - it'll be easier for you to look there rather than for me to explain it - but suffice it to say that the pinctrl registers are amongst the GPIO registers. > Is 0x40e00000-0x40e0ffff simply too > large, and making it smaller would fix the issue? Or are the registers > interleaved? They're interleaved. Looking at the .dtsi file for PXA25x, it seems that the pinctrl claims just the addresses that it needs, but the GPIO controller has no reg property in the .dtsi, so I'm not sure what fills that information in. DT could describe the region for PXA25x, which is just: 0x40e00000 - 0x40e00054 Later PXA have more banks, so would require additional resources to be listed. However, first, we need to know what provides the iomem resource for this: gpio: gpio@40e00000 { compatible =3D "intel,pxa25x-gpio"; gpio-ranges =3D <&pinctrl 0 0 84>; clocks =3D <&clks CLK_NONE>; }; -- = RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel