From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53A20C352A1 for ; Wed, 7 Dec 2022 16:41:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gGtrs5AsiXnT+xRsK33Rtu2R4s1k/GbIaoM7gEUqP8I=; b=XrU23BZ33PyUJIy5N0b3bWZsMh zfoXRlqWm3Zi1Y9v4ARSdQ559fBp8m4iq9YXg9K5ehyRsyPUOBnMGiAIZ2tOpI2cVme42jHvnDlZe u/Rk//r/bBT7Dt08Zq0Koui4LciVspz+d+Si22QjMVrUQdVt0yegli7uyn5XAvwGKis9dTnhNq0Ic e7Mug33ViIB3XTDvujptML8QLvYIQT8Ecqzs13tMqfr2s7+b7pw5sb5nvYU9AIIKHuX3qYpcMy3/0 Nnt7Yi4kZu0C8WI3a5cxoEo37PyVpEngdifNfSwaZ0/hGABTNVR4K7lfhJnAcZq9vqWf8yMfCKc3+ 2bBJuryg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2xTW-006pVx-Su; Wed, 07 Dec 2022 16:40:51 +0000 Received: from mout.gmx.net ([212.227.17.21]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2xTT-006pPT-26 for linux-arm-kernel@lists.infradead.org; Wed, 07 Dec 2022 16:40:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1670431233; bh=vHbyI4KninQa8GUacM2PEFRzfxzNLfAd/A2kuP75LOs=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=ezsSHQWcbR3URE/ostikH9C57NPdlvVk7q57jl46Y97jxgdrqlhLjmRm8qHoqNNLr d3UA40ZFvNKk+NA8MEZcOs17gYloE6mX+nWr7YKniqlK9nD4r5f8WrFmcBNY6PtVB/ 0tWookI6hJNLeXS0rRfizRaId0+OuQ5UOTcNHohqBzGLEvOcAmLQ0S5VG7PBwNBzLh /8wyJynZeTmEgjLT82gnd1nhYBOq7EGN/8dl1vG2gmrvQdAi8HX/4X0vam64IwTtv3 f5Fpqwlcnz9uEGkk2TEnVTqeH/zRkAsQQDre0R60e7zCN3O8kyepcwLNN0RSE0gP9P HHBfcXqf2C3Mw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from probook ([95.223.44.31]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N4zAy-1ov5lt0Iho-010rgE; Wed, 07 Dec 2022 17:40:33 +0100 Date: Wed, 7 Dec 2022 17:40:29 +0100 From: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= To: Andrew Lunn Cc: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , linux-arm-kernel@lists.infradead.org, Robert Jarzmik , Haojian Zhuang , Daniel Mack , linux-kernel@vger.kernel.org Subject: Re: PXA25x: GPIO driver fails probe due to resource conflict with pinctrl driver Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Provags-ID: V03:K1:V11AYrdqEj4rb7KhTFXacb2WROqGOGmd9a3u6s/zvSCOlwpxjWD 4h0UBKSdcKVeL64D2XKr/MVJsGkUCggLNO8bPlGKvo0P2AkrMX1PPdcRB9ACT07KJban97p uohE/eSu6bHR4ORYPVKJrHiQoazhHjn5vXByR84/lbTyMmUQjFH+ZZldjC61hS8XwG09LrI Ip72V4/ZMbNyJKc4Nx4UQ== UI-OutboundReport: notjunk:1;M01:P0:z2dBSeZxrsM=;gv55Z+ag1tD3Y/zdVE3OINcPK13 KVHUMKgmS0+DW49tHvpzwz1auArARUXoNoll7JZ1s2MOv0d7qGAn9NPAVY8yKHnRgmbWdSqNF T0tYT8BsoEF6fH/LcjcVGIeAiJCOV0XUWQP2SZKGs2uj7u+ZklX56ZsLyj7F2g8QLTgDOJjNh lypyufaeZMI4voj9+ERpUkgs73OdtihcvY2YXYSvmStDVuoho5PMCRW14pzs1A3PR8vSI/zXz 79c3siuOEWU1SOfXdBM9zGrwGp+U9NlUajETOUABVcSLHti70ZXzlbLs+oUNOtV2aYwvq0YYM SaCfCkM3/Sr65GIHMtceGQ6VGuwF/dO0MR0IXwy0fHDruD6MhzG8UPpeiGTbukwFpb8xfwCbw KwXdYmCzUwj0+6t7TMw0NgWjZ6t5tYjVuyRHTXhvhsGqzmoY8kOxJGxI5nX61XTAlsk2F3pjy Hr4BAmjtFnCCzoUlhdRYUXojiw6S/A2nvdZCIL8BBvGc/+y5UJjnMsiQrJhuw/zTuFD+R2uVk YFPJQQX0BVqPNcGu5F2mI5fMs24dVUMYmsrJvUqVk9zoWmMrEMenpgnQJEz06CSvSGB0q6oHg Gd+PILWSVuKEHw/66cGFEJnNu5BIbRxlhlB+SZ5kaR3p2+gM5nV66celVRmGqyl6XuYmEoUik wDTmlLgES9aKGrUplzhhgjheeeC+GprS5oYPA5wMgePgEOJuMCsuTDK10zKuqHklgRimiOGcr TTEkgsWOMm+Uc9qrcnzX5w4x85kYDfOvalxlJvFzbKxYUyRHdueahkRiSQUPxlUWozco3qC7B 1JgDF/CQjjDTGeuP3pbmC7+M83i6jH2sVdhWOkUcEOv3H/2M/EqCAfQ/thhcmCAhY5pidZ+0N PvsRsb4uUkQnr1ePp5H2FNGs57iE7k5mDjaU6EbB2KTfdki8nSVPe0+wQExO8Wme9qQTdRHJN ZthDInCLo11XJ9z2RUp45f1DalY= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221207_084047_415257_FB373AD1 X-CRM114-Status: GOOD ( 21.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7285891443693524482==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7285891443693524482== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="O+tGawdhdu6+c3kL" Content-Disposition: inline --O+tGawdhdu6+c3kL Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 07, 2022 at 04:28:07PM +0100, Andrew Lunn wrote: > On Wed, Dec 07, 2022 at 12:25:53PM +0100, Jonathan Neusch=C3=A4fer wrote: > > Hello, > >=20 > > I am currently trying to bring up Linux 6.1-rcX on a PXA255 board, usin= g a > > devicetree. One problem I encountered is that the PXA GPIO driver fails= to > > probe because it uses the same MMIO register range as the pinctrl drive= r: > >=20 > > [ 0.666169] pxa25x-pinctrl 40e00054.pinctrl: initialized pxa2xx pinc= trl driver > > [ 0.694407] pxa-gpio 40e00000.gpio: can't request region for resourc= e [mem 0x40e00000-0x40e0ffff] > > [ 0.695050] pxa-gpio: probe of 40e00000.gpio failed with error -16 > >=20 > > Before I try to fix this myself: Is GPIO on PXA25x currently expected to > > work and when has it last been seen working? > >=20 > > What would be a good way to fix this? >=20 > How are the registers arranged? Is 0x40e00000-0x40e0ffff simply too > large, and making it smaller would fix the issue? Or are the registers > interleaved? It is possible to request a region in a non-exclusive > manor. Or is it more than interleaving, individual registers need to > be shared between the two drivers? If so, you have the locking issues > you mentioned. >=20 > Andrew (I wrote this before I saw the other reply, so there are probably duplicate information) They overlap. pxa25x.dtsi declares: pinctrl: pinctrl@40e00000 { reg =3D <0x40e00054 0x20>, // base_af[0] <0x40e0000c 0xc>, // base_dir[0] <0x40e0010c 4>, // base_dir[3] <0x40f00020 0x10>; // base_sleep[0] compatible =3D "marvell,pxa25x-pinctrl"; }; (comments mine, based on pinctrl-pxxa25x.c) The GPIO driver mentions these registers (for PXA25x): GPLR GPDR GPSR GPCR GRER GFER GEDR BANK 0 - 0x0000 0x000C 0x0018 0x0024 0x0030 0x003C 0x0048 BANK 1 - 0x0004 0x0010 0x001C 0x0028 0x0034 0x0040 0x004C BANK 2 - 0x0008 0x0014 0x0020 0x002C 0x0038 0x0044 0x0050 So, there are overlaps in GPDR (0x0c-0x14, GPIO pin direction register). The register at 0x10c seems bogus for PXA25x: gpio-pxa.c mentions it as part of bank 3, which only exists in PXA27x or later. Jonathan --O+tGawdhdu6+c3kL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmOQwc4ACgkQCDBEmo7z X9u11hAAtyDGP3CwoepPK3iQ5rD1e1Mqiy+Qntdz8sgUKGVNzCqspco4Pn9GFs7C MrLTd/IGIgwWNFVs2mexqQZuVRz8drUSjfns2SLgQl5XoJow/imTuMWdgEjSDcSV vBsfc9JEZLe1TASxkKpI9xY0my2CHby8/Eko2vg5BYRb4Fn8UAPX52ECSYS42IG8 7jVn3cv+btT6HcyCA1kI3et/OjojGSUG4u8qFjZsNevLpD5ypb+pabU6Y8W1B0hJ lN37pykzO4RLwM6/hIsRH+gkEhDdZS1ZXFi+PwusGsBr7cqqgBclLi0brabBkEP4 TU6W9Uns2AEJ8lAWoK8r1iT6f4XcaG/S88tCXpJXzZ5ZHONtbGB2ZtJq/sAqiPr3 V3rMIC2B7RExpmrhxX0hny1OnKHDQqw6zt1X0pCWjJzLR2tehK0V2CYTNkkjgLQy DmCBwilGiIQ4Rbb+QvP0innL5XyOXP29BZosJrmrAiTGLkhTOcOg95zthEnAuBef s9EPwiCMOMo3cHwFp2oQaKEeFHR4aZYEiy3yG3FZo/tAjvncG0u3GniXC2wMELBt N9dF0qrbLYR4XEUSir6QUbMOi83LKXXI1xmj7Medh/M1TPJjOInRcs/RIvv7jTzq qHpjP8tB8OgPCLhG4HlLWNj6NE1UF0jUqnf5LrH6fyCv0OGN1bE= =1vx/ -----END PGP SIGNATURE----- --O+tGawdhdu6+c3kL-- --===============7285891443693524482== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7285891443693524482==--