From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58F24C4708D for ; Wed, 7 Dec 2022 20:06:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cmIMoU50nAeR3fP/wBF6ch7JbOoU4aaCh9XTUyC2Enk=; b=3ItriUgPlhTgXF2exJAnAq9aOi PZQEn2KRFPuam7M9NyXLu2W1kf41oy9M2/Wrrlcn8ez8Ut1ULHYpEPCGMjioMu9nnSh7QbFgns4TT hz04bK5QnospUeiY5T2xeG8YO8Hihxn0N5g6DOT/6bN/e6VcuUhpGUvWGdvrh+HTL7cR041brzgtF GYuljhnm8JikPo+zsmKCoselvfI8l8iSEQBwJIl/cQfdcg8cC0lsFV9cOFLf1xL05w+NNhbCD1N6v RIufVpzL8l/L/6dnFIucGYeZkxdFDXWX5GqTJTRD6KREl2DCxavpfBC4dGg7N/om/d2fSmHjm18g6 bTn39B8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p30fM-00BXFQ-A8; Wed, 07 Dec 2022 20:05:16 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p30fJ-00BXD4-7N for linux-arm-kernel@lists.infradead.org; Wed, 07 Dec 2022 20:05:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0AEF8B81DDC; Wed, 7 Dec 2022 20:05:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37612C433C1; Wed, 7 Dec 2022 20:05:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670443509; bh=3UL/IpS+mva6RzkvSKMbS87yIvyMHCLzltqoU5DgxIw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U5CMVg/IsblyR2vEFDIrcZL8Uch0Dvi1iA2+sIeXmtUfc0z1JX0SD1bFGQWcJ80+N Xn+aaU15ogfats9HaXebZe5mpFJQEMxrICMgO42WXOXWNl9cKLbrqy7hIYUKQNyKik I6Nnwxa/B0hxQjv6xvKfKUCR0pFQoS29R2iGnLOB8m6HnqJtwCi6JUBmjjhxbTANRA aCh/nH1jQIH35wJafpXdZTbmUGTrrWNzilJWPJ/eg8l6yQcWR3iHAXgFIPaR6PsPA8 oRH+sjEuvL0HpyZyJrKIwFz4JA1IpKUOc9dhXfVA0noc/PY3wHxw+uFa3sgDDitSoT nAlZVJD+FB4xw== Date: Wed, 7 Dec 2022 21:05:05 +0100 From: Wolfram Sang To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Michal Simek , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] i2c: xiic: Make sure to disable clock on .remove() Message-ID: Mail-Followup-To: Wolfram Sang , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Michal Simek , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, kernel@pengutronix.de References: <20221019202808.88779-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20221019202808.88779-1-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221207_120513_434488_4E1220F8 X-CRM114-Status: GOOD ( 13.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3407840053046550347==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3407840053046550347== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7gaQPCGDRnmpfteL" Content-Disposition: inline --7gaQPCGDRnmpfteL Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 19, 2022 at 10:28:08PM +0200, Uwe Kleine-K=C3=B6nig wrote: > If for whatever reasons pm_runtime_resume_and_get() failed, .remove() is > exited early, the clock isn't freed and runtime PM state isn't reset. >=20 > The right thing to do however is to free all resources that don't need > HW access after a problem with runtime PM. Also issue a warning in that > case and return 0 to suppress a less helpful warning by the driver core. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig Applied to for-next, thanks! --7gaQPCGDRnmpfteL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmOQ8e4ACgkQFA3kzBSg KbaFSw/8DbpF05k8MsaBQF/2kcWrKwuBoiEmT9rd68TWTm2X3RBGBnklw4QbhOyC gOTkOCbbH4U6rnDp1C7w2fzl7Z9Y/2KkkV7kyFkyb/JuWXlYFwDadJs/+/kBkxkJ VwKNhwfWqiWPn8Y9kbRQrCGPwf33feiK+4OJg0/44wOE0GLthT5ITh7YTl8U7EeT R/AYQPS6i6qjDwGL7HoCCQfmGJqS924Qrw0aXLXcJ2PjE7VRLEdlGNxTLOj/vsvk UCC7ItxC+snh6c51a/wEbceSkEDvCY8l2a2k/dtiUzClLeuTYQUtJFFMTtSqSwkd xna0eamR96P7231Wc9o0bUd9UAKPZWfywmWBVJfMEfQnF80+c0ujQcBg9jpG6NTZ jjkkwgRVnAaivOpQpy+/+7Ww+nrsUWVErWjxjRcCSBQEit9/3wlMkaoo6eaRNMuH 9KQbQ4r6p7s97FaGoEbri79A570Kbu6Qf9+cbr+c/I/AX5KciaBSpneqd7FkwdRJ 1peeGNNLrPnUbiCfj03o5iRPHyEPrWtns6upw67yyyB3KZvITc/nb2CGVt6eaZ0f wV26UtvTLnC59ma0DJlvmUZOcODqlMCKMIpcbk76sESh5vEoFdqd5aMzC5mV1+kX j7cceU67g8M9V687N7AHwEJq3CwmJ9iC0Ov/BgBFc+7wG6+OcVk= =7YRD -----END PGP SIGNATURE----- --7gaQPCGDRnmpfteL-- --===============3407840053046550347== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3407840053046550347==--