From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02793C4332F for ; Thu, 8 Dec 2022 09:42:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RrSXeM6SNO0wXp09R5ZVTLIbR0LPReGm19l9t4jAtd8=; b=0ivPXLj08YeNqL MKY/W3grHtG1LKLSeH7WXHjZrmMGQAaH6fs3rS2EgOczVeJhHFut0Kn945cKvEO7u9QBtbYealUZq 96gj59YJhvJlrJCxvZWfCUkPMV/ihtxu+IXUmoOZnDTurlbfgHUZ0nfWkRdiicqT4QbDQtB23xlcD BuIhlJNd5G/1U93OE4spxOwV40aF668bKblI2921QSFBCTPoE29cBGk25JVreoGxvT8erayoc40Tz 2PhEfpnyX0nuMBBGboAjQOcoX1ODSurTvqWor0A0scOwqtcVF2tHzjiOji2mpA2mNWb+YQxm+wreC 51GQ8EsvTMzkKtCVsbeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3DP7-00B4wx-5E; Thu, 08 Dec 2022 09:41:21 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3DDK-00At0n-FN for linux-arm-kernel@lists.infradead.org; Thu, 08 Dec 2022 09:29:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5CD3961D91; Thu, 8 Dec 2022 09:29:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B9EBC433C1; Thu, 8 Dec 2022 09:29:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670491748; bh=JTSnvjJbgzaHvbJe+ytd+IiJru5C8GekViaefPzGqjs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YRgGiT7IJv5CJgKhokEss4bEjglrQqeNSiwFnI6ShvcMt5gBD+76VhZGTqsIRhjuh Pzn44al0MvYfwk32ddPNEw0i1ezI1II2/1lLAqhc7yBXFb+MinvQMXPbppiufR3ebE sEQJB+RmgJltNq8yabqt69XmhPRb2EksnyCg42keAS1BSrLlqyhzwQ/+zRTDRLnQkz GQEg13MCaMNHkL8UEONxe8hnL35dE5LgbT3bzxQJpfI4AJVoRJ/TBrIRGH3Hnv3xm2 v/qGvuLBAV/b55yeO2yprdKUPT+ipaglA+re7PU5Ba4M4GA9twBUxdTjlxBFyWDUvi PJb5i/YM3OyRQ== Date: Thu, 8 Dec 2022 11:29:04 +0200 From: Leon Romanovsky To: Yang Yingliang Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, Michal Simek , John Linn , Sadanand M , linux-arm-kernel@lists.infradead.org, Ilya Yanok , Joerg Reuter , linux-hams@vger.kernel.org Subject: Re: [PATCH v2 resend 0/4] net: don't call dev_kfree_skb() under spin_lock_irqsave() Message-ID: References: <20221208032655.1024032-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221208032655.1024032-1-yangyingliang@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221208_012910_597325_5CD20DF3 X-CRM114-Status: GOOD ( 13.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 08, 2022 at 11:26:51AM +0800, Yang Yingliang wrote: > It is not allowed to call consume_skb() from hardware interrupt context > or with interrupts being disabled. This patchset replace dev_kfree_skb() > with dev_consume_skb_irq() under spin_lock_irqsave() in some drivers, or > move dev_kfree_skb() after spin_unlock_irqrestore(). Like I said it to you already. You MUST explain why dev_consume_skb_irq() was chosen over dev_kfree_skb_irq(). Thanks > > Resend for CC all authors / reviewers of commits under "Fixes:". > > v1 -> v2: > patch #2 Move dev_kfree_skb() after spin_unlock_irqrestore() > > Yang Yingliang (4): > net: emaclite: don't call dev_kfree_skb() under spin_lock_irqsave() > net: ethernet: dnet: don't call dev_kfree_skb() under > spin_lock_irqsave() > hamradio: don't call dev_kfree_skb() under spin_lock_irqsave() > net: amd: lance: don't call dev_kfree_skb() under spin_lock_irqsave() > > drivers/net/ethernet/amd/atarilance.c | 2 +- > drivers/net/ethernet/amd/lance.c | 2 +- > drivers/net/ethernet/dnet.c | 4 ++-- > drivers/net/ethernet/xilinx/xilinx_emaclite.c | 2 +- > drivers/net/hamradio/scc.c | 6 +++--- > 5 files changed, 8 insertions(+), 8 deletions(-) > > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel