From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Andrew Lunn" <andrew@lunn.ch>,
linux-arm-kernel@lists.infradead.org,
"Robert Jarzmik" <robert.jarzmik@free.fr>,
"Haojian Zhuang" <haojian.zhuang@gmail.com>,
"Daniel Mack" <daniel@zonque.org>,
linux-kernel@vger.kernel.org
Subject: Re: PXA25x: GPIO driver fails probe due to resource conflict with pinctrl driver
Date: Thu, 8 Dec 2022 19:36:04 +0100 [thread overview]
Message-ID: <Y5IulKoRctcrWBzl@probook> (raw)
In-Reply-To: <Y5DbKNI3e+tFA++1@shell.armlinux.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 1431 bytes --]
On Wed, Dec 07, 2022 at 06:27:52PM +0000, Russell King (Oracle) wrote:
> On Wed, Dec 07, 2022 at 05:44:58PM +0100, Jonathan Neuschäfer wrote:
> > On Wed, Dec 07, 2022 at 03:41:11PM +0000, Russell King (Oracle) wrote:
> > > On Wed, Dec 07, 2022 at 04:28:07PM +0100, Andrew Lunn wrote:
> > [...]
> > > > How are the registers arranged?
> > >
> > > As documented in drivers/gpio/gpio-pxa.c - it'll be easier for you to
> > > look there rather than for me to explain it - but suffice it to say
> > > that the pinctrl registers are amongst the GPIO registers.
> > >
> > > > Is 0x40e00000-0x40e0ffff simply too
> > > > large, and making it smaller would fix the issue? Or are the registers
> > > > interleaved?
> > >
> > > They're interleaved. Looking at the .dtsi file for PXA25x, it seems
> > > that the pinctrl claims just the addresses that it needs, but the GPIO
> > > controller has no reg property in the .dtsi, so I'm not sure what fills
> > > that information in.
> >
> > The GPIO reg property is in pxa2xx.dtsi.
>
> Looks to me like pxa25x should override the reg property with a smaller
> range (0x54) and pxa27x probably should have used a second set of
> entries in reg the subsequent group of 3 gpio blocks at offset 0x100.
Without further code changes this wouldn't be sufficient, because the
pinctrl driver also touches the GPIO direction registers at offset
0x0c-0x14.
Jonathan
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-12-08 18:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 11:25 PXA25x: GPIO driver fails probe due to resource conflict with pinctrl driver Jonathan Neuschäfer
2022-12-07 15:28 ` Andrew Lunn
2022-12-07 15:41 ` Russell King (Oracle)
2022-12-07 16:44 ` Jonathan Neuschäfer
2022-12-07 18:27 ` Russell King (Oracle)
2022-12-08 18:36 ` Jonathan Neuschäfer [this message]
2022-12-08 18:46 ` Robert Jarzmik
2022-12-08 19:10 ` Russell King (Oracle)
2022-12-08 20:19 ` Robert Jarzmik
2022-12-08 21:53 ` Jonathan Neuschäfer
2022-12-08 22:29 ` Russell King (Oracle)
2022-12-09 8:55 ` Robert Jarzmik
2022-12-07 16:40 ` Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5IulKoRctcrWBzl@probook \
--to=j.neuschaefer@gmx.net \
--cc=andrew@lunn.ch \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).