From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F70BC4332F for ; Fri, 9 Dec 2022 04:40:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c7eKRtAhJzrRYJI3Y9vhC2vJnmNCMgsLp5iTtncMu3c=; b=QM9jBDOYZG3gPc x9SQsBMIZqBJ3dhoxDPfD824fNNS/AwKbPj8is3OwjfxcwC2bpuYmV7Ie+fQ7VE/noof4wO5wEbzc Zz6SvlLpsGp2a9w/jY8vFEZhWjAunN9dUuzi5IRgUX7k4pNL1NE38s1t/lk3OwdVe+sjxO50e1rE1 +vhTN07LMF9lhz2sQAIIjlyBvF2kZJuJMQfkv+0ydK1hchzgmBNnVKdnBz3ObajHFfs86cJamqlqS pNH4C+q/6dVZxOfdHc90Cr/I80w9AKV3nxAxyZggDPIFqAm/UT2FMqE0lFGEnHbM8Sn37E5Cb17Fo 7XBOfoXaTCqla6ms0HSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3VAP-003h6G-CS; Fri, 09 Dec 2022 04:39:21 +0000 Received: from mail-db3eur04on062c.outbound.protection.outlook.com ([2a01:111:f400:fe0c::62c] helo=EUR04-DB3-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3VAK-003gjY-Rm for linux-arm-kernel@lists.infradead.org; Fri, 09 Dec 2022 04:39:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JGygBM4VYujejhSp/DVadfCqmHrb7HQ9M3Ib4TRLDDkyF8GMfRag2CfWUrEYWdONJ/7w2QEuVR6gCsR8R9EXUMMYz2cF5aX/jtwuWoCwA6OKbw3sPX2BpTV3LiOrw6CwC9sPAo9FRCw9IbhIfq+56abVo9U4MzgL9RdVrdvuwo1RIHussWw0OEjBKapbZOEnxANG5wY84ndtQD0Qf4jIF5ylvqplstEbPMP54XWYYamAiAXVBJbBKPVKK/R+ox+NYr/OTaf5cF0D2MpByFjLPCJ4LBbGzGE2teCHYR7Z5zFrnGtGVY/mUPRquZvo3wb+TeZj3M8y3laJ7wDra5ehNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=krYM4wEtvuuArgN0tfvokRxHJdMqM2aZ+R7FZv7J7rg=; b=O2ooEx083I/YFarEKM0DEypQwXFGbhSTFyKds4GEEqmaxC5yTBK766Bcm7kjOMUeqbuzuJ1z48q8ZX1uE/7WOLkJqFIDvktIZQNjwkyC+PPiqgpo3kS9i4ZDJwxaXgutIWxp08f7bTnN6qPUjubtgCcariJ8+ik9d0XJJ6U1CYDr399bz9JF/61kMz8eK7w5pkvKQ3BMgeIiUG1KwdH+zKn3nOjNDHdgfAssBB59nJ0asavCAJ+b1fhK61/SJp155UawscwxZBBx60HWbloCVHTZRt9Qnfs0adbW2D263pmKRdKjiBmRsu/k/un5k5a4SkNuSzRUMr7p8Egni4IJYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=krYM4wEtvuuArgN0tfvokRxHJdMqM2aZ+R7FZv7J7rg=; b=qcKwtr3Lc8gudq7UqHOSypMmudkt2Z+oS1loSg7iQ1omxE1HYwfhARtQavTwlwE2vRlCFD2r/2jn9OdE+IOd0G+Xk7Qq2CPhCeFI4FeTo5vYRZC490T5iX/SG5FFsaUlFNSUFuXrKsqae5S14uSlBhmwwNwRjPKLLjav+DwECjyTyW3wqFqZ5BiH5eSqDCS4TKiGBjxattblXLv+h1INTjjk2hrP7rx+iwnHJG8QJeR2NgHbZu9bPeCS4Gbkhe911aKvPahZj54UDVMe66D2Ql7Vucj0iRpohmStBHIxCmIqhhPs2GKuVJFPez8Sfqt6c1FxMsPMOUHslOctyDEmrA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VI1PR0402MB3439.eurprd04.prod.outlook.com (2603:10a6:803:4::13) by AM8PR04MB7377.eurprd04.prod.outlook.com (2603:10a6:20b:1de::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.11; Fri, 9 Dec 2022 04:39:11 +0000 Received: from VI1PR0402MB3439.eurprd04.prod.outlook.com ([fe80::28d6:1b8:94d9:89f5]) by VI1PR0402MB3439.eurprd04.prod.outlook.com ([fe80::28d6:1b8:94d9:89f5%7]) with mapi id 15.20.5880.011; Fri, 9 Dec 2022 04:39:10 +0000 Date: Fri, 9 Dec 2022 12:38:51 +0800 From: Chester Lin To: Linus Walleij Cc: Fabio Estevam , Dong Aisheng , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , s32@nxp.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Larisa Grigore , Ghennadi Procopciuc , Andrei Stefanescu , Radu Pirea , Andreas =?iso-8859-1?Q?F=E4rber?= , Matthias Brugger , Matthew Nunez , Phu Luu An , Stefan-Gabriel Mirea Subject: Re: [PATCH v2 2/2] pinctrl: add NXP S32 SoC family support Message-ID: References: <20221128054820.1771-1-clin@suse.com> <20221128054820.1771-3-clin@suse.com> Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: TYCP301CA0034.JPNP301.PROD.OUTLOOK.COM (2603:1096:400:380::14) To VI1PR0402MB3439.eurprd04.prod.outlook.com (2603:10a6:803:4::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR0402MB3439:EE_|AM8PR04MB7377:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e0497b3-462a-45f9-2ace-08dad99f50d9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P892p19npaRtH/1LKjs1HzWb9WeBKXJ/OJhU3icv4F8pEU9CpHPBtnGnSQDM4REVDitPnT8KPRVvnD4pa+iiGXS7k8+alZHfRDJKQCTIr4tA/2iATFfqioBJ7zGeNfJGk8ercwZHaURo/qXcFAjGpJRUVS9rA0Z6sjtpdYWlenxgoLHtMKeW04yg+tafddnZHnXssptInOca/2fRQ1CcnmTqAy70E6/qEKnO95teBUvnKHByysJYpoT1kP8KbW/2b+dvuLH9nAcBWoevuHXqELreF7H2RDqBva88KQY3JeHCCHOu7jmapA1HKuwiUFHIdrNGI3Aw4wFApmgRmCrYVAb3bkuDkvhx5dmNGeYsKoyBvy/2yjxpyKgZ2FBSrB0OyofYMGC8exg7Ymd7AVZioajnPLwnTF20CS1V0O3Fl8s6070OBZftuGH0wjNJkKr3nioXCejq0GHpMZQr64Fn5u1KhgSjdo6Rsc8MuBkj2qYW3oNyg2/nAj5/TOYWJSyC2s6FY48+yHCmvGlsxnq94K/VPD+cmchcLoHUxN/+zseFoOp2OaX4NkYiSZJqGyG1IqxQoxsXP4Yc9A29GQllK8jUL58nw5m1DezfZRJuffxpsXew6Sa0FAIJKnJ6+BNDyYg8/ULt/NMDWw20CSyw5A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0402MB3439.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(7916004)(376002)(136003)(346002)(396003)(39860400002)(366004)(451199015)(86362001)(41300700001)(38100700002)(8936002)(7416002)(5660300002)(4744005)(8676002)(66946007)(66476007)(66556008)(4326008)(33716001)(2906002)(9686003)(26005)(6512007)(83380400001)(316002)(6486002)(54906003)(6916009)(53546011)(6506007)(6666004)(186003)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oNKyglSeoUfzmJQ6xnMkV6KccDpAgL0ChcwEQDLgLVkBkmwElJ6JSwvHn4Ar?= =?us-ascii?Q?oMFVn+46Wc87BWm3mP3fSozK4h5ODdi7WcHfVrBR5TjTdKSCWsl+7fnlgOKg?= =?us-ascii?Q?K3Cp8J79lUbdV31dXliMxhmJNQRm42Mvr4oX4tnhz04oCMc7aBg+1MgnqhhR?= =?us-ascii?Q?/rickF7/DKtcocdaOxEzUuydIWACd6B88aqTcAn/mGw5FKHtQYcm/I7b+KrV?= =?us-ascii?Q?RWcx5JjXMkEAK7qp2n/JaSWWLPjKsG4TXMJi3kIdoPfwFZjPl1RP1vuAi1gy?= =?us-ascii?Q?5Ycw886VIACGWpLpPnv62dvBs8GmMD8RIPvKxcrTqjNlvnP07CeRJO5zRRPS?= =?us-ascii?Q?hiAu6JjGvLH3ljXkLTqTp0kDyDywk+n6zV/4C933jtBnGDacRYKsf+r6zllt?= =?us-ascii?Q?1u1kzFW1s2WWNehMp7GuxBC2iRf0O9aoCGk4hN9A+OhGjX3aPa2vlVyz3pqV?= =?us-ascii?Q?8xaJAHXSWafk3UamMVOFF6pywncv3dqqcUr/XWBFx+h1BYOVV3Cj6oeu1w8D?= =?us-ascii?Q?Jr+pYxpY17LeZc6bXYFp/sFdLIuN9ow44A/q5K5iLxOjNevLPXtDLYsxSzU8?= =?us-ascii?Q?NyXgOthW+8DZIaMNoKEUaeyXbHTH5xlSnvh/Ffrj9YY9qAdOWSBGJso0SD9w?= =?us-ascii?Q?I3pcJqIJKtMJf5gtSOSbINgW5cNbnO9G8e+dtXo917LHfZpnUy0jq6e2IHOV?= =?us-ascii?Q?3e7n6ZirYUILIjVQJ9SARNTg9Mu3NS9wE2qXXinP6FOwyuB4HSob3h8pzx/j?= =?us-ascii?Q?U4MCW5IrS61Kl4h8Ff8sKiT/mGzZ9dP6wJWu4tNEBML2jEvRgF14rdOStyc8?= =?us-ascii?Q?l4OsXYY8ub0XUphP5bSGYxVJkvjPxIuvN/GeK5ALGH7qPXt9Y971YY10f1mP?= =?us-ascii?Q?2vbgRwfa/daR29+3X6TlXWIflW0Ds9asy3ZK61/NlLelyi8GEpTyXxpNkRSX?= =?us-ascii?Q?0BeJ6kyJoTIMhAqm7NWTEDLUeQ/0HBva3gY57vmkkbMdm4tG8A5gAr2mtcGF?= =?us-ascii?Q?uvljVN+k6FeWKNhF9vO8GQyaqE/A4GnRY0jVJY0ORsalvfaz4XQrWzxDhW0W?= =?us-ascii?Q?kXtzMQilU6lGiiONSfRtk3iBTmBJcNfilIteTfW5Dcx0bi5BOTYpwK+1v/fl?= =?us-ascii?Q?0V5tjW/NDi74Kp4xo4zj6tpDdTp45c25ytl/IcRqyM/gmQR+JcQfDi8cElOD?= =?us-ascii?Q?Fch95r/2KChLLKvPyiIoio7pAeN74XY57Sc8+HmzgF8co/c3MsTpyhU+h+mS?= =?us-ascii?Q?NV6DPvfnU2zeknkHxPD60TFMuf5zKgWrvAPxjBqIQjkomYUGF5+OoGwut7ZW?= =?us-ascii?Q?NW6jJZk8wC8Jhuj1WbHtZ93nb+DvDpvw8CPZwoijlClpUHs82wgIbZrgO0mG?= =?us-ascii?Q?kOoWcqKw0X/yiXm42lqK4TM6nQqMPjhTfWd+dY3odX9/43I5zlmcHMU7SAqq?= =?us-ascii?Q?NbKcY3/Gh1YfNNjrGG1LXUeL0qOIp/g26J+o5SqPdMLt7BtC/d0Fm7s3te8j?= =?us-ascii?Q?xXbKqkQNqmI8w3a0oOUaDZrlufpCMxFhBJlEM7y2Nns64BRbHokfeHlm7AN1?= =?us-ascii?Q?2zfiwdqu1Z3b0JYN8lM=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e0497b3-462a-45f9-2ace-08dad99f50d9 X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3439.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2022 04:39:10.8908 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wqZHY31qdB7xzfRzsNRqJSjalYbI5kKGGsy0YsJaTXZBUQr4Z2SXHbwKmOO0pRgF X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7377 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221208_203917_165500_C1EB6CE0 X-CRM114-Status: GOOD ( 13.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Linus and Fabio, Thanks for your time to review this patch! On Thu, Dec 08, 2022 at 10:37:36PM +0100, Linus Walleij wrote: > On Thu, Dec 8, 2022 at 12:04 AM Fabio Estevam wrote: > > > In other imx8m pinctrl drivers we pass: > (...) > > > +module_platform_driver(s32g_pinctrl_driver); > > > > And we also register it in arch_initcall() level. > > Do you really need that though? This driver certainly does not. > > I was under the impression that recent changes to the probe-order > logic has made most explicit arch_ etc initcall orderings surplus. > Could bool/tristate options in the Kconfig be the key point? Based on current design I prefer to build the s32g2 pinctrl driver as built-in rather than a loadable module. IIUC, when the driver is not built as module then the initcall ordering should still matter. Feel free to correct me if anything wrong. Regards, Chester > Yours, > Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel