From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F055CC4332F for ; Fri, 9 Dec 2022 12:30:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OiQHHy3IVzL1Cx5B7wMLG+4FhJa9VDZnkMYbtM6yLwE=; b=HsOCFZmo5WsvSu 5qFFjRJBgfny4kVHgyvRexvVxX/w1dP33rK8ujrH4xYExD0aG84+I48M7suBIcbzW7BSM7f/CMPwU tRzc3lwHnv3BZN9OUBcN2BAyDPXaujTpn591xd4V4xaLDfdzfXLtPYxbSGeiW7v0Z+Kl72Aq1STaT yTxrwCuejmmXaF/w1T2euIq++jRO1+R7WUZg1079klCX+2lAGFmeMNEvEc6noLcZuhRmjC4jonyoZ JIYtGkptN7Jf29NV36VYZZsTHApE7NSIrk+N2uRVmmaPFwhjaeI5PXdiZ5Hz93SE8ygZcAIv1OXTO 6tffdsYp1ULZ0V6wEuKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3cVL-007XCj-Pe; Fri, 09 Dec 2022 12:29:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3cVI-007XBG-DU for linux-arm-kernel@lists.infradead.org; Fri, 09 Dec 2022 12:29:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 68FFF23A; Fri, 9 Dec 2022 04:29:28 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.39.232]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 895B43F73B; Fri, 9 Dec 2022 04:29:20 -0800 (PST) Date: Fri, 9 Dec 2022 12:29:17 +0000 From: Mark Rutland To: Mark Brown Cc: Catalin Marinas , Will Deacon , Suzuki K Poulose , James Morse , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/6] arm64/sysreg: Fix errors in 32 bit enumeration values Message-ID: References: <20221207-arm64-sysreg-helpers-v1-0-149fa1308a23@kernel.org> <20221207-arm64-sysreg-helpers-v1-2-149fa1308a23@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221207-arm64-sysreg-helpers-v1-2-149fa1308a23@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221209_042924_535173_CCD2DA6C X-CRM114-Status: GOOD ( 15.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 08, 2022 at 04:03:23PM +0000, Mark Brown wrote: > The recently converted 32 bit ID registers have errors in MVFR0_EL1.FPSP, > MVFR0_EL1.SIMDReg and MVFR1_EL1.SIMDHP where enumeration values which > should be 0b0010 are specified as 0b0001. Correct these. > > Fixes: e79c94a2a487 ("arm64/sysreg: Convert MVFR0_EL1 to automatic generation") > Fixes: c9b718eda706 ("arm64/sysreg: Convert MVFR1_EL1 to automatic generation") > Signed-off-by: Mark Brown These each look like a copy-paste error from the lines immediately above, forgetting to update the value. The updated values as-of this patch appears to be correct per the documentation. Reviewed-by: Mark Rutland Mark. > --- > arch/arm64/tools/sysreg | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg > index 184e58fd5631..e8fb6684d7f3 100644 > --- a/arch/arm64/tools/sysreg > +++ b/arch/arm64/tools/sysreg > @@ -689,17 +689,17 @@ EndEnum > Enum 11:8 FPDP > 0b0000 NI > 0b0001 VFPv2 > - 0b0001 VFPv3 > + 0b0010 VFPv3 > EndEnum > Enum 7:4 FPSP > 0b0000 NI > 0b0001 VFPv2 > - 0b0001 VFPv3 > + 0b0010 VFPv3 > EndEnum > Enum 3:0 SIMDReg > 0b0000 NI > 0b0001 IMP_16x64 > - 0b0001 IMP_32x64 > + 0b0010 IMP_32x64 > EndEnum > EndSysreg > > @@ -718,7 +718,7 @@ EndEnum > Enum 23:20 SIMDHP > 0b0000 NI > 0b0001 SIMDHP > - 0b0001 SIMDHP_FLOAT > + 0b0010 SIMDHP_FLOAT > EndEnum > Enum 19:16 SIMDSP > 0b0000 NI > > -- > 2.30.2 > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel