From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C387C4167B for ; Fri, 9 Dec 2022 14:41:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uPNKRRb8H4bKONmJFL93qrX8jdkBmis1zKuingMjUWs=; b=VyKLfTWv6vyu8t 6d8OyWoSZPUFxE3a7GRzllnX/By7wZoYXbf9lsdPw416kKoQE4HQv4gVA1MOWMPypZnAQoJEnpYuX 3WvDP/6t86d+qQgDhJ+IreyCuVU7JapLPMhOFTFAby6FmS8kEv89fNztKOUWgnUz3W/PHDiAe2cK5 1p1O5uo5qlaJEyGvfe8m2KN69zYP7sBLGeKLRZFDZrOUOpNzc1eVV2Ak9F/8D5RUrQHAzwE2J/UGO 3Mc6SUmX4HFEbNMrijB27p66rYVa1VJ/46Osi2o/emqmPS5wDF7j0o4Pnjlff37mbFft/UX7FkEni Z/FF0d45+pQQo6jgKi6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3eYE-008Wlf-EY; Fri, 09 Dec 2022 14:40:34 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3eYA-008WkX-WE for linux-arm-kernel@lists.infradead.org; Fri, 09 Dec 2022 14:40:32 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4C06C23A; Fri, 9 Dec 2022 06:40:36 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.41.252]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1CA453F73D; Fri, 9 Dec 2022 06:40:27 -0800 (PST) Date: Fri, 9 Dec 2022 14:40:25 +0000 From: Mark Rutland To: Ard Biesheuvel Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, will@kernel.org, rostedt@goodmis.org, samitolvanen@google.com, keescook@chromium.org, mhiramat@kernel.org Subject: Re: [PATCH] ftrace: Allow WITH_ARGS flavour of graph tracer with shadow call stack Message-ID: References: <20221209143402.3332369-1-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221209143402.3332369-1-ardb@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221209_064031_103523_FDE75FD7 X-CRM114-Status: GOOD ( 20.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 09, 2022 at 03:34:02PM +0100, Ard Biesheuvel wrote: > The recent switch on arm64 from DYNAMIC_FTRACE_WITH_REGS to > DYNAMIC_FTRACE_WITH_ARGS failed to take into account that we currently > require the former in order to allow the function graph tracer to be > enabled in combination with shadow call stacks. This means that this is > no longer permitted at all, in spite of the fact that either flavour of > ftrace works perfectly fine in this combination. > > Given that arm64 is the only arch that implements shadow call stacks in > the first place, let's update the condition to just reflect the arm64 > change. When other architectures adopt shadow call stack support, this > can be revisited if needed. > > Signed-off-by: Ard Biesheuvel My bad; sorry about this, and thanks for the fix! Acked-by: Mark Rutland We should probably also add: Fixes: 26299b3f6ba26bfc ("ftrace: arm64: move from REGS to ARGS") Mark. > --- > arch/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/Kconfig b/arch/Kconfig > index 072a1b39e3afd0d1..683f365b5e31c856 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -635,7 +635,7 @@ config ARCH_SUPPORTS_SHADOW_CALL_STACK > config SHADOW_CALL_STACK > bool "Shadow Call Stack" > depends on ARCH_SUPPORTS_SHADOW_CALL_STACK > - depends on DYNAMIC_FTRACE_WITH_REGS || !FUNCTION_GRAPH_TRACER > + depends on DYNAMIC_FTRACE_WITH_ARGS || !FUNCTION_GRAPH_TRACER > help > This option enables the compiler's Shadow Call Stack, which > uses a shadow stack to protect function return addresses from > -- > 2.35.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel