* [PATCH net-next] net: dsa: mt7530: remove reduntant assignment [not found] <Y5b/Tm4GwPGzd9sR@shell.armlinux.org.uk> @ 2022-12-13 4:07 ` Daniel Golle 2022-12-13 11:30 ` Russell King (Oracle) 2022-12-14 1:17 ` Jakub Kicinski 0 siblings, 2 replies; 3+ messages in thread From: Daniel Golle @ 2022-12-13 4:07 UTC (permalink / raw) To: Russell King, netdev, linux-arm-kernel, linux-mediatek, linux-kernel, Sean Wang, Landen Chao, DENG Qingfang, Andrew Lunn, Florian Fainelli, Vladimir Oltean, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Matthias Brugger Russell King correctly pointed out that the MAC_2500FD capability is already added for port 5 (if not in RGMII mode) and port 6 (which only supports SGMII) by mt7531_mac_port_get_caps. Remove the reduntant setting of this capability flag which was added by a previous commit. Fixes: e19de30d20 ("net: dsa: mt7530: add support for in-band link status") Reported-by: Russell King <linux@armlinux.org.uk> Signed-off-by: Daniel Golle <daniel@makrotopia.org> --- drivers/net/dsa/mt7530.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index e74c6b406172..908fa89444c9 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -2919,9 +2919,6 @@ static void mt753x_phylink_get_caps(struct dsa_switch *ds, int port, config->mac_capabilities = MAC_ASYM_PAUSE | MAC_SYM_PAUSE | MAC_10 | MAC_100 | MAC_1000FD; - if ((priv->id == ID_MT7531) && mt753x_is_mac_port(port)) - config->mac_capabilities |= MAC_2500FD; - /* This driver does not make use of the speed, duplex, pause or the * advertisement in its mac_config, so it is safe to mark this driver * as non-legacy. -- 2.39.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: dsa: mt7530: remove reduntant assignment 2022-12-13 4:07 ` [PATCH net-next] net: dsa: mt7530: remove reduntant assignment Daniel Golle @ 2022-12-13 11:30 ` Russell King (Oracle) 2022-12-14 1:17 ` Jakub Kicinski 1 sibling, 0 replies; 3+ messages in thread From: Russell King (Oracle) @ 2022-12-13 11:30 UTC (permalink / raw) To: Daniel Golle Cc: netdev, linux-arm-kernel, linux-mediatek, linux-kernel, Sean Wang, Landen Chao, DENG Qingfang, Andrew Lunn, Florian Fainelli, Vladimir Oltean, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Matthias Brugger On Tue, Dec 13, 2022 at 04:07:35AM +0000, Daniel Golle wrote: > Russell King correctly pointed out that the MAC_2500FD capability is > already added for port 5 (if not in RGMII mode) and port 6 (which only > supports SGMII) by mt7531_mac_port_get_caps. Remove the reduntant > setting of this capability flag which was added by a previous commit. > > Fixes: e19de30d20 ("net: dsa: mt7530: add support for in-band link status") > Reported-by: Russell King <linux@armlinux.org.uk> Please update the name and email address as per my reviewed-by below (the "(Oracle)" bit is important since I now work for Oracle.) > Signed-off-by: Daniel Golle <daniel@makrotopia.org> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: dsa: mt7530: remove reduntant assignment 2022-12-13 4:07 ` [PATCH net-next] net: dsa: mt7530: remove reduntant assignment Daniel Golle 2022-12-13 11:30 ` Russell King (Oracle) @ 2022-12-14 1:17 ` Jakub Kicinski 1 sibling, 0 replies; 3+ messages in thread From: Jakub Kicinski @ 2022-12-14 1:17 UTC (permalink / raw) To: Daniel Golle Cc: Russell King, netdev, linux-arm-kernel, linux-mediatek, linux-kernel, Sean Wang, Landen Chao, DENG Qingfang, Andrew Lunn, Florian Fainelli, Vladimir Oltean, David S. Miller, Eric Dumazet, Paolo Abeni, Matthias Brugger On Tue, 13 Dec 2022 04:07:35 +0000 Daniel Golle wrote: > Fixes: e19de30d20 ("net: dsa: mt7530: add support for in-band link status") Apart from the changes requested by Russell, could you also correct this Fixes tag to have the required 12 characters of the commit ID? You can post as [PATCH net v2], net-next has just made it to Linus and became net. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-14 1:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <Y5b/Tm4GwPGzd9sR@shell.armlinux.org.uk>
2022-12-13 4:07 ` [PATCH net-next] net: dsa: mt7530: remove reduntant assignment Daniel Golle
2022-12-13 11:30 ` Russell King (Oracle)
2022-12-14 1:17 ` Jakub Kicinski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).