From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8095C001B2 for ; Wed, 14 Dec 2022 07:55:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1aMaEPA3HaoeLozmHgyM+vDo+QpHa3uwKQ5y7++z238=; b=kI1zCHadOLBncu Vnx2NgbrG8hw5vq/VgVJuVMXNf0ut3Db/ZJ4ZrniqptwVOwvapa2BRBVyWddCbhedNad4ViYC5TCH dI9DPu3Rg9Yhm0HYnK1gozzqeOOUjIwsDpI3eb/wMfEyULylCvOhgKQ2xD7KwtWYNGqVZHsBHpW+Y giZ+Uv9qqctxZ71l/q4o6OeNP5JP9BYBx3CVnnwK/d9YyRAygpIlCkDR1E27r7QE4o1BxBNhNBXS/ M6LZcWpZisgrQMZTP6+8l/d1kj7EMYqFp3vHtJB4L5EmT5deueCKLn81Z3ZxQa/1euQEuPHDOj2Uf BDpo//7As0nCvt7Z7qIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5MbI-00EIE3-QK; Wed, 14 Dec 2022 07:54:48 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5MbF-00EI9v-Ua for linux-arm-kernel@lists.infradead.org; Wed, 14 Dec 2022 07:54:47 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A6C9E61841; Wed, 14 Dec 2022 07:54:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A5ACC433EF; Wed, 14 Dec 2022 07:54:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671004483; bh=93g2T3KhAXhgG13/7pvnSucwyl+V/l6zp5Waj7KK7fM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gfC+mMup11HUefG+BLYZD7E5ZU34eyZfbs7p82jwChzLgdsK1u/SNN+yXJ4YH/oG8 u9UjygaxxLPV9j62vwdHENFRfUXH/cJgvDp1KJW4Oc69D9iPF37AVGE0hFXgDVs+5M p9ckSE6LbT6sVnuHMXTXZ8ZRKchKQebV2I0w5svRcuwWeqeb3PbHTFeknRt79+fxpx Mwisdjb3BYIhZSYdyJHqk2jfvo5+f2jXDpcMUgzo3CpZlWxGOgCW4yV6U9mTpG5sBI Us3e2cNwZny8hcOHs1gtRLoDHKLfFAY8/5xrhhLclkpffwRfAbB8mYkibWHqzSRufp IdA91KOOF8vFA== Date: Wed, 14 Dec 2022 09:54:38 +0200 From: Leon Romanovsky To: Gaosheng Cui Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, boon.leong.ong@intel.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] net: stmmac: fix errno when create_singlethread_workqueue() fails Message-ID: References: <20221214034205.3449908-1-cuigaosheng1@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221214034205.3449908-1-cuigaosheng1@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221213_235446_046702_9666F5B4 X-CRM114-Status: GOOD ( 12.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 14, 2022 at 11:42:05AM +0800, Gaosheng Cui wrote: > We should set the return value to -ENOMEM explicitly when > create_singlethread_workqueue() fails in stmmac_dvr_probe(), > otherwise we'll lose the error value. > > Fixes: a137f3f27f92 ("net: stmmac: fix possible memory leak in stmmac_dvr_probe()") > Signed-off-by: Gaosheng Cui > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 + > 1 file changed, 1 insertion(+) > Please change title of your patch to be "PATCH net" Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel