From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF484C4167B for ; Wed, 14 Dec 2022 08:11:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=58a9txmU7C1jUZIvfaLFzcU+N2sVMg11j7rYr3bZkA0=; b=PadMD99V5xdfOl d3c8TUaIHN7WgC/Wl14MuTj6wMmVUDRDUEOmfHZN+DVjlrJyxSAkSuo0vVtncNSAFLslBVlBrBNoy hm8M2uUVZwpFozlnmYUf5nORHK/L4BWl+94x7lmFbWz19UhkDhwO93XiI7JcQ3rO1KKdKSxvs0I4f nXRZQR2OHOFCZ1KAczX+Q+f66Yypu8A5GtujL5Dag/71G2fNzJzDJ0jul9ZPEp0GzmcuZGMCdbJZ3 Si5OGxI5qTaxGaEJxhNJTNvsP6F1tQw0/DYf8Kli7DwdUswByfW+yZKCbk5HMYDXrNHMfiMdG9nZk CxzXRmCwUHFW76AsAC+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5Mqh-00EQ8w-HO; Wed, 14 Dec 2022 08:10:43 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5Mqe-00EQ7m-SN for linux-arm-kernel@lists.infradead.org; Wed, 14 Dec 2022 08:10:42 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 340CCB81636; Wed, 14 Dec 2022 08:10:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15BD8C433EF; Wed, 14 Dec 2022 08:10:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671005437; bh=+zeXN5WosSUBbyyksAsVntvHbGVEsx9KgPHCEaV47NU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V+3cDGjLFdTIIVZSXUTZNjn58MwVidDTAFPnff9rXCEMo1dyIq9fMJn8N9UoVQ5I8 P8/rjIAjfLEIhwDy9KngMMUQLU6oxytvWUlhlx28vuF76gTkX8JYTlUDDJocpp7jQ1 pTPXxJppunVcUSVxAXFGQa1YB50DS01v3LFOkMR0ozekMRwqyyg8nBcx5Wf11rl1ms 0kEnK1VKywrDCDJvuRF6DLh9JztADRZ74NQjnO6cnKPDw7zzBQ1FTNaPByNMQqxulS 9blt93uIzwXBJyZcqa1JTUEUusBDCkUCkE4g8kjg4wkhEjk8D8Yu/Udm3NlNVD+eMh AYleLAIjcEeXQ== Date: Wed, 14 Dec 2022 10:10:33 +0200 From: Leon Romanovsky To: Gaosheng Cui Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, boon.leong.ong@intel.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net,v2] net: stmmac: fix errno when create_singlethread_workqueue() fails Message-ID: References: <20221214080117.3514615-1-cuigaosheng1@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221214080117.3514615-1-cuigaosheng1@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221214_001041_085268_86A28FE7 X-CRM114-Status: GOOD ( 13.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 14, 2022 at 04:01:17PM +0800, Gaosheng Cui wrote: > We should set the return value to -ENOMEM explicitly when > create_singlethread_workqueue() fails in stmmac_dvr_probe(), > otherwise we'll lose the error value. > > Fixes: a137f3f27f92 ("net: stmmac: fix possible memory leak in stmmac_dvr_probe()") > Signed-off-by: Gaosheng Cui > --- > v2: > - Change title of this patch to be "PATCH net", thanks! > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 + > 1 file changed, 1 insertion(+) > It is so shameful that on Fixed commit, my tag too :(. Sorry about that. Thanks, Reviewed-by: Leon Romanovsky _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel