From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70240C4332F for ; Thu, 15 Dec 2022 08:00:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hgs6/004sDfCj1bfyJT9h0+Z/XH4Js/PzQGEXbCHzgY=; b=XejzzH7vIDvh2U Gl9sRKWQzvhm3ZEPzfDc7bfGFz0zy+55xSpyE+SAP7ZPAWUR3EpBZ573xU5ZB+MzSCTufmhsoNIqw aMHv4WY28nN2nvF35/kV2A2XKW1vErNIyAgPslrxR7LED5u2PHRC+HHEkxrxtONBScBXPu87ewV8b 32mb0AgipZNe+bfmyX+R3xwblL5umpnPC/CXc67Mbxk52GENUnWLxzy0Ie1TTlcVYaIcB8PvC9dBo 7nqdYbSo5Y3UtzKLOfrRt+ip8q4CCgFy2agNGPBiCi/Pv4Q1MItkBeog6BWmemT+qg66pzJFgiqX2 W2b901shj0rXJKSizEiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5j9h-007S4b-Or; Thu, 15 Dec 2022 07:59:49 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5j9e-007S0F-1y; Thu, 15 Dec 2022 07:59:47 +0000 Received: by mail-wr1-x432.google.com with SMTP id bx10so2230917wrb.0; Wed, 14 Dec 2022 23:59:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KX0PWE2xH1wSf/y+zwbZJi36dKHohqN+VlC//8Gj03Y=; b=CRXXChB9RPUbelebK5Wi627ibXjWXRYZrVQK9fV7JL2upp00d1sz8VO5aqxykceunt z6Waxut3u1vjPaKhvIs5yya2XbkvBN+azS6J1pViAiWoSwz21h7DqKd520x/txMPZ2o8 seoMqz/JKzPxzKyooayFzlm03v1REqNISxqHdRCZg+2JTyjzVAKy2TBrAgafuwPjnobL 3GLWti82hybD3IhVMxbQP7b0IJ2BSvsBrd2OAuRTIklJncrocTtiBv3TMV+Wa8NBGsZV xNX1p2t6WdXMyvg6LpMbSatM8M78rT9ZvbCLr6De19ezXIpPVukdRzNWm+YaJnydIPsN UV2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KX0PWE2xH1wSf/y+zwbZJi36dKHohqN+VlC//8Gj03Y=; b=QpOf9rV9jm8ucjZBmif0q0lnZF2yfKuX7ARKj/4ZEvMg3hpX7tMcfnJwAzPRFI7KQf cbjLHKFQ7OCcPeSzf+wVtSgYnKFpriDTu94WrOfJV2UkzgHSBaUaIMsetE2rj0b14LoO OGOguX/hA029PEfdg/YnzrDnSJi+JxQspNNNvIU007kOIyToH9bYUyUSaUFRQ06bVgfb cDgYcU8kj/OvVq2v/SlLhoVyebEhQZIzaZvb8MnZUMqIZAnGJkXGrAA1JvG4YVIWJf3e qCe3ZCM8AlFJoYZn+XFsvn4dutt17jM8uGeCk+rqo8JMrGCwZVwcGCaCr9TUYkQt8f6n 2Oxg== X-Gm-Message-State: ANoB5pmr0VDmp70pOWEKZQOcJofcF6APXcH1RaZ5w+oSvb6reBrr3V8/ JZc/rpkckdfVAqQF2saQKoY= X-Google-Smtp-Source: AA0mqf64n9wNAGf4SoZErGss2bZlF+akwx2ZmjXfqJnjEXlBPkfi6KoVksXeh4Nx+Kjh9mK3UgjFxg== X-Received: by 2002:a5d:4e82:0:b0:242:7139:601a with SMTP id e2-20020a5d4e82000000b002427139601amr16180937wru.28.1671091183130; Wed, 14 Dec 2022 23:59:43 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id h9-20020a5d5489000000b00242109cf587sm5134961wrv.28.2022.12.14.23.59.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 23:59:42 -0800 (PST) Date: Thu, 15 Dec 2022 10:59:30 +0300 From: Dan Carpenter To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook , Stefan Wahren , Greg Kroah-Hartman , Florian Fainelli , Adrien Thierry , Dave Stevenson , Kieran Bingham , Laurent Pinchart Subject: Re: [PATCH 5/7] vc04_services: vchiq_arm: Drop VCHIQ_RETRY usage on disconnect Message-ID: References: <20221215065853.34477-1-umang.jain@ideasonboard.com> <20221215065853.34477-6-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221215065853.34477-6-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221214_235946_135346_9D0BA353 X-CRM114-Status: GOOD ( 12.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 15, 2022 at 12:28:51PM +0530, Umang Jain wrote: > Drop the usage of VCHIQ_RETRY when the vchiq has connection status > VCHIQ_CONNSTATE_DISCONNECTED. Disconnected is will not be valid to > carry on a retry, replace the VCHIQ_RETRY with -EINVAL. > > This patch removes the usage of vCHIQ_RETRY completely and act as > intermediatory to address the TODO item: > * Get rid of custom function return values > for vc04_services/interface. > > Signed-off-by: Umang Jain > --- It sounds like this should have a Fixes tag because the original behavior was wrong. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel