From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB984C4332F for ; Thu, 15 Dec 2022 18:13:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yYqlfAtg9IHYpNivV32yFJ3mQ117uy9sja2iYXbVB/U=; b=P3W/XiwUTIKunv G0c1g6umnVLO33F+2ujJcYcLsXAbp0t+PMndY8nx5kHCCkSBclQ/lIKuofhQl+GSxnYDDU5DHM/8o DpqajZlA1B2jeEcZtyiWVEB5p/ZlBPv7NRPpYkvzBnityayQRZDRAVzsM/QuPJPaboAhxuSmSWfKX jiz1KH8G3cyjFoJZnZvvt1n4uy1a4Cj9ta3EpOdDiY/uV3gRhEkrhNPoQqCDZBb2JhhH5C5BOpaaR c/aSLoa1DihSr1WqL+C76W2PCormcstyRmsANlOsHnMuAymLQkyZEEeE7sfSSWcebk9ka+SvsIQ9I 17J2gxHQWkJgSh1rxgjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5sid-00AmOS-Ag; Thu, 15 Dec 2022 18:12:31 +0000 Received: from out2.migadu.com ([188.165.223.204]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5siZ-00AmNA-EB for linux-arm-kernel@lists.infradead.org; Thu, 15 Dec 2022 18:12:29 +0000 Date: Thu, 15 Dec 2022 18:12:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1671127939; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NR0RL3zpixZswsWefFQZYtOaaPkMaQgei0oRBq1daFM=; b=hLEvw7pLYE0dgSwnXDsnPKUS/uso1iZ7ESDgITzTMi7HhtQpedIxSSY9l8NGreYhOa95Wh Y6Qibd87eoQzB6BqcrAwtwJOw/KYydgFlCGkjGuBaw/dAc/htmNEZhlb/rik0/OKLVI/wR sHdAsAC00DylzFzKaZ+tZRm0pxM3oMw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Ryan Roberts Cc: Marc Zyngier , Catalin Marinas , Will Deacon , Ard Biesheuvel , Suzuki K Poulose , Anshuman Khandual , James Morse , Alexandru Elisei , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu Subject: Re: [PATCH v1 00/12] KVM: arm64: Support FEAT_LPA2 at hyp s1 and vm s2 Message-ID: References: <20221206135930.3277585-1-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221215_101228_508225_D06B7094 X-CRM114-Status: GOOD ( 30.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 15, 2022 at 09:33:17AM +0000, Ryan Roberts wrote: > On 15/12/2022 00:52, Oliver Upton wrote: > > On Tue, Dec 06, 2022 at 01:59:18PM +0000, Ryan Roberts wrote: > >> (appologies, I'm resending this series as I managed to send the cover letter to > >> all but the following patches only to myself on first attempt). > >> > >> This is my first upstream feature submission so please go easy ;-) > > > > Welcome :) > > > >> Support 52-bit Output Addresses: FEAT_LPA2 changes the format of the PTEs. The > >> HW advertises support for LPA2 independently for stage 1 and stage 2, and > >> therefore its possible to have it for one and not the other. I've assumed that > >> there is a valid case for this if stage 1 is not supported but stage 2 is, KVM > >> could still then use LPA2 at stage 2 to create a 52 bit IPA space (which could > >> then be consumed by a 64KB page guest kernel with the help of FEAT_LPA). Because > >> of this independence and the fact that the kvm pgtable library is used for both > >> stage 1 and stage 2 tables, this means the library now has to remember the > >> in-use format on a per-page-table basis. To do this, I had to rework some > >> functions to take a `struct kvm_pgtable *` parameter, and as a result, there is > >> a noisy patch to add this parameter. > > > > Mismatch between the translation stages is an interesting problem... > > > > Given that userspace is responsible for setting up the IPA space, I > > can't really think of a strong use case for 52 bit IPAs with a 48 bit > > VA. Sure, the VMM could construct a sparse IPA space or remap the same > > HVA at multiple IPAs to artificially saturate the address space, but > > neither seems terribly compelling. > > > > Nonetheless, AFAICT we already allow this sort of mismatch on LPA && > > !LVA systems. A 48 bit userspace could construct a 52 bit IPA space for > > its guest. > > I guess a simpler approach would be to only use LPA2 if its supported by both > stage1 and stage2. Then the code could just use a static key in the few required > places. Ah, you caught on quick to what I was thinking :-) What I'm groaning about in particular is the changes to the TLB invalidation path, as it feels like a static key is warranted there. Nonetheless, it is all a bit of a mess depending on LPA2 support in both the kernel and KVM. -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel