From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D91F8C4332F for ; Tue, 20 Dec 2022 18:57:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jCbjtT+ZgS2tMls50c2S7EYb/oivt+8t2uzXNLYZ2nk=; b=SKjIFcoU5Cx7rE 5M6Iowxvy24C8xfnoCaIwx6KEkfyHWZxNe9JT99ebLZk5yqnl47cISU+mu3rrIIsMfUtQnlbXAVED Hw6npe0FSxvF7cEPlo7s7OqzkUqZ95kHlTx5hiMtjUhHbF04Wn2w2BZxEfFzlkuYEkks0IMcLDLlz qoNCNipC+il9F8unaaxQRF0YgpjIcbBxvsrNMJuDnyvmU4b4Rk3TQpHefCt8G+ZiEVLbVKzarlPjN nCtZNGKix1ibF/+1bPyPppwB1qM0yTT4DA+ZfK3ovUluHzuH8sSCF2m8T5VJDMrla7yqWxsnEX6tO Bbnuskh0WzZlYgMoTXqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7hm8-002wjW-NK; Tue, 20 Dec 2022 18:55:40 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7hm5-002wZ9-BY; Tue, 20 Dec 2022 18:55:38 +0000 Received: by mail-pl1-x635.google.com with SMTP id d15so13188510pls.6; Tue, 20 Dec 2022 10:55:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sXGgkWFMp3OYd+RGGfsh3gEVvYrFeFbPd9DXXHvfsjQ=; b=ZgsnDg1f1DNDu3MgDBR3XN53JFItQCKtWD8HtQlnIwzB98ZfS/XDhuiOZhSBOK8Uay ezFCq7qaaQO10tN6Xwww3ps4dqqV38QWRObXkZ/yV2ohMfNY2LRHuAGJORJpGji9l0eM orua+wVlR76QibMP+A8uEVAmOCvAmasYP7nWm24tEL8sMtrwwZCh1k9G0+OkN1nHqUs0 ekofGjdiIOnq+1HECH/llMXhhVbnsfjBKdjiMvD/OaFYSnsz+83HRMwP+oFvOH2zau4n BYimmUK2eY0ObMzfbVtoAeb0wXuhK7Dm8j99AIL17uCULJ6o18rHf4dt/aR4BA0AKK0H v8kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sXGgkWFMp3OYd+RGGfsh3gEVvYrFeFbPd9DXXHvfsjQ=; b=Y3I8rEw2/rPmP5N83gff8dZUaMNicEFGExRqfHMXZNt9Etmtpu0PdTlNPt8vwEX8Uk O9kAKuA1hLGkfe1YI/gqjroo9N5OO2UidJ+wv9kWhRuivmSHT24fnTxZke5DQVlsNCNA DC029sc3wg0cLmGYe+O0OzEhVyqwKdvB27mXl0+t+nE0Ikrc2uIWomol7z82hD4V0gXz 0e6W3PVbZKRaKD4O5kNmlbrLf9QXlcSNGtd8PKdKqypaDzJ7fjk5pW2z2mfLBwJJaGJj aWyXx7ixU9HAabHvvQr3zXMy6/LwFU1eUwAmY/IE09K4UkEwtzYesY/HKt0PECNXA3r3 t9TQ== X-Gm-Message-State: AFqh2kr+zG3BMbFBQ6YNmjx5B/Ll0v1q5ljj116wZjF6gr07NJS3qi/Q rsyhP51rboJCXGxR5zucWs4= X-Google-Smtp-Source: AMrXdXuu1a9NYzQV1O5vigsN0o5UqEJeUN2vzKdV1ann8aOQ2vVRrmffGmZ7gpynQ7wpBZc6VC/EIQ== X-Received: by 2002:a17:902:7613:b0:18f:9b13:5fb9 with SMTP id k19-20020a170902761300b0018f9b135fb9mr13274425pll.60.1671562531357; Tue, 20 Dec 2022 10:55:31 -0800 (PST) Received: from google.com ([2620:15c:9d:2:7206:404e:4820:d175]) by smtp.gmail.com with ESMTPSA id i18-20020a17090332d200b00188ef3ea2b6sm9700453plr.262.2022.12.20.10.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Dec 2022 10:55:30 -0800 (PST) Date: Tue, 20 Dec 2022 10:55:27 -0800 From: Dmitry Torokhov To: Miaoqian Lin Cc: Florian Fainelli , Broadcom internal kernel review list , Rob Herring , Nicolas Saenz Julienne , Eric Anholt , linux-input@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] input: raspberrypi-ts: Fix refcount leak in rpi_ts_probe Message-ID: References: <20221220115246.1522054-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221220115246.1522054-1-linmq006@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221220_105537_425540_BCA2F7BA X-CRM114-Status: UNSURE ( 9.92 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 20, 2022 at 03:52:43PM +0400, Miaoqian Lin wrote: > rpi_firmware_get() take reference, we need to release it in error paths > as well. Add missing rpi_firmware_put() in the error handling to fix it. Hmm, it used not to take a reference, but now it does... OK. But I see there is devm_rpi_firmware_get() variant, we should be using it instead of mixing up manual and devm-controller resources to ensure proper release order. Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel