From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DCF7C4332F for ; Tue, 20 Dec 2022 21:40:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yxqOQLrPh4bFnuboh5WCPtre+kIJihn/fsguksXd4QE=; b=OxphgRBdBhf9Sx EbnElJhV++vln/8b3uKuT/Ef6f+GCWSnmf4/6MLrc9j/2XGNIsQTdszjCamwp0E+RYAchRKDZ4Euz MqlZwaHjFmmleiTlx3bnZel8NBTlQhg4Ifv1IVbGpkBeepQNZlyjGLb2tOrod6Nv2v03+T2fU/czg DviwOwsfP8r/DWOFeVJjtvtFtlKrJtNMFMnfAlT71zwG5Z3mGTY46NryTHOiqs+mbu2aopI2hNFef JjA9R7Q7eMiZYqfO6hlyJ8bdzZ//NugDgXdL+ZF7zw4GSxWKSD9Q0oQlwHV+/AqLMd6OgQtq0MAQJ K0jFSgrsRiPKOcZF+vCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7kK3-004Tcg-Lj; Tue, 20 Dec 2022 21:38:51 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7kJe-004TNv-0n for linux-arm-kernel@lists.infradead.org; Tue, 20 Dec 2022 21:38:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671572301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=knEFZp/Br2lwUYLZXfbzI9ZSnZOaTBCXhLfkLB5psow=; b=FiZD8zN1N11GLCKv5QYxsf2gAwLIFgoVrKVzE9h1nUXoX919qzAaqfFfbDqjuAx3ndUpEy RNqh+AWjgJSSd1oJhVXhl9m+e1cQPHq0Rr7mQaH0LHhaRes/YO7CEPTSpB53vFR7HDdpYh DIuYpTnGTmpwn19W9XZ+65oegX0cIZI= Received: from mail-yb1-f199.google.com (mail-yb1-f199.google.com [209.85.219.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-49-dyp6N-oJOSOc5EaP_iKLvw-1; Tue, 20 Dec 2022 16:36:24 -0500 X-MC-Unique: dyp6N-oJOSOc5EaP_iKLvw-1 Received: by mail-yb1-f199.google.com with SMTP id h66-20020a252145000000b0071a7340eea9so15404337ybh.6 for ; Tue, 20 Dec 2022 13:36:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=knEFZp/Br2lwUYLZXfbzI9ZSnZOaTBCXhLfkLB5psow=; b=AdvO3Okbyd0MyUoAVJoX30xESL10iUbUJGadEL6b0c9wqZEcTK64msSjIOC5z8lkhA 21CnrdxSiCJFqqR52eIdMB+OFHZTqzxtr+83CFy1B2woytO/NsejJOz40q8GTiYNEXvv 8lekPhatsDSoCqKNsR5yH+mVQXwgOG8ntGZtR6+wZ6AcOxBKzoK7heW3T4Rlr0FhC6I9 sB+Ownr3O4kJ41GST+OBEWnh+oE61IerClJ/ypm2u+l2hZKHqQK/9U3WzBP7igAI2WO6 01Ve94qsCxXI0QPYlX+IJYlAHry9QbVTb8qUfzSNkUxJBgYF/QNPLUQQx6iHvPz9j35u /fpw== X-Gm-Message-State: AFqh2kpHyG751WJu/uS7AYqAyJE53EzCefW3JP7M4yShM3mt+fkxgZzw pkU/dKbkejcuHe9dnynz71E+KxGN9LWwFYiHjYPybJWrVpN70YExL6utse3c215RAupCOLDHSs1 pKvsxbtER/zHfkdkowYl/dhOExkuo5/7dcrE= X-Received: by 2002:a25:1341:0:b0:750:1a06:a065 with SMTP id 62-20020a251341000000b007501a06a065mr3477895ybt.27.1671572183838; Tue, 20 Dec 2022 13:36:23 -0800 (PST) X-Google-Smtp-Source: AMrXdXsPohFHhtEKKvf6gK73YNmbJSdo8yOT0tgD3pKborKAYbk0JfGgQt+ZczDVgb1x59kgQv6r9Q== X-Received: by 2002:a25:1341:0:b0:750:1a06:a065 with SMTP id 62-20020a251341000000b007501a06a065mr3477861ybt.27.1671572183536; Tue, 20 Dec 2022 13:36:23 -0800 (PST) Received: from fedora (modemcable149.19-202-24.mc.videotron.ca. [24.202.19.149]) by smtp.gmail.com with ESMTPSA id u25-20020a37ab19000000b006feea093006sm9457393qke.124.2022.12.20.13.36.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Dec 2022 13:36:22 -0800 (PST) Date: Tue, 20 Dec 2022 16:36:20 -0500 From: Adrien Thierry To: Krzysztof Kozlowski Cc: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Kevin Hilman , Ulf Hansson , Daniel Lezcano , Lorenzo Pieralisi , Sudeep Holla , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Brian Masney , linux-rt-users@vger.kernel.org Subject: Re: [PATCH v2 0/5] PM: Fixes for Realtime systems Message-ID: References: <20221219151503.385816-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 In-Reply-To: <20221219151503.385816-1-krzysztof.kozlowski@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221220_133826_204242_6E9ABA46 X-CRM114-Status: GOOD ( 12.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, Thanks for looking into this! I tested your patchset on the QDrive3 on a CentOS Stream 9 RT kernel (I couldn't test it on mainline because the latest RT patchset only supports 6.1 which is missing some bits needed to boot QDrive3). It fixes the PSCI cpuidle issue I was encountering in [1]. However, I may have found another code path that triggers a similar issue: BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:46 in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 113, name: kworker/4:2 preempt_count: 1, expected: 0 RCU nest depth: 0, expected: 0 4 locks held by kworker/4:2/113: #0: ffff09b0c2376928 ((wq_completion)pm){+.+.}-{0:0}, at: process_one_work+0x1f4/0x7c0 #1: ffff800008bf3dd0 ((work_completion)(&genpd->power_off_work)){+.+.}-{0:0}, at: process_one_work+0x1f4/0x7c0 #2: ffff09b0c2e44860 (&genpd->rslock){....}-{2:2}, at: genpd_lock_rawspin+0x20/0x30 #3: ffff09b0c6696a20 (&dev->power.lock){+.+.}-{2:2}, at: dev_pm_qos_flags+0x2c/0x60 irq event stamp: 170 hardirqs last enabled at (169): [] _raw_spin_unlock_irq+0x48/0xc4 hardirqs last disabled at (170): [] _raw_spin_lock_irqsave+0xb0/0xfc softirqs last enabled at (0): [] copy_process+0x68c/0x1500 softirqs last disabled at (0): [<0000000000000000>] 0x0 Preemption disabled at: [] genpd_lock_rawspin+0x20/0x30 CPU: 4 PID: 113 Comm: kworker/4:2 Tainted: G X --------- --- 5.14.0-rt14+ #2 Hardware name: Qualcomm SA8540 ADP (DT) Workqueue: pm genpd_power_off_work_fn Call trace: dump_backtrace+0xb4/0x12c show_stack+0x1c/0x70 dump_stack_lvl+0x98/0xd0 dump_stack+0x14/0x2c __might_resched+0x180/0x220 rt_spin_lock+0x74/0x11c dev_pm_qos_flags+0x2c/0x60 genpd_power_off.part.0.isra.0+0xac/0x2d0 genpd_power_off_work_fn+0x68/0x8c process_one_work+0x2b8/0x7c0 worker_thread+0x15c/0x44c kthread+0xf8/0x104 ret_from_fork+0x10/0x20 This happens consistently during boot. But on the mainline kernel, this code path has changed: genpd_power_off no longer calls dev_pm_qos_flags. So it might not happen on mainline. I hope to be able to test your patchset again soon on mainline with the next version of the RT patchset (which should be able to boot the QDrive3). Best, Adrien [1] https://lore.kernel.org/all/20220615203605.1068453-1-athierry@redhat.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel