From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58C92C4332F for ; Fri, 23 Dec 2022 10:40:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rGND7n5M8G2GNwNQYRw6nMkTrezTGww4gAgDvrYJwPc=; b=i5hbimrAqohMG1 gWIBX/ymjbY0H7fe5y03MgpqTx3qGwTF9B34KWBZblencNym+N8Spdd0cC0coJR4Vf7rdU1Xp3Quy kelJFzebxua7aHTL8NRBavEzYlO1L7ouxmzNuepJZFsV2MxiOefRXQky5sD4h74gcPkMX76p+iG/o 3kI+yVbas5cTd46rE6IcHrquEggmjDq91pbPlO9laNDI2MV4uiIeTbTe78W/EKbtQZeL/c0uUQBC2 JKaPGYSHgzrZgt8pBMPg1zJRvfIpnRGSB21NbRFeO2ezZb+h+zLiP7nyOOWihBYhQSU7d39mpQZEs 6JB8Y4mJMEZOY7ZW2bNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8fS7-006WJh-1o; Fri, 23 Dec 2022 10:39:00 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8fQn-006VIv-IH for linux-arm-kernel@lists.infradead.org; Fri, 23 Dec 2022 10:37:39 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8FA391FB; Fri, 23 Dec 2022 02:38:13 -0800 (PST) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 84DD53FA32; Fri, 23 Dec 2022 02:37:31 -0800 (PST) Date: Fri, 23 Dec 2022 10:37:25 +0000 From: Cristian Marussi To: Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com, Rob Herring , devicetree@vger.kernel.org Subject: Re: [PATCH 4/5] dt-bindings: firmware: arm,scmi: Add support for syspower protocol Message-ID: References: <20221222183823.518856-1-cristian.marussi@arm.com> <20221222183823.518856-5-cristian.marussi@arm.com> <3d89e135-c8e4-ede4-950f-03900a660822@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3d89e135-c8e4-ede4-950f-03900a660822@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221223_023737_707563_99D6930F X-CRM114-Status: GOOD ( 21.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 23, 2022 at 11:11:27AM +0100, Krzysztof Kozlowski wrote: > On 22/12/2022 19:38, Cristian Marussi wrote: > > Add new SCMI Syspower protocol bindings definitions and example. > > > > Cc: Rob Herring > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Cristian Marussi > > --- > > Got lost in translation probably...from txt to yaml > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > Hi Krzysztof, thanks for the feedback and sorry I posted with an incomplete Cc list. > > --- > > .../devicetree/bindings/firmware/arm,scmi.yaml | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > index 1c0388da6721..f3dd77a470dd 100644 > > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > > @@ -111,6 +111,12 @@ properties: > > required: > > - '#power-domain-cells' > > > > + protocol@12: > > + type: object > > + properties: > > + reg: > > + const: 0x12 > > + > > Why? It did not got lost, it's already covered by pattern. If you refer > to particular warning, please paste it in commit msg. Otherwise it looks > incorrect. > Yes indeed, but as a matter of fact it seemed to me that we used to add an entry and an example for all the currently published standard SCMI protocols, even though already covered by the patternProp (which covers also any custom-vendor protocol in the wild) and not sporting any additional custom properties (see protocol@18), but maybe this is just a unneeded wrong habit adding only cruft to the bindings. If you think it does not add any value I can happily drop this, or limiting the addition just to the example (and/or drop equally the unneeded protocol@18 node too in this case). Thanks, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel