From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A550C4332F for ; Fri, 23 Dec 2022 15:26:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vl29SLpWnGQcWOEptsxAMAfQIF1D33FbOCWgSqmG3nA=; b=q5L3ZoCWR0BuMm rfEEGt6SED0+z4dlFBZhVOK+38HrnU5WEOpoWqiNN3DZFT5BdmpoHJoxWXyPomdwTnXIFiNkG4Zeo 81Hy4/6NyejV0ejj+/7vUNnlwf5KR5Fmh29EleWL/yLel/jlFYg0q4sAm/qrU8IGe7fjq2WvmsV8i oANaOuolLQ/Ec+i+vWApXfTBmjpXDhihIjZBPOYrDdq++vP/MKXNb5nxSktgj66ISc05mu+Uxr6bu Yp6NtucpYCvMY9GZu7cooUgtOT1X8457qnmxxP+vneDgWDF8BF7Kx8SX8wsbJ+qDltIlM/dmNIvSr WYOSQpj/ae3I6RfyT0Iw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8jvP-009PMX-2x; Fri, 23 Dec 2022 15:25:31 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8jvK-009PK8-JX; Fri, 23 Dec 2022 15:25:28 +0000 Received: by mail-wr1-x42c.google.com with SMTP id a17so4846020wrt.11; Fri, 23 Dec 2022 07:25:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=I02zLCc3L9Vr4Pgf+3/wKwOrK6n4hccBX4ktlYit2UY=; b=c4m4X9M/xPPNj/v8+Kkf5y5+5BSX4GZSZ2151sK2+8N+AEWubxmGRYPTrRLPrHKElv e3720UnRSAhwxH7PGsgPDAqmEm+A8uZcvWt19GfXhy0ZCjkZyG5V834cyKAL/EyMSiwn FRShKo9mDwO2MF/lxe6pUFP8z8QpE5mZfjXidStD8FXbA//Wsm9XHewUxgfOFso9EJ01 7o7LXeAuxs5ClqlWHoKIEKEDgAMf/QZekAHdn0vh4XMjbY0+LKrpDBq/FqZbH45YCTZd /N4X9FuPGcF6vKF+tWQ5xCsy5RrVKS7S72SrHz0f07vUuWTe9uOZMcisYIX4w2vgTylq V7pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I02zLCc3L9Vr4Pgf+3/wKwOrK6n4hccBX4ktlYit2UY=; b=Ht5S/Z9tiMO0PU7V4MiTlsTaKUl3Iji3/3M7PlI0fIrfXV/SeJ7BK99GrDBsNTas0M IFm9Fb27s5nR0/vJ2udifOGjp/VOsUeF5xm0kXIKx99wOAsaibeKv8cEXMv6l/IEKvsW U88u1adYtI51cIQcC9jfG6a8j6k2D6TQmTl6iR0ryaW8qD1/B+d3JPTCgRvTe/fRTc+8 xwkjX9YnNj0t0+lug9GDj41SSZp/WlFFle0RtWze0eF+IJGGtsfi6pufc0smUu/IN+io BfSqgv//OSdZDW9ksvr9LxjyNCpmDQYhDizz1w6DOD1Uy9MEPxmRcDCp97hIrlMCUDiI S/4A== X-Gm-Message-State: AFqh2kqmWHwhZrlxNx80Bku1yKeqACjNHzH7pmDVfKwZ9fOiBnggMMoI 9IX6eqpsZbB3gzZZzx1mzDM= X-Google-Smtp-Source: AMrXdXtuhXBuZ5KqjB11un5Uda/BfZM3z+g/fpqt+KxkiSy1KgNZR1aeMy4s9hQ0phETTkGG2JhVBQ== X-Received: by 2002:adf:f04d:0:b0:268:2ab2:baa4 with SMTP id t13-20020adff04d000000b002682ab2baa4mr6416249wro.54.1671809122439; Fri, 23 Dec 2022 07:25:22 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id i13-20020a5d558d000000b00241e5b917d0sm4013973wrv.36.2022.12.23.07.25.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Dec 2022 07:25:21 -0800 (PST) Date: Fri, 23 Dec 2022 18:25:18 +0300 From: Dan Carpenter To: Stefan Wahren Cc: Umang Jain , linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook , Greg Kroah-Hartman , Florian Fainelli , Adrien Thierry , Dave Stevenson , Kieran Bingham , Laurent Pinchart Subject: Re: [PATCH v2 5/7] vc04_services: vchiq_arm: Drop VCHIQ_RETRY usage on disconnect Message-ID: References: <20221219115725.11992-1-umang.jain@ideasonboard.com> <20221219115725.11992-6-umang.jain@ideasonboard.com> <8fcbdf54-98ae-6a06-ecaf-591a43b863a1@i2se.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8fcbdf54-98ae-6a06-ecaf-591a43b863a1@i2se.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221223_072526_920847_12D46850 X-CRM114-Status: GOOD ( 20.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 22, 2022 at 12:07:56PM +0100, Stefan Wahren wrote: > Hi Umang, > > Am 19.12.22 um 12:57 schrieb Umang Jain: > > Drop the usage of VCHIQ_RETRY when the vchiq has connection status > > VCHIQ_CONNSTATE_DISCONNECTED. Disconnected status will not be valid to > > carry on a retry, replace the VCHIQ_RETRY with -ENOTCONN. > > > > This patch removes the usage of vCHIQ_RETRY completely and act as > > intermediatory to address the TODO item: > > * Get rid of custom function return values > > for vc04_services/interface. > > > > Fixes: 71bad7f08641 ("staging: add bcm2708 vchiq driver") > please drop this fixes tag since this commit doesn't fix a real issue and > also shouldn't be applied to stable. I asked Umang to add the Fixes tag based on the patch description and based on that it seemed like a behavior change just from looking at the patch. But actually you are right that the fixes tag is not required. The vchiq_send_remote_use() function is never called (dead code). The vchiq_send_remote_use_active() function now returns a mix of custom error codes and negative error codes. (Ugly). The caller only tests for VCHIQ_SUCCESS so this code does not change behavior. I really feel like the commit description needs to be clearer on this. The fixes tag is not really about stable. Stable uses the tag, but the fixes tag is appropriate whenever there is a bug fix. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel