From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96238C3DA79 for ; Mon, 26 Dec 2022 21:25:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=51h/QsrSPc69bModQ54e/Fx3/QrMDbePiLTb74OrD8c=; b=H6dp7w94rYPnoo QSvd4OTaLbv2ETW19uitl82NboNcnOmjB9F/Y27k85XAh8fBfjDK+uI0BOe+3am1k3LRWtcn/Fc1A jJ/1rZ1K7AlnZxoXKRIdCh0htXsrf5uq74mcoHEAK+eu2+zMg7Qw+uLAVhtNfMO8VB1f2Cq2eUHTu xONyxU+cXg0Iwq2JVmIXEXunT27H3SBIfnrBQTnYaeHdKR81cRoD1JctpuUkU3hloxDeWNz0mvI/M mfIVAK/zmH3IVjC7SMQpQqQxL0e7Tj+rfDCvpDbAweFy80vESEBAlMejOWnsydWFYYbjNW8xKpg2L TUADq0mA9QgApdZkC4rw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p9uwd-007Sf3-Mk; Mon, 26 Dec 2022 21:23:39 +0000 Received: from mail-ot1-x331.google.com ([2607:f8b0:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p9uwZ-007Sap-0V for linux-arm-kernel@lists.infradead.org; Mon, 26 Dec 2022 21:23:37 +0000 Received: by mail-ot1-x331.google.com with SMTP id k44-20020a9d19af000000b00683e176ab01so2300260otk.13 for ; Mon, 26 Dec 2022 13:23:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ti7gNQ0joFnwn5bt+CZWp7BNKSVRmg7a1dGHdw6oaqs=; b=XDH+5MEhPGVK+G1gjrU3HfJlvPyPXfqKA0a+oHe7iTOj0gUkquyND3Nuzcr66GNuXO 5UnafZCtNImxHYFkWOMTwZSIc7CqYYU6SiWbdRO+3RYJNsDVHythZEjw0qXb/keSDSZ7 HXc4J/2CKk880AfOeR6/zBEJpzBkMycp0lUTFF5hXeEcn/Ov270wsz+hWxxaSI8e2djA dP3QubNT6wimBYw/jmd+yAYepYwPpPXExIzXCU3vFHXUdLIdekSsy2d1Kx2loS0P3YzW WsvSBR2dQNfcLHybU7/Li33f8+0S7jHTWvNbi7nyqKUw5kQYN4IFIu9Grs/fcjXWY9yL mt3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ti7gNQ0joFnwn5bt+CZWp7BNKSVRmg7a1dGHdw6oaqs=; b=dwub6XriWiZQAVe1m3Hy9tSxDrj7XXjP6uCgS/G61nMmeE/nWT/Df86tvc+yxgOcRh TRNFlMQM2ztKAPuX+FfFD05NG2BjoJPdVV4NQzYX3ShM8xU7+nkDQ4F8SNPK1xJ0ECP0 B1n/0y8E96WyxSygWopM0ZEgFiovMRhYoGE3FA1KHiD23Ov1xvZguYDSOklZanbp1Qyf HSx2tqqBCpxhE4FWBZFJ9F9gZG/u0maqJOk60SFwSNhqsUdXuawChOWHbxr2it3dgcu3 uL2FbTH0UurzO5MkU+9e4csZ+hVna/S0uk4850ghcmuiJTD4rtf45HknYjGyuUnydsJO ay7A== X-Gm-Message-State: AFqh2kpf8twLxD6xfwVLPO4c/Arl0ulInODPNallF+rgy0RR7Eql5dJv U6jddlmW5iKITZCC8xNyJrNKIA== X-Google-Smtp-Source: AMrXdXuyzktmR/DGOD8+kKKwQCQ9dUZSvkxUANpa6OnHhmmbynG6F1V4UFEfKk7iMSO8Sbvw4b6Lyw== X-Received: by 2002:a9d:7cca:0:b0:677:3d79:e60a with SMTP id r10-20020a9d7cca000000b006773d79e60amr9133706otn.31.1672089813146; Mon, 26 Dec 2022 13:23:33 -0800 (PST) Received: from eze-laptop ([190.11.62.130]) by smtp.gmail.com with ESMTPSA id r24-20020a056830135800b006731ecc5bedsm5808337otq.14.2022.12.26.13.23.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Dec 2022 13:23:32 -0800 (PST) Date: Mon, 26 Dec 2022 18:23:26 -0300 From: Ezequiel Garcia To: Chen-Yu Tsai Cc: Mauro Carvalho Chehab , Hans Verkuil , Philipp Zabel , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] media: hantro: Use core-generated bus_info value Message-ID: References: <20221226052606.144109-1-wenst@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221226052606.144109-1-wenst@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221226_132335_275339_D38FE2CB X-CRM114-Status: GOOD ( 21.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 26, 2022 at 01:26:06PM +0800, Chen-Yu Tsai wrote: > The Hantro driver uses a hardcoded value for the bus_info field in the > media device and |struct v4l2_capability|. This worked well when there > was just one device. However with the iMX.8 series we are now seeing > two Hantro blocks on the same chip. The static bus_info is no longer > sufficient for differentiating devices. > > Since commit f2d8b6917f3b ("media: v4l: ioctl: Set bus_info in > v4l_querycap()"), the V4L2 core provides a default value for the > bus_info field for platform and PCI devices. This value will match > the default value for media devices added by commit cef699749f37 > ("media: mc: Set bus_info in media_device_init()"). These defaults > are stable and device-specific. > > Drop the static bus_info values from the hantro driver and use the > defaults. > > Signed-off-by: Chen-Yu Tsai Makes sense. Reviewed-by: Ezequiel Garcia Thanks! > --- > Changes since v1: > - Dropped unrelated Makefile change > > drivers/media/platform/verisilicon/hantro_drv.c | 2 -- > drivers/media/platform/verisilicon/hantro_v4l2.c | 2 -- > 2 files changed, 4 deletions(-) > > diff --git a/drivers/media/platform/verisilicon/hantro_drv.c b/drivers/media/platform/verisilicon/hantro_drv.c > index 8cb4a68c9119..b0aeedae7b65 100644 > --- a/drivers/media/platform/verisilicon/hantro_drv.c > +++ b/drivers/media/platform/verisilicon/hantro_drv.c > @@ -1050,8 +1050,6 @@ static int hantro_probe(struct platform_device *pdev) > > vpu->mdev.dev = vpu->dev; > strscpy(vpu->mdev.model, DRIVER_NAME, sizeof(vpu->mdev.model)); > - strscpy(vpu->mdev.bus_info, "platform: " DRIVER_NAME, > - sizeof(vpu->mdev.bus_info)); > media_device_init(&vpu->mdev); > vpu->mdev.ops = &hantro_m2m_media_ops; > vpu->v4l2_dev.mdev = &vpu->mdev; > diff --git a/drivers/media/platform/verisilicon/hantro_v4l2.c b/drivers/media/platform/verisilicon/hantro_v4l2.c > index 2c7a805289e7..c1a116031013 100644 > --- a/drivers/media/platform/verisilicon/hantro_v4l2.c > +++ b/drivers/media/platform/verisilicon/hantro_v4l2.c > @@ -142,8 +142,6 @@ static int vidioc_querycap(struct file *file, void *priv, > > strscpy(cap->driver, vpu->dev->driver->name, sizeof(cap->driver)); > strscpy(cap->card, vdev->name, sizeof(cap->card)); > - snprintf(cap->bus_info, sizeof(cap->bus_info), "platform: %s", > - vpu->dev->driver->name); > return 0; > } > > -- > 2.39.0.314.g84b9a713c41-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel