From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 004D1C54EBE for ; Wed, 11 Jan 2023 09:26:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a3fUzqI8mOY4gYEGBuMY/v7SKro/zzY5Ufh+p+QqOkE=; b=QWMbFrcHgXgQrY yHEoeiQHu2Lw20UbqtpkhO+vfsu9uZFIRfqHF1ywLNB3iO2lgdD15hxB+W4a67sPguThlaF2+zb3R n8MYxXTdn/hPRRP0dvzSD9JgpNKQGzDPpsDSssvciol1i0BDbwRDlNalVeIyMve3W+gQpG2ZCO2rd ixdY8bjq0MuBvykogOKjW8Q9y1gs0dmfUXKZN/8Q5EbZnmTre2vdaLDkPuslXzg0n22CGXrjn08GE oOpOHM+avU9T22WslMcv8ARafgAD7aOIN/DwtrGMRT+upsW7r17ydnxoGDAuEtVanOP8wgasd+HkM +pOrLJh/3t7S+yrTI79w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFXMv-00AWqi-AL; Wed, 11 Jan 2023 09:26:01 +0000 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFXMr-00AWmq-1a; Wed, 11 Jan 2023 09:25:58 +0000 Received: by mail-pf1-x42e.google.com with SMTP id h7so6737647pfq.4; Wed, 11 Jan 2023 01:25:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=REWsaUl6PIGZxGjQDNsHgylq9u4efBb5hD+0H4Wo0bU=; b=DAi6i88V4NfTBA3ydSUaOJpxJJQcem5npBHw5b3086UW5fnXJ68u+Vs8pEQU8R9ROk r4xIwDOPH/fQH7p+0PvEm2d/7UvRk5OdWXb9NpoD9QqgIYsV1lIRRAU6rHWdWFhqSTI0 FJY5DtdqTtZdv1E3rFIZ881IS7D8PxfXyvSVlSjAIguTioFkzKfQ72weJN4QjY2C5VHe SgufQFcQtn6K2pW/g2pe8zsO0WNcXsxgcUqY2YR1ewvZdk+FY6T4R8OFipAS0xSN3cZD vU/sMbVESwZooe5CzKStfzZ8p03aQcmCFonFUtpmsayHUkJypjBu3r9NEBbZ1EdhmPxG BeiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=REWsaUl6PIGZxGjQDNsHgylq9u4efBb5hD+0H4Wo0bU=; b=8GQ59cugTBFm9qnYR9IxH/DzyYczN7fuQLo7Lthn3+fcYCipZTmwtqLslu22foRI3J 4hZnCfaHMpaMaK4BfVxzrk+8fVFNugzOng8DrDIxdhUs0SaB7TdcxIt70gXB/rJvSbWW HSfovlXRz2veDtZ/jxoum/s354llvAz8EyD4h28sIyut+hfeA3BBKdC9E66VO5I7JIkO /LusnAo0lRaVgH0oidrdraHn6//ZmNwFu07Ke2YPn8qVc+X1uinmQjDkVhIt1qKVtip3 EduizuWF18GhCnVsAZNiOHVcdXcKTvNpjPTfJZDdkNYxHIA0/bfza+IDw56AXiAIMfUS UqQQ== X-Gm-Message-State: AFqh2kp14V9cmXjtS/ZA5Q+SB02K2rRRbVQszd3/g/w3gheGi5qFkiGY 9BqjJsuVYjVT/2UD+JzMJao= X-Google-Smtp-Source: AMrXdXuM/Sv1/zsrNTggBgsMKA2XF1F6XVWod6lpFBepCUuB6CxuG01EPVUGvRxXxUeN1XUhuCgiXA== X-Received: by 2002:a05:6a00:27a5:b0:583:63eb:581e with SMTP id bd37-20020a056a0027a500b0058363eb581emr17019609pfb.18.1673429153635; Wed, 11 Jan 2023 01:25:53 -0800 (PST) Received: from gaurav-pc.bbrouter ([2402:e280:217b:6d8:bf67:b774:ee50:1dc5]) by smtp.gmail.com with ESMTPSA id v67-20020a622f46000000b00581ad007a9fsm9488599pfv.153.2023.01.11.01.25.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 01:25:53 -0800 (PST) Date: Wed, 11 Jan 2023 14:55:29 +0530 From: Gaurav Pathak To: Greg KH Cc: f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] staging: vchiq_arm.c: Declare vchiq_platform_init as static Message-ID: References: <20230111080124.32274-1-gauravpathak129@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230111_012557_134799_142A7E1C X-CRM114-Status: GOOD ( 22.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Greg, After submitting the patch, I realized this is the duplicate patch of https://www.spinics.net/lists/arm-kernel/msg976512.html I am in the process of reproducing the issue reported by kernel test robot in the original patch submission. If I am successful, I will try to fix other warnings. Best, Gaurav On Wed, Jan 11, 2023 at 10:00:37AM +0100, Greg KH wrote: > On Wed, Jan 11, 2023 at 01:31:24PM +0530, Gaurav Pathak wrote: > > Modified vchiq_platform_init() as static to fix sparse warning > > > warning: symbol 'vchiq_platform_init' was not declared. Should it be > > > static? > > Put the warning line all on one line, no need to wrap that. > > > Signed-off-by: Gaurav Pathak > > --- > > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > > index dc33490ba7fb..ffa517077b80 100644 > > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > > @@ -462,7 +462,7 @@ free_pagelist(struct vchiq_instance *instance, struct vchiq_pagelist_info *pagel > > cleanup_pagelistinfo(instance, pagelistinfo); > > } > > > > -int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) > > +static int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) > > { > > struct device *dev = &pdev->dev; > > struct vchiq_drvdata *drvdata = platform_get_drvdata(pdev); > > -- > > 2.39.0 > > > > > > What changed to enable this version of the patch to work properly > compared to the previous submissions that broke the build? Did you test > this and it now works properly? > > thanks, > > greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel