From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9B65C46467 for ; Wed, 11 Jan 2023 16:11:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1UdzJAowD1JKR/OKdVHNI8xX6WSCej6E6gKYqQwTZXA=; b=NUf8bXPv4pAlg9 Vv6OrLmlNn0FhLQ6dHDCFB9zcvYHKvGMn2fICwP12DAVL8KjP1Ajn3n8E62C5ehsvaQhCW00whTz0 zNAjM/GKgGly7Ne0tyfNenxTjbkzEOp+gA2pSd75gCVcMEWbfPp9I5MMdrtRw3q0UOP5mZav9e9ZN bjqLBofR5+ZVQbwFPSHZrSmPgo+IFT60NZW2Wzg6PEXOJiY+PevqbbIW2nHVCnWXSTyRY6gO+m86f kCJ0S9mDpNmTVgHaiWvu+Z91JIDsIrXDr7ME2gSIHwW5ohZxHIpopxWgyxyi5nxTTe4RT0r4e6PuM 2s92BnoaQTi1qg/ndwNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFdgm-00C6xA-QR; Wed, 11 Jan 2023 16:10:56 +0000 Received: from mga07.intel.com ([134.134.136.100]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFdgj-00C6wL-0c; Wed, 11 Jan 2023 16:10:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673453453; x=1704989453; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Qdwk/ULwe80LyvZKMxiSPgYKLRGtK5OMkqcEIHSWzXU=; b=JX5jf8IzsTTfFDzGQRufM6/NnWhJCQ1qI5hU8+w69uq0s2G42EY7klqF Q40G1h5SebDpRCBPaDef/el+Pq9UGBw8932q47JOY20NQtutYscNDvY7k uhSO169RofdaK/aDtANTH0SV2Ob81bv0lXA/luEbXaKpGWSPO4fdDHohY zemU2aGoP3oABhVIxUSRjeOuW+F+FhaazQ8GDRi9W7m6EFByvNtTbd6G7 3MluzR2mlh3u3kq/1jP/oNuYNmWnHacKd64aAATF6PE6nvAgLBCLnObW1 oeyg86GKut4/g2K8eyoBWQY/Ui6AM6zgs2RD0JMFWkE1mf8IjEL7pSYIr w==; X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="387921306" X-IronPort-AV: E=Sophos;i="5.96,317,1665471600"; d="scan'208";a="387921306" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2023 08:08:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="720770547" X-IronPort-AV: E=Sophos;i="5.96,317,1665471600"; d="scan'208";a="720770547" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.55]) by fmsmga008.fm.intel.com with SMTP; 11 Jan 2023 08:08:43 -0800 Received: by stinkbox (sSMTP sendmail emulation); Wed, 11 Jan 2023 18:08:42 +0200 Date: Wed, 11 Jan 2023 18:08:42 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Thomas Zimmermann Cc: alexander.deucher@amd.com, christian.koenig@amd.com, airlied@gmail.com, daniel@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, patrik.r.jakobsson@gmail.com, thierry.reding@gmail.com, sam@ravnborg.org, f.fainelli@gmail.com, james.qian.wang@arm.com, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 02/10] drm: Include where needed Message-ID: References: <20230111130206.29974-1-tzimmermann@suse.de> <20230111130206.29974-3-tzimmermann@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230111130206.29974-3-tzimmermann@suse.de> X-Patchwork-Hint: comment X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230111_081053_126543_596E5584 X-CRM114-Status: GOOD ( 18.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 11, 2023 at 02:01:58PM +0100, Thomas Zimmermann wrote: > Include in source files that need it. Some of DRM's > source code gets OF header via drm_crtc_helper.h and , > which can leed to unnecessary recompilation. > = > In drm_modes.c, add a comment on the reason for still including > . The header file is required to get KHZ2PICOS(). The > macro is part of the UAPI headers, so it cannot be moved to a less > prominent location. I never liked that KHZ2PICOS() thing in there. Maybe we should just nuke it and see if anyone notices? > = > v2: > * include in komeda_drv.c (kernel test robot) > = > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 1 + > drivers/gpu/drm/drm_modes.c | 5 +++-- > drivers/gpu/drm/panel/panel-ronbo-rb070d30.c | 1 + > 3 files changed, 5 insertions(+), 2 deletions(-) > = > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gp= u/drm/arm/display/komeda/komeda_drv.c > index 3f4e719eebd8..28f76e07dd95 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c > @@ -6,6 +6,7 @@ > */ > #include > #include > +#include > #include > #include > #include > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c > index be030f4a5311..40d482a01178 100644 > --- a/drivers/gpu/drm/drm_modes.c > +++ b/drivers/gpu/drm/drm_modes.c > @@ -31,10 +31,11 @@ > */ > = > #include > +#include > +#include /* for KHZ2PICOS() */ > #include > #include > -#include > -#include > +#include > = > #include