From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BAEADC3DA7D for ; Tue, 3 Jan 2023 15:07:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t9440BnMDupwDoSVleutKEm+hLA7K2F8n5iq2AAmqYo=; b=g3wnN8k88FsP6e VTgthqO3jrAiI68gIZWyU2G+y6BSBxeU3NiTon8iW2swW6UNIo6njBk353CpdRsS9Yvq8zl7E1XVt syhhHBVyuDArCkmUsj5rz7itFunK4wW18JFOfiecAAyC7o6Y4/IfSKYrirnhn/xq/mGcpjxgd4vW2 sdRpKcBYMg/D6AYkadXKPxu+xdcbcLDv72C6GbWX2iq+mx///rlAbgzncgN6KWnlLqeuBfX69aDCd j4QFXcxT4bRsxu0erkXlgAd/cik9IVI54DrBVX/k8OBAP5g6MIb4XF5N5a+f4TbrK/JZWD4Qwrge2 yw+Y6IsMdJEMayEUk21Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCiru-002GlE-2H; Tue, 03 Jan 2023 15:06:23 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCeDS-000cpl-O5 for linux-arm-kernel@lists.infradead.org; Tue, 03 Jan 2023 10:08:20 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 78B4D1516; Tue, 3 Jan 2023 02:08:46 -0800 (PST) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D97393F663; Tue, 3 Jan 2023 02:08:03 -0800 (PST) Date: Tue, 3 Jan 2023 10:08:01 +0000 From: Cristian Marussi To: Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com, Rob Herring , devicetree@vger.kernel.org Subject: Re: [PATCH 4/5] dt-bindings: firmware: arm,scmi: Add support for syspower protocol Message-ID: References: <20221222183823.518856-1-cristian.marussi@arm.com> <20221222183823.518856-5-cristian.marussi@arm.com> <3d89e135-c8e4-ede4-950f-03900a660822@kernel.org> <23436455-098f-6e21-2330-d91158a591ad@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <23436455-098f-6e21-2330-d91158a591ad@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230103_020818_884079_12C42DBE X-CRM114-Status: GOOD ( 21.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 23, 2022 at 12:22:34PM +0100, Krzysztof Kozlowski wrote: > On 23/12/2022 11:37, Cristian Marussi wrote: > > >>> > >>> + protocol@12: > >>> + type: object > >>> + properties: > >>> + reg: > >>> + const: 0x12 > >>> + > >> > >> Why? It did not got lost, it's already covered by pattern. If you refer > >> to particular warning, please paste it in commit msg. Otherwise it looks > >> incorrect. > >> > > > > Yes indeed, but as a matter of fact it seemed to me that we used to add an > > entry and an example for all the currently published standard SCMI protocols, > > even though already covered by the patternProp (which covers also any > > custom-vendor protocol in the wild) and not sporting any additional > > custom properties (see protocol@18), but maybe this is just a unneeded wrong > > habit adding only cruft to the bindings. > > > > If you think it does not add any value I can happily drop this, or > > limiting the addition just to the example (and/or drop equally the unneeded > > protocol@18 node too in this case). > > Duplicating the node (once in properties, second in patternProperties) > is not needed. I am also not sure what would be the point to add to the > example - example does not have to be complete DTS for all cases, but > illustrate the binding and allow is to test it. > Thanks, I'll drop this patch. Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel