From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04D69C46467 for ; Tue, 3 Jan 2023 15:58:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m+cDKL3k2upvJ9dITeJdDm6IHcPG/o37ZaGAyMUaUtM=; b=FgOB3ynmmrgIjT jNBJbm7sfXWe7cl4pmc+TG8yWUq/pROfyUSSsimNhYMc+2Lh16yhdLR2Drt6scslq0+qoc5tKI6M0 58cp48T06olIrviU2nNhOOMuFNEVoipYA4Uo6tls9QnQgkoGBScQVqXBLjXdPFcx8XT1eZ2XUqycG 5Ro40cfQp7kWd8ecfceFtoqk0dAJKzvaS7U7OYy8P7GsRwNAVsKiO+adI/ybrr92ouVqL0GVw2XzQ F1hHU8sk0LrBLY9qlDGaGIQaQavUuTA8m+uPp7hu1fL5rB3fIYp5XG5VLYgwJMRCINcHD3xF5pLpI GJdWSUuRF7+VfYYwNchQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCjfR-002gol-96; Tue, 03 Jan 2023 15:57:34 +0000 Received: from msg-1.mailo.com ([213.182.54.11]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCfvL-00169F-Ax for linux-arm-kernel@lists.infradead.org; Tue, 03 Jan 2023 11:57:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1672747041; bh=5KE1bzJMLLs9XBW72AsVplzYn5IE4iMo2R2HI+i7kb0=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=kv9U/FIv9VGhdFJi3IyhQcgVNQq15KaGVYJhKLma0c50xGw+h3WLxUZxhKK+xKV01 OFFzFEqdhzRiONxIaZNoO6Jm0hVwYOaqcte6u4PPNJ+IDi5fLaHq8EeW2tzSI/Gi+f 5vA/iEFN9eomANR33qjrrwpY9iYNOtXOaXtwRVnE= Received: by b-4.in.mailobj.net [192.168.90.14] with ESMTP via ip-206.mailobj.net [213.182.55.206] Tue, 3 Jan 2023 12:57:20 +0100 (CET) X-EA-Auth: 0aZRb68IvOlvkeo4K4Ts1obj7+1EnRLn9CttfrUQEA+vqi0SpXI0EtEM4penQr4SCw6AXY8oPHH8B6GGBwyXd74DsEc9bozB Date: Tue, 3 Jan 2023 17:27:14 +0530 From: Deepak R Varma To: Fabio Estevam Cc: Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Saurabh Singh Sengar , Praveen Kumar , Deepak R Varma Subject: Re: [PATCH] staging: media: imx: remove unnecessary return variable Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230103_035743_667171_E1F98451 X-CRM114-Status: GOOD ( 16.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 03, 2023 at 08:50:51AM -0300, Fabio Estevam wrote: > On Tue, Jan 3, 2023 at 8:45 AM Deepak R Varma wrote: > > > > The function imx_media_fim_set_stream() can directly return 0 instead of > > using a ret variable which never changes its value. Issue identified > > using the returnvar.cocci Coccinelle semantic patch. > > > > Signed-off-by: Deepak R Varma > > --- > > drivers/staging/media/imx/imx-media-fim.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/staging/media/imx/imx-media-fim.c b/drivers/staging/media/imx/imx-media-fim.c > > index fb6590dcfc36..e719227d4323 100644 > > --- a/drivers/staging/media/imx/imx-media-fim.c > > +++ b/drivers/staging/media/imx/imx-media-fim.c > > @@ -373,7 +373,6 @@ int imx_media_fim_set_stream(struct imx_media_fim *fim, > > bool on) > > { > > unsigned long flags; > > - int ret = 0; > > > > v4l2_ctrl_lock(fim->ctrl[FIM_CL_ENABLE]); > > > > @@ -393,7 +392,7 @@ int imx_media_fim_set_stream(struct imx_media_fim *fim, > > fim->stream_on = on; > > out: > > v4l2_ctrl_unlock(fim->ctrl[FIM_CL_ENABLE]); > > - return ret; > > + return 0; > > Maybe you could change imx_media_fim_set_stream() to a void function instead? That sounds more accurate. I will send in the revision as v2. Thank you so much for the feedback. Regards, ./drv > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel