From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C993CC3DA7A for ; Thu, 5 Jan 2023 19:47:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wEgEKX3eIJ1ujdJ+7RIHSjygIRhLeS9oYZ1gJL65etk=; b=DWKGG7p7LyTz0l hfM4bANvX5d2ZfibRsxcfFpIv413F6F1yPM74gFCOdLct09d0L8Ywp6SdSYSqbyCSiuHPVfCEfvj5 GxT9CsO8RQz319jlY/vhujk4+Q27rPJHACRlaqRClbq/VbYAMYEKEHDCFKHyXSB/m5ys6R9WWbZ7+ oPi6WzxCw18UoZFnHnHHPY++4xTxUTXRCdVMBlgap3kxZrVqUnHGxuPpd9Ln1udSXjV2E0/DDptJ1 O1vJoBpmwPTA5Swu7bFIOWYdvnszhq7WyuUfhww17bga+VJW++Hso0+SfDGis1jLAW3jno5N1oDzg 3t3JVvI9bw7i14VsDLbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDWBz-00EEP5-DP; Thu, 05 Jan 2023 19:46:24 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDMGP-009Id9-1R for linux-arm-kernel@lists.infradead.org; Thu, 05 Jan 2023 09:10:18 +0000 Received: by mail-wr1-x42b.google.com with SMTP id s9so3444732wru.13 for ; Thu, 05 Jan 2023 01:10:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hJHxOQO4N1hVQlNWLaYS7uiORL25B97K1+y7ilH6tPU=; b=n9S9mo7pTHK6PFhYNyqFdfYI/hxcvdrzmCyv2sR4gGv/AnFmiMJss9H3ptXwDDgyDB Zncv6CusCIlB5ujjFfPsxHRp/fKZlGt2ek6DUED2fEIgvJGvJuaZcq9B5QigGYruQ3eq gGqqd3yY9IkQugrAr0QvNdg/kg286thMXHOIx80mTxA89EqgpsIOHnmqkKGzqdmUZveI s9rA1FnBCNQM+kPUpui7AEXKnQCkbtv7BgIL974Z66cHg64jzv7xOqhMj15QB/7han48 W84qR9jZOWjenZvhWS2Xiaw5BIWXgJrIcab3r8z7M0Ylp04xDmdUihs8TPthSKntx80T xarg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hJHxOQO4N1hVQlNWLaYS7uiORL25B97K1+y7ilH6tPU=; b=hIZtEdFHb4lU4fkAXl74B6X0ACSSAcuT6QrMYMh74wC+nKaYGU2nMGfayI8OACtcv5 aehZ4YkeGzuBcew0TK36p/nUl0Cjd5OKZr1Xt69Fm6I7xBi33KveXSMvdejOP48jJ5md 3hrIFYpxV0gim0sFTdNL6t+X2i+Jv1WbIK/Mv1gDkofBieh53RJvdTRISBsQdB5/xzVU hxKsbSpCYHqELFm390/1lgZSWqhQfNQ3qYX3XI1H/pBx6b16DK62QOFe7/MAOXH3YBw7 vBvD8/p/YRzCifgYspLsVtrB94FfApwMjwAWQXgi22+ExT5iI5fiZu6Y8VuajOPm5tAY c8hA== X-Gm-Message-State: AFqh2kq0YW9eemR9xDhLyBCUfKscMggdP6MRdF6xyUrllzbFdXNv+Wgv eAwusoCbLO8ZEac/EDDB8P6qrLmIhvTtCyae X-Google-Smtp-Source: AMrXdXtoohBaSHmotbz3uUa0FhQA5zbqAVQQxrdH/tcyN1e8HeYQ6144fHvEno7hcOoG0xG80IaglQ== X-Received: by 2002:a5d:45d2:0:b0:27a:d81:112e with SMTP id b18-20020a5d45d2000000b0027a0d81112emr24370123wrs.15.1672909815083; Thu, 05 Jan 2023 01:10:15 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id i13-20020a5d438d000000b0029e1aa67fd2sm7373174wrq.115.2023.01.05.01.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 01:10:14 -0800 (PST) Date: Thu, 5 Jan 2023 12:10:11 +0300 From: Dan Carpenter To: Steen Hegelund Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , UNGLinuxDriver@microchip.com, Randy Dunlap , Casper Andersson , Russell King , Wan Jiabing , Nathan Huckleberry , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Daniel Machon , Horatiu Vultur , Lars Povlsen Subject: Re: [PATCH net-next 2/8] net: microchip: sparx5: Reset VCAP counter for new rules Message-ID: References: <20230105081335.1261636-1-steen.hegelund@microchip.com> <20230105081335.1261636-3-steen.hegelund@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230105081335.1261636-3-steen.hegelund@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230105_011017_129538_F3E48C68 X-CRM114-Status: GOOD ( 17.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 05, 2023 at 09:13:29AM +0100, Steen Hegelund wrote: > When a rule counter is external to the VCAP such as the Sparx5 IS2 counters > are, then this counter must be reset when a new rule is created. > > Signed-off-by: Steen Hegelund > --- > drivers/net/ethernet/microchip/vcap/vcap_api.c | 3 +++ > drivers/net/ethernet/microchip/vcap/vcap_api_kunit.c | 4 ++-- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api.c b/drivers/net/ethernet/microchip/vcap/vcap_api.c > index b9b6432f4094..67e0a3d9103a 100644 > --- a/drivers/net/ethernet/microchip/vcap/vcap_api.c > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api.c > @@ -1808,6 +1808,7 @@ int vcap_add_rule(struct vcap_rule *rule) > { > struct vcap_rule_internal *ri = to_intrule(rule); > struct vcap_rule_move move = {0}; > + struct vcap_counter ctr = {0}; > int ret; > > ret = vcap_api_check(ri->vctrl); > @@ -1833,6 +1834,8 @@ int vcap_add_rule(struct vcap_rule *rule) > ret = vcap_write_rule(ri); > if (ret) > pr_err("%s:%d: rule write error: %d\n", __func__, __LINE__, ret); > + /* Set the counter to zero */ > + ret = vcap_write_counter(ri, &ctr); > out: > mutex_unlock(&ri->admin->lock); > return ret; I feel like you intended to send a v2 series but accidentally resent the v1 series. Otherwise I guess I have the same question as before. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel