From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F1B7C46467 for ; Sat, 7 Jan 2023 17:19:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OyZ8ujbLwzEWVx5B/KO2rWTFywS3cf7qzuel1LyXE7A=; b=hbQ75U5izWq6pL c4hV5QP7n4f8uxsAwm3tbhoX+A2ySpVcjP4ZU4OmVvJ039YTBSwpuuz+aD+ouAT+jds8WQNZCtpN5 5rQSs7pzj9reidqP18/ideWj8DS72dqX7ey0VQgnXDm7jQtGoeZNP341WLMLchsZeVvA0sOWy6du4 6y3k4887EHVPp2+X4wUB3tAVEDFZOv8Z5UGfgrCUkgmoqoXOlQGAulZr4isH+GXzdQujAfRTtDAc6 KqxvZRkkqNsGlsVyorWMHNNo4SWYOO6HKIyVWoMI2bVyTdccBJBukls1C3ca6Y07u6oqJ4HCJhxUQ 7R0JyAlhTn5aLArdgmUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pECqQ-007nnX-Ej; Sat, 07 Jan 2023 17:18:58 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pECqF-007njg-Mo for linux-arm-kernel@lists.infradead.org; Sat, 07 Jan 2023 17:18:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ApdrS3tSWj75Jx4ozDcfURvKE8QjJ1d5AVnSBy/AzuQ=; b=c2T+A4Qv0SjXNNHpM3dbOAlQfA Dbolq53uUXvu8D6DU5Y/CydTxr0o3b4/oo3V2H2vz1fZ5KxB4iTRi981LfK+n7sbTr5OfouKAva1t /sND2MtNQLPAfaenVae4HskA/G89pIJCp6FCpZhiigxJUpw5AGK3VAMj+WCnfn4fbz5w=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pECps-001R2T-1u; Sat, 07 Jan 2023 18:18:24 +0100 Date: Sat, 7 Jan 2023 18:18:24 +0100 From: Andrew Lunn To: Klaus Kudielka Cc: Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Pali =?iso-8859-1?Q?Roh=E1r?= , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Thomas Petazzoni , Chris Packham , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] Revert "ARM: dts: armada-38x: Fix compatible string for gpios" Message-ID: References: <20230107144149.5743-1-klaus.kudielka@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230107144149.5743-1-klaus.kudielka@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230107_091847_810865_6792EE85 X-CRM114-Status: GOOD ( 14.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jan 07, 2023 at 03:41:48PM +0100, Klaus Kudielka wrote: > This reverts commit c4de4667f15d04ef5920bacf41e514ec7d1ef03d, which causes > a regression on Turris Omnia (Armada 385): GPIO interrupts cease to work, > ending up in the DSA switch being non-functional. > > The blamed commit is incorrect in the first place: > If compatible = "marvell,armadaxp-gpio", the second (address, size) pair > of the reg property must to point to the per-CPU interrupt registers > <0x18800 0x30> / <0x18840 0x30>, and not to the blink enable registers > <0x181c0 0x08> / <0x181c8 0x08>. > > But even fixing that leaves the GPIO interrupts broken on the Omnia. > > Furthermore: > Commit 5f79c651e81e explains very well, why the gpio-mvebu driver does not > work reliably with per-CPU interrupts. > Commit 988c8c0cd04d deprecates compatible = marvell,armadaxp-gpio for this > reason. > > Fixes: c4de4667f15d ("ARM: dts: armada-38x: Fix compatible string for gpios") > Reported-by: Klaus Kudielka > Link: https://lore.kernel.org/r/f24474e70c1a4e9692bd596ef6d97ceda9511245.camel@gmail.com/ > > Signed-off-by: Klaus Kudielka Hi Klaus I was hoping Pali would comment, maybe fix it. But i think enough time has passed, we should accept your reverts. Reviewed-by: Andrew Lunn Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel