* [PATCH][next] crypto: aspeed - Replace zero-length array with flexible-array member
@ 2023-01-10 1:39 Gustavo A. R. Silva
2023-01-10 10:46 ` Neal Liu
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2023-01-10 1:39 UTC (permalink / raw)
To: Neal Liu, Herbert Xu, David S. Miller, Joel Stanley,
Andrew Jeffery
Cc: linux-aspeed, linux-crypto, linux-arm-kernel, linux-kernel,
Gustavo A. R. Silva, linux-hardening
Zero-length arrays are deprecated[1] and we are moving towards
adopting C99 flexible-array members instead. So, replace zero-length
array declaration in struct aspeed_sham_ctx with flex-array
member.
This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
routines on memcpy() and help us make progress towards globally
enabling -fstrict-flex-arrays=3 [2].
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays [1]
Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [2]
Link: https://github.com/KSPP/linux/issues/78
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/crypto/aspeed/aspeed-hace.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/aspeed/aspeed-hace.h b/drivers/crypto/aspeed/aspeed-hace.h
index f2cde23b56ae..05d0a15d546d 100644
--- a/drivers/crypto/aspeed/aspeed-hace.h
+++ b/drivers/crypto/aspeed/aspeed-hace.h
@@ -183,7 +183,7 @@ struct aspeed_sham_ctx {
struct aspeed_hace_dev *hace_dev;
unsigned long flags; /* hmac flag */
- struct aspeed_sha_hmac_ctx base[0];
+ struct aspeed_sha_hmac_ctx base[];
};
struct aspeed_sham_reqctx {
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH][next] crypto: aspeed - Replace zero-length array with flexible-array member
2023-01-10 1:39 [PATCH][next] crypto: aspeed - Replace zero-length array with flexible-array member Gustavo A. R. Silva
@ 2023-01-10 10:46 ` Neal Liu
2023-01-12 22:17 ` Kees Cook
2023-01-20 10:32 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Neal Liu @ 2023-01-10 10:46 UTC (permalink / raw)
To: Gustavo A. R. Silva, Herbert Xu, David S. Miller, Joel Stanley,
Andrew Jeffery
Cc: linux-aspeed@lists.ozlabs.org, linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
> Zero-length arrays are deprecated[1] and we are moving towards adopting
> C99 flexible-array members instead. So, replace zero-length array declaration
> in struct aspeed_sham_ctx with flex-array member.
>
> This helps with the ongoing efforts to tighten the FORTIFY_SOURCE routines
> on memcpy() and help us make progress towards globally enabling
> -fstrict-flex-arrays=3 [2].
>
> Link:
> https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-lengt
> h-and-one-element-arrays [1]
> Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html
> [2]
> Link: https://github.com/KSPP/linux/issues/78
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/crypto/aspeed/aspeed-hace.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/aspeed/aspeed-hace.h
> b/drivers/crypto/aspeed/aspeed-hace.h
> index f2cde23b56ae..05d0a15d546d 100644
> --- a/drivers/crypto/aspeed/aspeed-hace.h
> +++ b/drivers/crypto/aspeed/aspeed-hace.h
> @@ -183,7 +183,7 @@ struct aspeed_sham_ctx {
> struct aspeed_hace_dev *hace_dev;
> unsigned long flags; /* hmac flag */
>
> - struct aspeed_sha_hmac_ctx base[0];
> + struct aspeed_sha_hmac_ctx base[];
> };
>
> struct aspeed_sham_reqctx {
> --
> 2.34.1
Reviewed-by: Neal Liu <neal_liu@aspeedtech.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH][next] crypto: aspeed - Replace zero-length array with flexible-array member
2023-01-10 1:39 [PATCH][next] crypto: aspeed - Replace zero-length array with flexible-array member Gustavo A. R. Silva
2023-01-10 10:46 ` Neal Liu
@ 2023-01-12 22:17 ` Kees Cook
2023-01-20 10:32 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Kees Cook @ 2023-01-12 22:17 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Neal Liu, Herbert Xu, David S. Miller, Joel Stanley,
Andrew Jeffery, linux-aspeed, linux-crypto, linux-arm-kernel,
linux-kernel, linux-hardening
On Mon, Jan 09, 2023 at 07:39:17PM -0600, Gustavo A. R. Silva wrote:
> Zero-length arrays are deprecated[1] and we are moving towards
> adopting C99 flexible-array members instead. So, replace zero-length
> array declaration in struct aspeed_sham_ctx with flex-array
> member.
>
> This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
> routines on memcpy() and help us make progress towards globally
> enabling -fstrict-flex-arrays=3 [2].
>
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays [1]
> Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [2]
> Link: https://github.com/KSPP/linux/issues/78
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][next] crypto: aspeed - Replace zero-length array with flexible-array member
2023-01-10 1:39 [PATCH][next] crypto: aspeed - Replace zero-length array with flexible-array member Gustavo A. R. Silva
2023-01-10 10:46 ` Neal Liu
2023-01-12 22:17 ` Kees Cook
@ 2023-01-20 10:32 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2023-01-20 10:32 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Neal Liu, David S. Miller, Joel Stanley, Andrew Jeffery,
linux-aspeed, linux-crypto, linux-arm-kernel, linux-kernel,
linux-hardening
On Mon, Jan 09, 2023 at 07:39:17PM -0600, Gustavo A. R. Silva wrote:
> Zero-length arrays are deprecated[1] and we are moving towards
> adopting C99 flexible-array members instead. So, replace zero-length
> array declaration in struct aspeed_sham_ctx with flex-array
> member.
>
> This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
> routines on memcpy() and help us make progress towards globally
> enabling -fstrict-flex-arrays=3 [2].
>
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays [1]
> Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [2]
> Link: https://github.com/KSPP/linux/issues/78
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/crypto/aspeed/aspeed-hace.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-20 10:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-10 1:39 [PATCH][next] crypto: aspeed - Replace zero-length array with flexible-array member Gustavo A. R. Silva
2023-01-10 10:46 ` Neal Liu
2023-01-12 22:17 ` Kees Cook
2023-01-20 10:32 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).