From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 110F2C54EBD for ; Tue, 10 Jan 2023 01:47:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ydaL+iM7hgah1weR6ZnkVhA51bjF04luC5t3M6V80rg=; b=bcoLK60PDiw4Yp Rw9qGRS5YERzJ5LnoLxZ3+9jeh7kopJoDqumxTojwC220Ld285V1lgDiXs5erzmjEEgzByEcxn1+b K1n9PwV5gyyMFYn96On6y+Am5BdHqOommA0LxZhIR78/kYG5YLeTYd+yeKuloPG4PwkQOD5nuUOX8 YH75cHXVxM9K1I+B4rysFlnTJlpHMzpnNGu/jAGCuLzM+nmVq7O2JRb3FqUYs/YH7T1nXci366vTh TbRFWi5pjiuJwZgtHLE30wpzDTb0VNZSiDDV9FqnaIaoJsbi3ODrQUKKxjIC7X/35NJfJ0psiEBQN whFktny8bvxvP3/OGsUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pF3j6-004sXk-78; Tue, 10 Jan 2023 01:46:56 +0000 Received: from out-116.mta0.migadu.com ([91.218.175.116]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pF3j2-004sWb-Es for linux-arm-kernel@lists.infradead.org; Tue, 10 Jan 2023 01:46:54 +0000 Date: Tue, 10 Jan 2023 01:46:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1673315206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SSeiwC3s3cJoXlLV8jS7SBzzL1+BanzZceIbNoX9d3k=; b=H1u4fUJdXGGjVE1x4tl17b3T09Yzmb9uqfxFo7mXxELZBVaxhxxEwXLFdSJKWRfKPh43l/ 0oUr2pQectj9J2sz4fQdhlLTTCo99pdqv6t1FDHSJa37L/th0vJVMyBwxmm+o05zpaNbEm VKVtmOVySzREnwin81U4TRlwqdYZdb0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Reiji Watanabe Cc: Marc Zyngier , kvmarm@lists.cs.columbia.edu, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Ricardo Koller , Jing Zhang , Raghavendra Rao Anata Subject: Re: [PATCH 2/7] KVM: arm64: PMU: Use reset_pmu_reg() for PMUSERENR_EL0 and PMCCFILTR_EL0 Message-ID: References: <20221230035928.3423990-1-reijiw@google.com> <20221230035928.3423990-3-reijiw@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230109_174652_947838_6571CC02 X-CRM114-Status: GOOD ( 13.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 09, 2023 at 05:17:59PM -0800, Reiji Watanabe wrote: > On Sun, Jan 8, 2023 at 11:13 AM Oliver Upton wrote: > > > > On Thu, Dec 29, 2022 at 07:59:23PM -0800, Reiji Watanabe wrote: > > > The default reset function for PMU registers (reset_pmu_reg()) > > > now simply clears a specified register. Use that function for > > > PMUSERENR_EL0 and PMCCFILTR_EL0, since those registers should > > > simply be cleared on vCPU reset. > > > > AFAICT, the fields in both these registers have UNKNOWN reset values. Of > > course, 0 is an entirely valid reset value but the architectural > > behavior should be mentioned in the commit message. > > Uh, yeah, the commit message was misleading. > The fields in both these registers have UNKNOWN reset values. > The ones for 32bit registers (PMUSERENR and PMCCFILTR) have zero reset > values though. Gosh, that silly (but highly relevant) detail escaped me. > I will update the commit message to mention those explicitly. Thanks! -- Best, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel