From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1076C25B4E for ; Tue, 24 Jan 2023 09:26:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sXNZ1nio+AsTrMuIZ/rQWf8hRVxoJ/IoOTKvwiLvrIk=; b=v9nQurVT/oIp4Q 19l9H6QRvxqJuQ6JGFIvpLmK0brh+KxQKZ/IVX3nvuZj1AxYZL7Xd+BE9xcoUq7+bbTxDVl+Ux9es 9I9Df9eF5vCjVDxUSDqZvBDEi8MSlxOPMsttXJJiHLVT16bjJeU0g6aM1ckEsr9zaGEdcPUlu20mH KTM6Pa6To/cGdj0KzHBR9DqXhHxF3KKwfOYispsG+z9u4G2X052zxXRd7TdHnlFYRgezXMefqeWOx N8cQywuhZNqlirqKgDHSRRABLuROK7qEIV4I/YgQ3o0WqpRfiHH5UFxc4BLK9lpGTsO+7dskTpXUH qA7upcUmXRdzkJ4X7R8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKFYt-002uC3-Jb; Tue, 24 Jan 2023 09:25:52 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKFTl-002rh9-8e for linux-arm-kernel@lists.infradead.org; Tue, 24 Jan 2023 09:20:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6D33FC14; Tue, 24 Jan 2023 01:21:08 -0800 (PST) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D536C3F64C; Tue, 24 Jan 2023 01:20:25 -0800 (PST) Date: Tue, 24 Jan 2023 09:20:23 +0000 From: Cristian Marussi To: Dan Carpenter Cc: Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] firmware: arm_scmi: Clean up a return statement Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230124_012033_380458_33A252B9 X-CRM114-Status: GOOD ( 16.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 23, 2023 at 06:07:07PM +0300, Dan Carpenter wrote: > The comments say "enabled" where "disabled" is intended. Also it's > cleaner to return zero explicitly instead of ret. > > Signed-off-by: Dan Carpenter > --- > drivers/firmware/arm_scmi/driver.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index d21c7eafd641..703f16ef3953 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -2739,8 +2739,8 @@ static int scmi_probe(struct platform_device *pdev) > if (ret) > goto clear_dev_req_notifier; > > - /* Bail out anyway when coex enabled */ > - return ret; > + /* Bail out anyway when coex disabled. */ > + return 0; > } > > /* Coex enabled, carry on in any case. */ > -- Indeed. Thanks, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel