From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A0BCC25B4E for ; Sun, 22 Jan 2023 19:59:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DL3/miQwRjVSwmcukB4JlPMx03VIL3DPJZaKkXS3OCc=; b=wNgyRZLPR7zXq+ F33kZ/ThiVeTuw0O6P8PFhOtcqKPxp76/DkChvAhbtwCrvEz5QpU+4qqDdNVFpxj//p8WZBr7vJAy qiEU2p0vyeK4cv/nkfeAJIPue/h6NXCXhGLJSA+JW3UV/1d92wgzYivpFQ8l49zuaXLZi+4tGON6/ CI5UF5Pzs9FpTQ3A6IYCdet1bNqJPqhaibCB/Es1M3uZMx9/8sQln6F6Svof4cwGTamcuK2uFsDc1 G3jWdP/GLNPMWLocvvHzvyoA+LpNAvIeT1+OIohaI1/TnYiSI7ImnfK5yihI48slU973uJpKUXT1c 4zQCA0iEMc4dToL8N8BA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJgUL-00Fkdu-6Q; Sun, 22 Jan 2023 19:58:49 +0000 Received: from msg-2.mailo.com ([213.182.54.12]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJgUH-00FkdU-AY for linux-arm-kernel@lists.infradead.org; Sun, 22 Jan 2023 19:58:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1674417497; bh=vZNTtC3Dv85fvpewSFT9EPV1WdQx9UU0icVC/gLXpZA=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=VQC2vkd0Jf3kWtj5rL/gMzgNHx7GBAKL5s2xXBy0VjJcIp4qR7Jy9ty6aa6hlerOY XrCf3Qc1cpt6ywepyg1KuekJv59EGSDH3ydQV7zTEFNwZ8LfQVHd/pSZQkwHv9LYSO rafbB98807mOG67ZRFNwp3MdCID1BbMMjPQETyBQ= Received: by b-1.in.mailobj.net [192.168.90.11] with ESMTP via ip-206.mailobj.net [213.182.55.206] Sun, 22 Jan 2023 20:58:16 +0100 (CET) X-EA-Auth: UUytB4HwIT+64TEgEE7NWRD7K5gycSmLjAyS91o7Vs9MdbvAqcrmqg9A9hlbQT0rMt/LxdVe6fsQyXKuWMnxJpP+yT1Ylrkg Date: Mon, 23 Jan 2023 01:28:12 +0530 From: Deepak R Varma To: Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Saurabh Singh Sengar , Praveen Kumar Subject: Re: [PATCH v2] staging: media: imx: change imx_media_fim_set_stream() to return void Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230122_115845_539634_747A6EA6 X-CRM114-Status: GOOD ( 19.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 03, 2023 at 11:08:20PM +0530, Deepak R Varma wrote: > At present, the function imx_media_fim_set_stream() always returns 0. > So, convert it to be a function returning void instead. Issue identified > using the returnvar.cocci Coccinelle semantic patch. > > Signed-off-by: Deepak R Varma > --- > Changes in v2: > 1. Convert the function return type from int to void. Suggested by > Fabio Estevam > 2. Update patch subject and log accordingly. Hello, May I request a review and feedback comment on this patch proposal please? Thank you, ./drv > > > drivers/staging/media/imx/imx-media-csi.c | 7 ++----- > drivers/staging/media/imx/imx-media-fim.c | 8 +++----- > drivers/staging/media/imx/imx-media.h | 6 +++--- > 3 files changed, 8 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c > index 5c3cc7de209d..44d87fe30d52 100644 > --- a/drivers/staging/media/imx/imx-media-csi.c > +++ b/drivers/staging/media/imx/imx-media-csi.c > @@ -779,11 +779,8 @@ static int csi_start(struct csi_priv *priv) > goto idmac_stop; > > /* start the frame interval monitor */ > - if (priv->fim && priv->dest == IPU_CSI_DEST_IDMAC) { > - ret = imx_media_fim_set_stream(priv->fim, output_fi, true); > - if (ret) > - goto idmac_stop; > - } > + if (priv->fim && priv->dest == IPU_CSI_DEST_IDMAC) > + imx_media_fim_set_stream(priv->fim, output_fi, true); > > ret = ipu_csi_enable(priv->csi); > if (ret) { > diff --git a/drivers/staging/media/imx/imx-media-fim.c b/drivers/staging/media/imx/imx-media-fim.c > index fb6590dcfc36..f456751f100a 100644 > --- a/drivers/staging/media/imx/imx-media-fim.c > +++ b/drivers/staging/media/imx/imx-media-fim.c > @@ -368,12 +368,11 @@ void imx_media_fim_eof_monitor(struct imx_media_fim *fim, ktime_t timestamp) > } > > /* Called by the subdev in its s_stream callback */ > -int imx_media_fim_set_stream(struct imx_media_fim *fim, > - const struct v4l2_fract *fi, > - bool on) > +void imx_media_fim_set_stream(struct imx_media_fim *fim, > + const struct v4l2_fract *fi, > + bool on) > { > unsigned long flags; > - int ret = 0; > > v4l2_ctrl_lock(fim->ctrl[FIM_CL_ENABLE]); > > @@ -393,7 +392,6 @@ int imx_media_fim_set_stream(struct imx_media_fim *fim, > fim->stream_on = on; > out: > v4l2_ctrl_unlock(fim->ctrl[FIM_CL_ENABLE]); > - return ret; > } > > int imx_media_fim_add_controls(struct imx_media_fim *fim) > diff --git a/drivers/staging/media/imx/imx-media.h b/drivers/staging/media/imx/imx-media.h > index f679249d82e4..6f9a46573edd 100644 > --- a/drivers/staging/media/imx/imx-media.h > +++ b/drivers/staging/media/imx/imx-media.h > @@ -246,9 +246,9 @@ int imx_media_dev_notifier_register(struct imx_media_dev *imxmd, > /* imx-media-fim.c */ > struct imx_media_fim; > void imx_media_fim_eof_monitor(struct imx_media_fim *fim, ktime_t timestamp); > -int imx_media_fim_set_stream(struct imx_media_fim *fim, > - const struct v4l2_fract *frame_interval, > - bool on); > +void imx_media_fim_set_stream(struct imx_media_fim *fim, > + const struct v4l2_fract *frame_interval, > + bool on); > int imx_media_fim_add_controls(struct imx_media_fim *fim); > struct imx_media_fim *imx_media_fim_init(struct v4l2_subdev *sd); > void imx_media_fim_free(struct imx_media_fim *fim); > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel