From: Sasha Levin <sashal@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Will Deacon <will@kernel.org>, kernel test robot <lkp@intel.com>,
akpm@linux-foundation.org, anshuman.khandual@arm.com,
wangkefeng.wang@huawei.com, liushixin2@huawei.com,
david@redhat.com, tongtiangen@huawei.com, yuzhao@google.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH AUTOSEL 5.4 05/16] arm64/mm: Define dummy pud_user_exec() when using 2-level page-table
Date: Sun, 22 Jan 2023 19:59:27 -0500 [thread overview]
Message-ID: <Y83b7370jLnWbyx9@sashalap> (raw)
In-Reply-To: <Y8WX1/q8dSEAPDy0@arm.com>
On Mon, Jan 16, 2023 at 06:30:47PM +0000, Catalin Marinas wrote:
>On Mon, Jan 16, 2023 at 09:05:08AM -0500, Sasha Levin wrote:
>> From: Will Deacon <will@kernel.org>
>>
>> [ Upstream commit 4e4ff23a35ee3a145fbc8378ecfeaab2d235cddd ]
>>
>> With only two levels of page-table, the generic 'pud_*' macros are
>> implemented using dummy operations in pgtable-nopmd.h. Since commit
>> 730a11f982e6 ("arm64/mm: add pud_user_exec() check in
>> pud_user_accessible_page()"), pud_user_accessible_page() unconditionally
>> calls pud_user_exec(), which is an arm64-specific helper and therefore
>> isn't defined by pgtable-nopmd.h. This results in a build failure for
>> configurations with only two levels of page table:
>>
>> arch/arm64/include/asm/pgtable.h: In function 'pud_user_accessible_page':
>> >> arch/arm64/include/asm/pgtable.h:870:51: error: implicit declaration of function 'pud_user_exec'; did you mean 'pmd_user_exec'? [-Werror=implicit-function-declaration]
>> 870 | return pud_leaf(pud) && (pud_user(pud) || pud_user_exec(pud));
>> | ^~~~~~~~~~~~~
>> | pmd_user_exec
>>
>> Fix the problem by defining pud_user_exec() as pud_user() in this case.
>>
>> Link: https://lore.kernel.org/r/202301080515.z6zEksU4-lkp@intel.com
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Will Deacon <will@kernel.org>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>I don't think this patch should be backported to 5.4. It is a fix for a
>commit that went in shortly before this one (730a11f982e6). The latter
>commit does have a Fixes tag but I guess Will thought it's not worth a
>cc stable (and it's up to 5.19 anyway).
Ack, I'll drop it.
--
Thanks,
Sasha
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-23 1:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230116140520.116257-1-sashal@kernel.org>
2023-01-16 14:05 ` [PATCH AUTOSEL 5.4 05/16] arm64/mm: Define dummy pud_user_exec() when using 2-level page-table Sasha Levin
2023-01-16 18:30 ` Catalin Marinas
2023-01-23 0:59 ` Sasha Levin [this message]
2023-01-16 14:05 ` [PATCH AUTOSEL 5.4 06/16] cpufreq: armada-37xx: stop using 0 as NULL pointer Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y83b7370jLnWbyx9@sashalap \
--to=sashal@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liushixin2@huawei.com \
--cc=lkp@intel.com \
--cc=stable@vger.kernel.org \
--cc=tongtiangen@huawei.com \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).