From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC201C25B4E for ; Mon, 23 Jan 2023 01:00:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6vyitrBP6e5wjDJB6GAY1Lr0zOrgXdevAiygYYHm2jk=; b=IIxb9LpEtXmtt/+qXU9NvY3Skd nZZAgaaXoyCgnsg6ONsC6OzTh/GLgzPw26azUFDC71BhHQGP7242LfqrtC4yQVFUE6Q6gdlfhzGOY D1T26A/s6pCtvJ61vQtPjPi2N/2tS2asvRbnf+c/RViC9WEWL0NLWgWCpYqA+0SUD+elQki/wFKjg IiLfuxygSBlJqT/QDtekt0pW5Mx+6+EFNTMsVIImSL3sdmbRy9y5q3BVGJlZnMSwAh82DwxVS3aXY ocHeJvNWFL2uVqW7oTJd+8IQdHs2h7QXwL9g9THb+ZZBCLtq6JNeC4ViQKa+n/Fopr4QRF7VAhTj1 Rlur3HJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJlBV-00Fv4Y-8d; Mon, 23 Jan 2023 00:59:41 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJlBR-00Fv3o-LD for linux-arm-kernel@lists.infradead.org; Mon, 23 Jan 2023 00:59:39 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D45EB60CEC; Mon, 23 Jan 2023 00:59:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04C22C433EF; Mon, 23 Jan 2023 00:59:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674435569; bh=NCthFj9GZBr2LLZm13hQBSasePv4YP50exC3frgkfeI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ai2lLRrxUwPhzfYlE8r1410J9AW+xz6xYFnEXavnhGEGSmHYbFkDhoVV3+dk9EnI4 nRM/49X/CJHpnRn4Edr7/5UarPloyOB6K9HXquBirgslHRSKtc2Y0qIs7EaEbTe2/D JauxrwHadQRfaN+G1Ao6Ttz2yzWkJ13hkopAMwzS/m+xez3PYpu/TsromicTVEmoT0 STe2dFzRQ0EPB8Y/1y3F/KOpHCTvGPELULMfI70ndOCzXO5Ix0TvHgVPTjKcWX6reJ f+mVh46FjSjJ53HepYolHGJpDuNDt0Myy/k5zV1NkIep8vDKg9wPWQ8vGESZK5p+Om AS/Hn2ahhiMuA== Date: Sun, 22 Jan 2023 19:59:27 -0500 From: Sasha Levin To: Catalin Marinas Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Will Deacon , kernel test robot , akpm@linux-foundation.org, anshuman.khandual@arm.com, wangkefeng.wang@huawei.com, liushixin2@huawei.com, david@redhat.com, tongtiangen@huawei.com, yuzhao@google.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH AUTOSEL 5.4 05/16] arm64/mm: Define dummy pud_user_exec() when using 2-level page-table Message-ID: References: <20230116140520.116257-1-sashal@kernel.org> <20230116140520.116257-5-sashal@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230122_165937_778537_4E795EF2 X-CRM114-Status: GOOD ( 14.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 16, 2023 at 06:30:47PM +0000, Catalin Marinas wrote: >On Mon, Jan 16, 2023 at 09:05:08AM -0500, Sasha Levin wrote: >> From: Will Deacon >> >> [ Upstream commit 4e4ff23a35ee3a145fbc8378ecfeaab2d235cddd ] >> >> With only two levels of page-table, the generic 'pud_*' macros are >> implemented using dummy operations in pgtable-nopmd.h. Since commit >> 730a11f982e6 ("arm64/mm: add pud_user_exec() check in >> pud_user_accessible_page()"), pud_user_accessible_page() unconditionally >> calls pud_user_exec(), which is an arm64-specific helper and therefore >> isn't defined by pgtable-nopmd.h. This results in a build failure for >> configurations with only two levels of page table: >> >> arch/arm64/include/asm/pgtable.h: In function 'pud_user_accessible_page': >> >> arch/arm64/include/asm/pgtable.h:870:51: error: implicit declaration of function 'pud_user_exec'; did you mean 'pmd_user_exec'? [-Werror=implicit-function-declaration] >> 870 | return pud_leaf(pud) && (pud_user(pud) || pud_user_exec(pud)); >> | ^~~~~~~~~~~~~ >> | pmd_user_exec >> >> Fix the problem by defining pud_user_exec() as pud_user() in this case. >> >> Link: https://lore.kernel.org/r/202301080515.z6zEksU4-lkp@intel.com >> Reported-by: kernel test robot >> Signed-off-by: Will Deacon >> Signed-off-by: Sasha Levin > >I don't think this patch should be backported to 5.4. It is a fix for a >commit that went in shortly before this one (730a11f982e6). The latter >commit does have a Fixes tag but I guess Will thought it's not worth a >cc stable (and it's up to 5.19 anyway). Ack, I'll drop it. -- Thanks, Sasha _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel