From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8169C05027 for ; Mon, 23 Jan 2023 09:52:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oR3X+ZH7cSxqMmkUSJmlAw6vro4i56D4U6w7NnE4esQ=; b=JegZJaPja6uGN8 psmChrzG4WyLsWSO5+/DA3mtkRMry8KEN5GcUcIVCIW8t9Y4CL3XorWK/dYecvnEsXOyaezJKlAy4 xSZrZZpUwpbgIMph8zcxmjNiRSiwPCcVqolark+sSoTbz4CBxBq4t9A67RrGWdRSIrnGaiPP7ZEEX zOyfa5LnjGivt8av9syOUiR/s4gxioF9tQPrFXwJ0XEkhIq7wDSjeDmN9OLfAO7mwyfxDVopYbCYT 0jURRstdbhVRVOvsjJDC0fl/0ss67GGE709Xf3J22w3iON6sqdI94omr1mqGVAeQwkJ7ujy7F5GBk /wagWVp45laZsoTKXvtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJtUD-00GagG-7W; Mon, 23 Jan 2023 09:51:33 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJtU9-00Gaeq-AU for linux-arm-kernel@lists.infradead.org; Mon, 23 Jan 2023 09:51:30 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D193C60E00; Mon, 23 Jan 2023 09:51:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B19F0C433EF; Mon, 23 Jan 2023 09:51:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1674467488; bh=I1TFqfaAYrE67AWuhwWFFkrdbPVOTogsIu0uGhqZTMc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KUjTYbl3HSo04F7350eYhPO++nuP3ClQEi4/mYv1LTVeS1HcAahmC6f3QiKxhUSK0 cLhlfWr9Tgcf8Fn8o9sDFM23S4fteDSwKEB7WdAOV2uJCMLLeH4TuKVCzlUPB6zwq+ mmhUIZWAHUv1EUx8mlzjIDzcy0s4w25PHrPB6w+0= Date: Mon, 23 Jan 2023 10:51:25 +0100 From: Greg Kroah-Hartman To: Li Chen Cc: Jiri Slaby , Li Chen , Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , open list , "open list:SERIAL DRIVERS" , "moderated list:ARM/Ambarella SoC support" , "open list:DMA BUFFER SHARING FRAMEWORK" , "open list:DMA BUFFER SHARING FRAMEWORK" , "moderated list:DMA BUFFER SHARING FRAMEWORK" Subject: Re: [PATCH 10/15] serial: ambarella: add support for Ambarella uart_port Message-ID: References: <20230123073305.149940-1-lchen@ambarella.com> <20230123073305.149940-11-lchen@ambarella.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230123073305.149940-11-lchen@ambarella.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230123_015129_442170_7BC61974 X-CRM114-Status: GOOD ( 12.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 23, 2023 at 03:32:25PM +0800, Li Chen wrote: > This driver add support for Ambarella's uart, which > can be used for console and etc. > > Signed-off-by: Li Chen > Change-Id: Ie68af7ad2187e21853e58d52cd97fd7145303730 > --- > MAINTAINERS | 1 + > drivers/tty/serial/Kconfig | 16 + > drivers/tty/serial/Makefile | 1 + > drivers/tty/serial/ambarella_uart.c | 1581 +++++++++++++++++++++++++++ > drivers/tty/serial/ambarella_uart.h | 120 ++ Why do you need a .h file for a single .c file? They should all be in one file please. Also, no change-id, you know this... thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel