From: Dan Carpenter <error27@gmail.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Brent Pappas <bpappas@pappasbrent.com>,
slongerbeam@gmail.com, festevam@gmail.com,
p.zabel@pengutronix.de, gregkh@linuxfoundation.org,
s.hauer@pengutronix.de, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-imx@nxp.com,
kernel@pengutronix.de, mchehab@kernel.org, shawnguo@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH] media: imx: imx-media-fim: Replace macro icap_enabled() with function
Date: Tue, 24 Jan 2023 07:18:46 +0300 [thread overview]
Message-ID: <Y89cJvIYtg9fkczb@kadam> (raw)
In-Reply-To: <20230123215105.fbfzxueegtnbu4ym@pengutronix.de>
On Mon, Jan 23, 2023 at 10:51:05PM +0100, Marco Felsch wrote:
> > -#define icap_enabled(fim) ((fim)->icap_flags != IRQ_TYPE_NONE)
> > +static bool icap_enabled(struct imx_media_fim *fim)
> > +{
> > + return fim->icap_flags != IRQ_TYPE_NONE;
> > +}
>
> Nit: I would make it inline but recent compiler may do the job for us.
>
Yeah. These days we tend to not make things inline.
regards,
dan carpenter
> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
>
> Regards,
> Marco
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-01-24 4:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 19:17 [PATCH] media: imx: imx-media-fim: Replace macro icap_enabled() with function Brent Pappas
2023-01-23 21:51 ` Marco Felsch
2023-01-24 4:18 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y89cJvIYtg9fkczb@kadam \
--to=error27@gmail.com \
--cc=bpappas@pappasbrent.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=m.felsch@pengutronix.de \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).