From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5D37C25B4E for ; Tue, 24 Jan 2023 04:20:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GstMgQPdyxBvzEf3hx/BRrSyO3D/9T2leGIkRBdM3pY=; b=vQKFxBJUYmn36x wMNbS+WcEUODFjAeLnzlwqwmyuIX3qJ5R3h4oSZV455t3qRIL9+qf4yDH54RfexK5ImICfoWFBcWS u6LGiqtTA+BnFnP999YrDkkHG4o/+Wl49OIcRvjLGJN4io9oV5SWYqsrrU4YLgWicTE28oFAdtAEr aa84nt5SoCyk8zKJM1qPS6/dxqgZ/FcjMvbNlNqUOpR5IHkyryYLSuUGdTEu/33jaEdJ/6UpMVuC/ HtotzMh2LDqh5s5aZyIjZlY/Qa88LAJbyySpua3ivGf7SWQK9kInlFRxNE9w0hLXR3vzPdLOjedfG GPHCzERj0dq1KLa/Crkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKAlt-002EZ4-Mk; Tue, 24 Jan 2023 04:18:57 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKAlq-002EYM-2c for linux-arm-kernel@lists.infradead.org; Tue, 24 Jan 2023 04:18:55 +0000 Received: by mail-wr1-x430.google.com with SMTP id d2so12652010wrp.8 for ; Mon, 23 Jan 2023 20:18:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=K4pDbcj74Wbcg/58B56E40yhsIDYcgblc7WuBVkYMZ4=; b=eEJh06r4R2daIAfn1xURfmMwc6qN973syj6XOdabRBcw6azMQ5FfxwuCzR4zeVqkA8 3Wi+XkZG1BjPit6NU6Rm6W7jZboN0MVD9PJIIoCSevZZcf1Q6IvGUrJorvT+RhDbMs95 7sin78GW3njueM3IwlL9PByEEjeRW/XTEnmrbxtxwAsvYlPtsgSuI21VVKkjxvwpJIsx Kat8B1UGTgTxBeMcBsUjbDE51ISlEc74rbNYGTluOJHgVfiZaOKat5aT/OjRrmDFF6EW VQuNdyrHBWhMQ9Ma2gNd1plgI94qxscklnpCkCu4V8e6x91JreoOQzBuRkJMjrXAJWtl mrwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=K4pDbcj74Wbcg/58B56E40yhsIDYcgblc7WuBVkYMZ4=; b=XTvD1pFD2VCedds5MxEJkyYMgPAosZikiymXGd5aoN00avV87Zo7FK8P7E1cVkexUu O23FM2iSujLhEcp78uWdH9TfHNn2kJk6oMzzIVMYvtsPVhtzIeuFkc242iAGy1nRu4Or S3dCWjD2EtAYhJ4g4h2/qwi9TRU3hMwlptrdo4ndg4izLH7f7BXxkOrGDwRPMApmDuBS NkphYgJIvnt0rS/pLrlcvc8dSqmz/xQD8ScBXwulQG3AWRMyKKFn7Bwuiu4MCdDR5crd roi+OcHb/Ft/VJRflgaB+i1uH/X1zcAJg65Gw0JhPACegs30ePAioyWE6Pw3aPqpM6Qr gqsQ== X-Gm-Message-State: AFqh2krBuFCM96eEBbWrJdQcgpHdx0wztp328pwdJZGi9LQnWQSurBvh ylsqTlKw1RmFcuuEA9Zlexk= X-Google-Smtp-Source: AMrXdXuU+RiiQVIsOLUuAcUY0r7W+UMek2Ck+OomzTAKLbAZyP7BRoLqhtHT6QAV56t8J/dUfiLDzQ== X-Received: by 2002:a05:6000:603:b0:26b:e7e1:ad03 with SMTP id bn3-20020a056000060300b0026be7e1ad03mr26304968wrb.55.1674533930714; Mon, 23 Jan 2023 20:18:50 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id bv17-20020a0560001f1100b002be2f18938csm823273wrb.41.2023.01.23.20.18.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 20:18:50 -0800 (PST) Date: Tue, 24 Jan 2023 07:18:46 +0300 From: Dan Carpenter To: Marco Felsch Cc: Brent Pappas , slongerbeam@gmail.com, festevam@gmail.com, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, s.hauer@pengutronix.de, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, mchehab@kernel.org, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: Re: [PATCH] media: imx: imx-media-fim: Replace macro icap_enabled() with function Message-ID: References: <20230123191714.22430-1-bpappas@pappasbrent.com> <20230123215105.fbfzxueegtnbu4ym@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230123215105.fbfzxueegtnbu4ym@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230123_201854_153932_36EB6379 X-CRM114-Status: GOOD ( 10.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 23, 2023 at 10:51:05PM +0100, Marco Felsch wrote: > > -#define icap_enabled(fim) ((fim)->icap_flags != IRQ_TYPE_NONE) > > +static bool icap_enabled(struct imx_media_fim *fim) > > +{ > > + return fim->icap_flags != IRQ_TYPE_NONE; > > +} > > Nit: I would make it inline but recent compiler may do the job for us. > Yeah. These days we tend to not make things inline. regards, dan carpenter > Reviewed-by: Marco Felsch > > Regards, > Marco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel