From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0E92C54EBD for ; Thu, 12 Jan 2023 13:25:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2APsI8e6B6M228en5LTN2ALjT5ib3BOzd8ThvhQ4zks=; b=d67h72s5OqXX7s WXVk/xwjjW/G3NoEe0BgNWq3b1QHzXsGZF8Q4xk+MpGXFPnb96C/cX2bSYLeMi02J1+MQjj8Tfrm1 tzY+YbicZJbpjn9xueDwdMUrQeRiJdLMhOmMCq7yq6fSG8ebmhaVbBO/Rj85Q0ekbBSUY8I23poyW yogkGY7d3PyNX32p1zgoo3RESjuvv81XHN/u85PfZRf6kwVMb+ykvD46We8wQEpfopHYVSmy85qqy 2+R0ByrBkJ9d63GuVyHIWDqt1EXp+8t15zJbhSbnNph3HpnXvX1+xvdKZol/8wTUxHuNwhkPM5frv c1nbBdXsbY6omcGtjHtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFxZF-00F8gB-1U; Thu, 12 Jan 2023 13:24:29 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFxZB-00F8eh-Um for linux-arm-kernel@lists.infradead.org; Thu, 12 Jan 2023 13:24:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E9A4413D5; Thu, 12 Jan 2023 05:25:03 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.43.206]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9CA863F67D; Thu, 12 Jan 2023 05:24:20 -0800 (PST) Date: Thu, 12 Jan 2023 13:24:17 +0000 From: Mark Rutland To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , Marc Zyngier , Mark Brown Subject: Re: [PATCH V7 2/6] arm64/perf: Add BRBE registers and fields Message-ID: References: <20230105031039.207972-1-anshuman.khandual@arm.com> <20230105031039.207972-3-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230105031039.207972-3-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230112_052426_066944_ECAEAB96 X-CRM114-Status: GOOD ( 11.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Anshuman, On Thu, Jan 05, 2023 at 08:40:35AM +0530, Anshuman Khandual wrote: > This adds BRBE related register definitions and various other related field > macros there in. These will be used subsequently in a BRBE driver which is > being added later on. I haven't verified the specific values, but this looks good to me aside from one minor nit below. [...] > +# This is just a dummy register declaration to get all common field masks and > +# shifts for accessing given BRBINF contents. > +Sysreg BRBINF_EL1 2 1 8 0 0 We don't need a dummy declaration, as we have 'SysregFields' that can be used for this, e.g. SysregFields BRBINFx_EL1 ... EndSysregFields ... which will avoid accidental usage of the register encoding. Note that I've also added an 'x' there in place of the index, which we do for other registers, e.g. TTBRx_EL1. Could you please update to that? With that: Acked-by: Mark Rutland Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel